Commit graph

12 commits

Author SHA1 Message Date
gfyoung
ddca49e4b5 Enable frozen string in apps/uploaders/*.rb
Partially addresses #47424.
2018-07-16 06:41:59 -07:00
Andrew Newdigate
bb65cb1fd5 Remove healthchecks from prometheus endpoint 2018-07-12 17:37:51 +00:00
Zeger-Jan van de Weg
65840591cd
Gitaly metrics check for read/writeability
Prior to this change, health checks checked for writeability of the NFS
shards. Given we're moving away from that, this patch extends the checks
for Gitaly to check for read and writeability.

Potentially some dashboards will break, as over time these metrics will
no longer appear as Prometheus doesn't get the data anymore.
Observability in the circuit breaker will be reduced, but its not
expected to be turned on and the circuit breaker is being removed soon
too.

Closes https://gitlab.com/gitlab-org/gitaly/issues/1218
2018-06-27 08:56:19 +02:00
Pawel Chojnacki
ee22a47d62 Update prometheus-client-mmap gem to highly optimized version
+ change string concatenation to help with GC pressure.
+ fix metric producing incompatible label sets
2017-12-07 17:47:23 +01:00
Pawel Chojnacki
8a0e314463 Remove Filesystem check metrics that use too much CPU to handle requests 2017-11-02 09:55:42 -07:00
Paweł Chojnacki
2c3d52161a Update Prometheus gem to version that explicitly calls munmap 2017-07-19 08:54:39 +00:00
Paul Charlton
cb3b4a15e6 Support multiple Redis instances based on queue type 2017-07-11 03:35:47 +00:00
Pawel Chojnacki
d26573c6e3 Make PrometheusTextFormat return proper output terminated with '\n'
remove file dangling after rebase
2017-06-02 19:48:39 +02:00
Pawel Chojnacki
b668aaf426 Split the metrics implementation to separate modules for Influx and Prometheus 2017-06-02 19:45:58 +02:00
Pawel Chojnacki
ae8f7666e5 Add prometheus text formatter
+ rename controler method to #index from #metrics
 + remove assertion from nullMetric
2017-06-02 19:45:58 +02:00
Pawel Chojnacki
c134a72cdb Move Prometheus presentation logic to PrometheusText
+ Use NullMetrics to mock metrics when unused
+ Use method_missing in NullMetrics mocking
+ Update prometheus gem to version that correctly uses transitive dependencies
+ Ensure correct folders are used in Multiprocess prometheus client tests.
+ rename Sessions controller's metric
2017-06-02 19:45:58 +02:00
Pawel Chojnacki
254830c1f9 Move most of MetricsController logic to MetricsService 2017-06-02 19:45:58 +02:00