Commit graph

25 commits

Author SHA1 Message Date
Stan Hu
660dcd5b7c Fix Bitbucket Server importer error handling
The importer would display a 500 error page if you attempted to import
using a non-existent DNS entry. This commit rescues known network issues
and consolidates them into
BitbucketServer::Connection::ConnectionError`.  The previous error
handling in the paginator doesn't work because it returns a lazy
collection.

Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/56154
2019-01-12 22:14:08 -08:00
Stan Hu
5b6d5301d9 Paginate Bitbucket Server importer projects
To prevent delays in loading the page and reduce memory usage, limit the
number of projects shown at 25 per page.

Part of https://gitlab.com/gitlab-org/gitlab-ce/issues/50021
2018-11-07 11:37:46 -08:00
Yorick Peterse
2039c8280d
Disable existing offenses for the CodeReuse cops
This whitelists all existing offenses for the various CodeReuse cops, of
which most are triggered by the CodeReuse/ActiveRecord cop.
2018-09-11 17:32:00 +02:00
Stan Hu
aa5821e571 Assorted Bitbucket Server importer code cleanup based on review 2018-08-01 10:45:04 -07:00
Stan Hu
b2da3a351a Remove extra space in app/controllers/import/bitbucket_server_controller.rb 2018-08-01 10:04:47 -07:00
Stan Hu
0b2db3324b Inline repo_owner in app/controllers/import/bitbucket_server_controller.rb 2018-08-01 10:04:17 -07:00
Stan Hu
d27ae9f55d Fix Rubocop error 2018-07-27 05:14:12 -07:00
Stan Hu
73f366e08f Consolidate validation logic 2018-07-26 23:10:56 -07:00
Stan Hu
3f715bb438 Consolidate server errors and add specs 2018-07-26 23:05:22 -07:00
Stan Hu
0612b07037 Remove unnecessary guard clause 2018-07-25 21:49:29 -07:00
Stan Hu
e47cf67e80 Add frozen_string_literal: true to controller 2018-07-25 15:01:37 -07:00
Stan Hu
ff3291e56d Tighten up regular expression for project names 2018-07-25 05:19:22 -07:00
Stan Hu
4b3fb68c2d Fix bug in rejecting already added repositories 2018-07-17 21:50:37 -07:00
Stan Hu
15220291ae Add spec for BitbucketServer::Connection 2018-07-12 22:33:36 -07:00
Stan Hu
0936bff496 Finish specs for spec/controllers/import/bitbucket_server_controller_spec.rb 2018-07-09 16:04:41 -07:00
Stan Hu
d5ac4ea32f Fix Rubocop error 2018-07-08 21:36:02 -07:00
Stan Hu
589a28889a Test server connection error 2018-07-08 14:57:30 -07:00
Stan Hu
4c5085f68d Add spec for project not found 2018-07-08 07:49:47 -07:00
Stan Hu
5d7e130e64 Add more specs and fix some typos 2018-07-08 07:44:33 -07:00
Stan Hu
022a0c2fde Fix Rubocop errors 2018-07-05 21:11:03 -07:00
Stan Hu
a78e36abab Improve error handling of Bitbucket login errors 2018-07-05 14:09:01 -07:00
Stan Hu
3735ce43fc Add a Reconfigure button and improve layout of import screen 2018-07-01 05:13:15 -07:00
Stan Hu
a4cbbfe465 Fix Rubocop complaints 2018-06-28 22:26:33 -07:00
Stan Hu
046a5e398d More work towards supporting Bitbucket Server 2018-06-25 22:40:11 -07:00
Stan Hu
ebd8e4333a WIP: Add support for Bitbucket Server imports 2018-06-25 13:06:10 -07:00