Commit graph

7 commits

Author SHA1 Message Date
Thong Kuah
a2cfc150ce Add # frozen_string_literal to spec/models
Adds `# frozen_string_literal: true` to spec/models ruby files
2019-04-01 14:37:54 +13:00
Stan Hu
52fdddbd2d Cache avatar URLs and paths within a request
In a merge request with many discussions, the avatar URL can be called
thousands of times, inflicting a significant performance penalty
especially when avatars are stored in object storage. To mitigate this
problem, we can just cache the generated path any time it is requested.

Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/55355
2018-12-19 15:34:29 -08:00
Stan Hu
d4bdcfbf19 Disable project avatar validation if avatar has not changed
Every time a column in the projects table is changed, the Avatarable concern
would validate that the avatar file size was under 200K.  This not only delays
the database changes, but it also can lead to unrelated failures if the HTTP
request fails for some reason.

Closes #51053
2018-09-04 12:20:58 -07:00
Tim Zallmann
fac4f50cf6 Send resize parameters for avatars 2018-08-07 06:04:33 +00:00
Micaël Bergeron
741f333d23 Resolve "Avatar URLs are wrong when using a CDN path and Object Storage" 2018-04-23 16:59:53 +00:00
Nick Thomas
93ea3234df
Use the DatabaseCleaner 'deletion' strategy instead of 'truncation' 2018-01-24 17:25:55 +00:00
Douwe Maan
2fbbba9a29 Always return full avatar URL for private/internal groups/projects when asset host is set 2017-11-09 15:40:41 +00:00