Commit graph

8 commits

Author SHA1 Message Date
Toon Claes
dd3d62b626 Make feature spec more robust
Ensure the correct "Public" radio is selected by choosing it on ID.
2017-03-20 22:05:02 +01:00
Stan Hu
681af5bc4f Fix Error 500 when application settings are saved
Due to a Rails bug, fetching the application settings from Redis
may prevent the attribute methods from being loaded for the `ApplicationSetting`
model. More details here: https://github.com/rails/rails/issues/27348

There was also a secondary problem introduced by overriding these
association methods which caused all default visibility levels to be
set to `nil`. Before, the previous implementation allowed the string
"20" to be saved as an integer, while now a table lookup happens
before that. We fix this by enforcing the integer value in the
controller and default to PRIVATE.

Closes #29674
2017-03-18 15:39:48 -07:00
Grzegorz Bizon
632c2939bb Revert "Merge branch 'revert-9cac0317' into 'master' "
This reverts commit c20934869f, reversing
changes made to 4b7ec44b91.
2017-01-23 16:35:24 +01:00
Grzegorz Bizon
baeaa97ef4 Revert "Merge branch 'dont-persist-application-settings-in-test-env' into 'master'"
This reverts merge request !8573
2017-01-21 22:55:35 +00:00
Rémy Coutable
f6cc29ed83 Don't persist ApplicationSetting in test env
Signed-off-by: Rémy Coutable <remy@rymai.me>
2017-01-15 01:07:29 -05:00
Kamil Trzcinski
f5ff372140
Fix failures 2016-12-18 23:34:40 +01:00
Kamil Trzcinski
f9023adbad
Fix spec failures 2016-12-18 23:32:53 +01:00
jurre
0469e7dffd Move admin settings spinach feature to rspec 2016-12-13 17:13:21 +01:00
Renamed from features/steps/admin/settings.rb (Browse further)