Commit graph

24 commits

Author SHA1 Message Date
Phil Hughes
974f9fb135 Added limited width to profile settings
Closes #20918
2017-06-23 16:14:49 +01:00
Kushal Pandya
fb3e365412 HAMLLint: Fix SpaceInsideHashAttributes offences 2016-12-31 11:58:36 +05:30
Kushal Pandya
dd5ffd9ca6 HAMLLint: Fix ImplicitDiv offences 2016-12-31 11:43:08 +05:30
Timothy Andrew
f706a973c2 View-related (and other minor) changes to !5951 based on @rymai's review.
- The `scopes_form` partial can be used in the `admin/applications` view
  as well

- Don't allow partials to access instance variables directly. Instead, pass
  in the instance variables as local variables, and use `local_assigns.fetch`
  to assert that the variables are passed in as expected.

- Change a few instances of `render :partial` to `render`

- Remove an instance of `required: false` in a view, since this is the default

- Inline many instances of a local variable (`ip = 'ip'`) in `auth_spec`
2016-12-16 16:29:32 +05:30
Timothy Andrew
990ae6b8e5 Move the scopes form/list view into a partial.
- The list of scopes that's displayed while creating a personal access
  token is identical to the list that's displayed while creating an OAuth
  application. Extract these into a partial.

- The list of scopes that's displayed while in the show page for an OAuth token
  in the profile settings and admin settings are identical. Extract these into
  a partial.
2016-12-16 16:29:31 +05:30
Timothy Andrew
4d6da770de Implement minor changes from @dbalexandre's review.
- Mainly whitespace changes.

- Require the migration adding the `scope` column to the
  `personal_access_tokens` table to have downtime, since API calls will
  fail if the new code is in place, but the migration hasn't run.

- Minor refactoring - load `@scopes` in a `before_action`, since we're
  doing it in three different places.
2016-12-16 16:29:31 +05:30
Timothy Andrew
6c809dfae8 Allow creating personal access tokens / OAuth applications with scopes. 2016-12-16 15:08:10 +05:30
Phil Hughes
5542c9456c Updated project group sharing UI
Closes #13991
2016-04-25 14:42:17 +01:00
Dmitriy Zaporozhets
324e57693b
Implement top navigation concept for profile area
Main idea is to keep left sidebar static so user is not confused by
changing context. Instead we put changing navigation with changing
content in one main block

Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com>
2016-04-19 20:05:30 +02:00
connorshea
0c082d5e3a Fix the improper delete form being rendered for an oauth_authorized_application
This fixes the authorized applications not being revoked properly at
`/profile/applications`.

Fixes #14370.
2016-04-14 07:24:57 -07:00
Robert Speicher
7a2370f740 Standardize the way we check for and display form errors
- Some views had a "Close" button. We've removed this, because we don't
  want users accidentally hiding the validation errors and not knowing
  what needs to be fixed.
- Some views used `li`, some used `p`, some used `span`. We've
  standardized on `li`.
- Some views only showed the first error. We've standardized on showing
  all of them.
- Some views added an `#error_explanation` div, which we've made
  standard.
2016-04-04 21:37:07 -04:00
Phil Hughes
c23d9ab4ed Fixed error with applications delete enonymous token form
Closes #14509
2016-03-23 13:59:54 +00:00
Arinde Eniola
367818d293 change the css class has_tooltip to has-tooltip universally 2016-03-20 21:37:22 +01:00
Robert Speicher
8f21e2ae40 Let oauth/applications#index handle the profiles#applications route
Previously we were doing all of kinds of code gymnastics and flash abuse
in order to work with a Doorkeeper controller but have it _appear_ at
the `/profile/applications` path. Fortunately we can just tell Rails to
use a different controller to handle that route, and we get the best of
both worlds.
2016-03-13 16:51:09 -04:00
Phil Hughes
c2377a1195 Fixed failing application settings tests 2016-03-04 09:06:07 +00:00
Phil Hughes
33ba32e6cc Applications tab on profile settings
Closes #13855
2016-03-04 09:06:07 +00:00
Douwe Maan
a32f776609 Make tables full width. 2015-10-19 11:19:45 +02:00
Nicolas
4cf7d8d956 Fix consistency issues on New Application page. 2015-06-15 21:27:20 +02:00
Nicolas
f18a24f0ac Fix layout issue when New Application validation fails. 2015-06-15 21:27:15 +02:00
Douwe Maan
4d7759156b Plural instead of singular. 2015-04-30 21:10:42 +02:00
Douwe Maan
26ad250989 Add a page title to every page. 2015-04-30 19:12:15 +02:00
Dmitriy Zaporozhets
30ca451fd4 Refactor buttons 2015-03-14 00:29:32 -07:00
Dmitriy Zaporozhets
592e396869
Rework oauth2 feature
* improve UI
* add authorization
* add separate page for oauth applications

Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com>
2014-12-25 18:35:04 +02:00
Valery Sizov
e41dadcb33 Doorkeeper integration 2014-12-24 15:38:07 +02:00