Commit graph

10 commits

Author SHA1 Message Date
Rémy Coutable
eafe834c3d
Reduce remaining diff with EE in app/services
Signed-off-by: Rémy Coutable <remy@rymai.me>
2019-02-14 12:37:55 +01:00
Thong Kuah
cc1ccbf83a Move non-controller code into dedicated service
This should help with code re-use when we create applications for group
level cluster next.

Change `find_or_initialize_by` to explicitly find or build the right
association based on the application name. The benefit here is that we
use the associations on @cluster rather than querying from the other
side of the association.
2018-10-15 11:07:47 +13:00
Yorick Peterse
2039c8280d
Disable existing offenses for the CodeReuse cops
This whitelists all existing offenses for the various CodeReuse cops, of
which most are triggered by the CodeReuse/ActiveRecord cop.
2018-09-11 17:32:00 +02:00
gfyoung
265478ad74 Enable frozen string in apps/services/**/*.rb
For directories application_settings --> labels.

Partially addresses #47424.
2018-07-16 12:36:41 -07:00
Dmitriy Zaporozhets
1b1d51bb30
Make request argument required for Applications::CreateService
Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com>
2018-06-07 14:22:29 +03:00
Mario de la Ossa
0c994215af
Backport changes in app/services/applications/create_service/rb 2018-06-02 18:44:32 -06:00
James Lopez
232bdd47d9 refactor code 2017-10-31 09:03:59 +01:00
James Lopez
eeacfbd5bf fix specs 2017-10-31 09:03:59 +01:00
James Lopez
11e5218ceb fix spec 2017-10-31 09:03:59 +01:00
James Lopez
72b7b10d52 add applications controller logic 2017-10-31 09:03:59 +01:00