Commit graph

5 commits

Author SHA1 Message Date
Douwe Maan
a9bcddee4c Protect Gitlab::HTTP against DNS rebinding attack
Gitlab::HTTP now resolves the hostname only once, verifies the IP is not
blocked, and then uses the same IP to perform the actual request, while
passing the original hostname in the `Host` header and SSL SNI field.
2019-05-30 10:47:31 -03:00
Sean McGivern
e00c7016b1 Add frozen_string_literal to HipChat files 2019-04-10 12:58:18 +01:00
Sean McGivern
cd9ae6bb82 Revert "Remove HipChat integration from GitLab"
This reverts commit a5378665a1.
2019-04-10 12:58:18 +01:00
Nick Thomas
a5378665a1
Remove HipChat integration from GitLab 2019-02-08 18:20:38 +00:00
Stan Hu
215feb642d Prevent SSRF attacks in HipChat integration
This change monkey patches the HipChat client to use the GitLab HTTParty
connection adapter, which can block access to certain hosts.

Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/51142
2018-10-02 23:04:37 -04:00