Commit graph

9 commits

Author SHA1 Message Date
Rémy Coutable
1c88d92b3f Improve Member services
Signed-off-by: Rémy Coutable <remy@rymai.me>
2018-02-27 16:02:22 +01:00
Rémy Coutable
bf41063679 Remove explicit audit event log in MembershipActions
Move it to Members::ApproveAccessRequestService.

Also, note that there was a double audit event log for access request
destruction.

Signed-off-by: Rémy Coutable <remy@rymai.me>
2018-02-27 16:02:22 +01:00
Stan Hu
46a6edc731 Remove N+1 queries with /projects/:project_id/{access_requests,members} API endpoints
We can simplify the code quite a bit and improve performance by using
grape-entity merge fields:

https://github.com/ruby-grape/grape-entity/tree/v0.6.0#merge-fields

Relates to #42030
2018-01-30 21:46:09 -08:00
Mark Fletcher
062f5b7126 Fix error on empty query for Members API 2018-01-21 16:36:55 +00:00
🙈 jacopo beschi 🙉
729f05f0e3 Adds Rubocop rule for line break around conditionals 2018-01-11 16:34:01 +00:00
Rémy Coutable
63360adeae
Add requirements: { id: %r{[^/]+} } for all projects and groups namespaced API routes
Signed-off-by: Rémy Coutable <remy@rymai.me>
2017-03-16 18:00:24 +01:00
Robert Schilling
c280acb00b Backport API to V3 2017-02-28 08:32:39 +01:00
Robert Schilling
da67dca14b Use grape to validate parameters in the members API 2017-02-23 15:34:57 +01:00
Jarka Kadlecova
88d610c60e Add member: Always return 409 when a member exists 2017-02-10 15:53:01 +01:00