kotovalexarian-likes-gitlab/gitlab-org--gitlab-foss

Fork 0

Commit graph

Author	SHA1	Message	Date
Stan Hu	f93b2e02a5	Run rubocop -a on CE files	2019-05-05 03:24:28 -07:00
Stan Hu	e6850f73ae	Add Rails 6 deprecation error message	2019-02-05 04:47:40 -08:00
Stan Hu	41b51c0656	Encode Content-Disposition filenames Users downloading non-ASCII attachments would see garbled characters. When used with object storage, AWS S3 would return an InvalidArgument error: Header value cannot be represented using ISO-8859-1. Per RFC 5987 and RFC 6266, Content-Disposition should be encoded properly. This commit takes the Rails 6 implementation of ActiveSuppport::Http::ContentDisposition (https://github.com/rails/rails/pull/33829) and ports it here. Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/47673	2019-02-04 23:12:44 -08:00

Author

SHA1

Message

Date

Stan Hu

f93b2e02a5

Run rubocop -a on CE files

2019-05-05 03:24:28 -07:00

Stan Hu

e6850f73ae

Add Rails 6 deprecation error message

2019-02-05 04:47:40 -08:00

Stan Hu

41b51c0656

Encode Content-Disposition filenames

Users downloading non-ASCII attachments would see garbled characters.
When used with object storage, AWS S3 would return an InvalidArgument
error: Header value cannot be represented using ISO-8859-1.

Per RFC 5987 and RFC 6266, Content-Disposition should be encoded
properly. This commit takes the Rails 6 implementation of
ActiveSuppport::Http::ContentDisposition
(https://github.com/rails/rails/pull/33829) and ports it here.

Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/47673

2019-02-04 23:12:44 -08:00

3 commits