Commit graph

21 commits

Author SHA1 Message Date
gfyoung
7e6f6e1603 Enable even more frozen string in lib/gitlab
Enables frozens string for the following:

* lib/gitlab/conflict/**/*.rb
* lib/gitlab/cross_project_access/**/*.rb
* lib/gitlab/cycle_analytics/**/*.rb
* lib/gitlab/data_builder/**/*.rb
* lib/gitlab/database/**/*.rb
* lib/gitlab/dependency_linker/**/*.rb
* lib/gitlab/diff/**/*.rb
* lib/gitlab/downtime_check/**/*.rb
* lib/gitlab/email/**/*.rb
* lib/gitlab/etag_caching/**/*.rb

Partially addresses gitlab-org/gitlab-ce#47424.
2018-11-06 22:47:32 -08:00
Cameron Crockett
421dbb1746 skip email trim when email is creating new issue
Updates from MR discussion

1. Added test for ReplyParser
2. Changed param to trim_reply with default set as true

Removed keyword param in favor of normal options param

updates for MR discussion

Resolutions for code review comments

more code review fixes
2018-05-22 23:05:51 -05:00
Takuya Noguchi
2b6307f6ad Enable RuboCop Style/RegexpLiteral 2018-02-01 02:06:07 +09:00
Douwe Maan
5c7f9d69e3 Fix code for cops 2017-02-23 09:31:57 -06:00
Douwe Maan
8a4d68c53e Enable Style/ConditionalAssignment 2017-02-23 09:31:57 -06:00
http://jneen.net/
7218daaa96 fix guard style 2016-12-22 00:10:35 -08:00
http://jneen.net/
1b8a576d3f Be more certain in the comment 2016-12-21 09:51:42 -08:00
http://jneen.net/
f02f238d52 Revert "allow empty-quotes"
This reverts commit 4f2f678aff8d7dfcac96c47cf7eb480a5707ddaf.
2016-12-21 09:51:42 -08:00
http://jneen.net/
5603127699 remove comment attribution 2016-12-21 09:51:41 -08:00
http://jneen.net/
602c319862 allow empty-quotes 2016-12-21 09:51:41 -08:00
http://jneen.net/
017579fe14 protect against EmailReplyTrimmer returning nil 2016-12-21 09:51:41 -08:00
http://jneen.net/
03753ff146 remove trailing whitespace from email bodies 2016-12-21 09:51:41 -08:00
http://jneen.net/
a3bb2463c4 switch to email_reply_trimmer from discourse 2016-12-21 09:51:39 -08:00
Rydkin Maxim
170efaaba2 Enable Style/MultilineOperationIndentation in Rubocop, fixes #25741 2016-12-16 21:37:22 +03:00
http://jneen.net/
9df189bb4a fix indentation for rubocop 2016-11-17 11:59:44 +09:00
http://jneen.net/
4aabf707a9 rename part variable and guard against nil content_type 2016-11-17 11:59:44 +09:00
http://jneen.net/
f7b0692912 add parsing support for incoming html email 2016-11-17 11:59:44 +09:00
Gabriel Mazetto
f5a0ac0fc1 Codestyle: make sure we have space around operators 2016-05-13 04:46:56 -03:00
Douwe Maan
15fc7bd613 No HTML-only email please 2015-08-21 16:09:55 -07:00
Douwe Maan
f26c2905d1 Fix indentation 2015-08-20 14:25:56 -07:00
Douwe Maan
e9972efc2f Extract ReplyParser and AttachmentUploader from Receiver. 2015-08-20 11:05:06 -07:00