Commit graph

4 commits

Author SHA1 Message Date
Thong Kuah
4ec16912b8 Autocorrect with RSpec/ExampleWording cop
- rewords examples starting with 'should'
- rewords examples starting with 'it'

Note: I had to manually fixup "onlies" to "only"
2019-04-05 08:43:27 +00:00
Andrew Newdigate
f78cd68ddf Switch back to using regexps in tracing_url_template
This approach is able to cope with `%` characters in the URL template,
which is important since `%` is a valid URL character. Additionally
this approach is less likely to fail on an invalid string. This is
important since the distributed tracing infrastructure is designed to
degrade gracefully when not properly configured, and a small mistake
in the configuration of the URL template could have led to a production
outage.
2019-02-22 14:47:37 +02:00
Andrew Newdigate
24fb8cdae0 Add test for URL encoded characters
Tracing URL templates should be able to include % characters. This test
is intended to show that the current implementation needs rework in
order to handle this requirement.
2019-02-22 14:40:58 +02:00
Andrew Newdigate
48bcd5248f Provide a performance bar link to the Jaeger UI
Jaeger is a distributed tracing tool. This change adds a "Tracing" link
to the performance bar to directly link to a current request in Jaeger.

This is useful for two reasons: 1 - it provides affordance to developers
that the distributed tracing tool is available, so that it can quickly
be discovered. 2 - it allows developers to quickly find a specific trace
without having to manually navigate to a second user-interface.
2019-02-08 14:08:31 +02:00