Commit graph

11 commits

Author SHA1 Message Date
Mike Greiling
23f5865e18 expand remaining non-explicit eslint-disable blocks and factor out globals when no-undef encountered 2016-12-13 21:07:31 -06:00
Fatih Acet
f879319840 Merge branch 'add-todo-toggle-event' into 'master'
Add todo toggle event

## What does this MR do?
Adds a custom jQuery event `todo:toggle` to detect when a new todo is added so that the respective todo counters (header navigation and sidebar) can update as needed

## Are there points in the code the reviewer needs to double check?

*  I wasn't sure whether each `spec` should be modularized based on the html templates or whether they should be separated based on function. There are some crossovers between the `dashboard_spec` and the `header_spec`.
* The naming conventions for `sidebar` and `right_sidebar` were a little confusing since they were named the opposite in their `specs`. I made a few assumptions and named a few files based on what I thought they should be named. I'd be happy to change it to something else though 😄  

## Why was this MR needed?
This resolves an existing issue where the todo count on the sidebar would not update (until refresh) and refactors the existing methods that are used to update the todo counters (header navigation and sidebar)

## What are the relevant issue numbers?
Closes #20140

## Does this MR meet the acceptance criteria?

- [x] [CHANGELOG](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CHANGELOG) entry added
- Tests
  - [x] Added for this feature/bug
  - [x] All builds are passing
- [x] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides)
- [x] Branch has no merge conflicts with `master` (if you do - rebase it please)
- [x] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits)

See merge request !5724
2016-10-27 13:28:40 +00:00
Clement Ho
f610f69ab9 Add todo toggle event 2016-10-26 16:28:56 -05:00
winniehell
02f94cf038 disable ESLint for all JavaScript files 2016-10-26 10:02:58 +02:00
Mike Greiling
f8520f5d09 remove manual Cookie.set "path" option in favor of global setting 2016-10-24 18:09:00 -05:00
Mike Greiling
67d2b2acb3 replace jquery.cookie vendor script with js.cookie 2016-10-24 18:09:00 -05:00
Fatih Acet
729cb3b319 Fixes sidebar navigation. 2016-10-03 12:38:21 +03:00
Luke Howell
cdf44d9fe5 Fix page scrolling to top on sidebar toggle
Added preventDefault for toggling sidebar off as well as for pinning
and unpinning the sidebar.

Closes #22851
2016-10-01 15:25:07 -05:00
Mike Greiling
9b8ee45c87 sync sidebar DOM state on page:change to minimize split-second appearance of the sidebar in certain situations 2016-09-07 14:02:21 -05:00
Mike Greiling
a510fe1102 remove superfluous "collapsed" class and rename header classes for clarity 2016-09-07 14:02:21 -05:00
Mike Greiling
b2f8ebbb42 refactor sidebar logic into singleton class 2016-09-07 14:02:21 -05:00