Commit graph

17 commits

Author SHA1 Message Date
Shinya Maeda
c89e57842e Use shared examples for populate spec 2018-06-01 15:46:15 +09:00
Shinya Maeda
c754b6937c Clean up presence validation spec 2018-06-01 15:37:36 +09:00
Shinya Maeda
1c636b8080 Merge branch 'master' into per-project-pipeline-iid 2018-05-17 15:51:33 +09:00
Jan Provaznik
7da3b2cdd0 Delete remote uploads
ObjectStore uploader requires presence of associated `uploads` record
when deleting the upload file (through the carrierwave's after_commit
hook) because we keep info whether file is LOCAL or REMOTE in `upload`
object.

For this reason we can not destroy uploads as "dependent: :destroy" hook
because these would be deleted too soon. Instead we rely on
carrierwave's hook to destroy `uploads` in after_commit hook.

But in before_destroy hook we still have to delete not-mounted uploads
(which don't use carrierwave's destroy hook). This has to be done in
before_Destroy instead of after_commit because `FileUpload` requires
existence of model's object on destroy action.

This is not ideal state of things, in a next step we should investigate
how to unify model dependencies so we can use same workflow for all
uploads.

Related to #45425
2018-05-16 08:58:07 +02:00
Shinya Maeda
82a49d0fea Clarify scope for AtomicInternalId shared spec 2018-05-14 17:41:56 +09:00
Shinya Maeda
46fa3089c8 Rescue RecordNotUnique when pipeline is created with non-unique iid 2018-05-11 16:49:18 +09:00
Shinya Maeda
910a7d02a8 Remove numericality as it's redandant with integer column and validates nil IID 2018-05-11 15:34:36 +09:00
Shinya Maeda
30a6fb64db Fix atomic internal id spec to allow generate pipeline 2018-05-10 15:56:47 +09:00
Shinya Maeda
04dc80dbb5 Fix spec 2018-05-08 16:01:18 +09:00
Rémy Coutable
8d381b359f
Ensure member notifications are sent after the member actual creation/update in the DB
Signed-off-by: Rémy Coutable <remy@rymai.me>
2018-04-26 08:28:05 +02:00
Andreas Brandl
9ea2fc85a3 Atomic internal ids for all models 2018-04-20 14:00:15 +00:00
Andreas Brandl
fb6d6fce5a Address review comments. 2018-03-16 13:35:27 +01:00
Andreas Brandl
6568b4a98e Add shared specs for AtomicInternalId concern. 2018-03-16 13:35:26 +01:00
Mayra Cabrera
c607008ee5 Extend Cluster Applications to install GitLab Runner to Kubernetes cluster 2018-03-01 23:46:02 +00:00
Rémy Coutable
f070265a6d
Introduce new hook data builders for Issue and MergeRequest
Signed-off-by: Rémy Coutable <remy@rymai.me>
2017-10-09 16:44:47 +02:00
Rémy Coutable
075d651604 Start adding Gitlab::HookData::IssuableBuilder
Signed-off-by: Rémy Coutable <remy@rymai.me>
2017-10-09 15:07:10 +02:00
Rémy Coutable
67d5ca9f92 Include the changes in issuable webhook payloads
Signed-off-by: Rémy Coutable <remy@rymai.me>
2017-10-09 15:07:10 +02:00