Commit graph

8 commits

Author SHA1 Message Date
Alexis Reigel
0fad7aa79c
add tag filter to admin runners page 2019-02-27 20:19:49 +01:00
Stan Hu
ebb284c0dc Remove N+1 query for tags in /admin/runners page
As discussed in https://github.com/mbleigh/acts-as-taggable-on/issues/91,
we can avoid N+1 queries if we use `tags` instead of `tag_list`.

Seen while reviewing
https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/19740.
2019-02-26 12:44:28 -08:00
Alexis Reigel
a1094e2316
add type filter to admin runners page 2018-09-24 16:04:10 +02:00
Yorick Peterse
f0e7b5e7a3
Cleaned up CI runner administration code
In https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/19625 some
changes were introduced that do not meet our abstraction reuse rules.
This commit cleans up some of these changes so the requirements are met.

Most notably, sorting of the runners in Admin::RunnersFinder has been
delegated to Ci::Runner.order_by, similar to how we order data in
models that include the Sortable module. If we need more sort orders in
the future we can include Sortable and have Ci::Runner.order_by call
`super` to delegate to Sortable.order_by.
2018-09-14 15:05:46 +02:00
Alexis Reigel
7d316a9bbb
enable frozen string literal on runners finder 2018-08-29 15:02:54 +02:00
Alexis Reigel
34bdb74740
add sort dropdown to admin runners page 2018-08-29 15:02:54 +02:00
Alexis Reigel
89b30999c2
use filtered search bar for admin runners 2018-08-29 15:02:54 +02:00
Alexis Reigel
0a0350be00
extract filter/sort/paging logic to finder class 2018-08-20 17:15:11 +02:00