Commit graph

20 commits

Author SHA1 Message Date
Stan Hu
e8da70e66c Fix handling of filenames with hash characters in tree view
Addressable::URI interprets the `#` in a URI as a URI fragment
and does not escape it, but Rails has special helpers that treats
these as bona-fide characters that need to be escaped.

Closes https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/23368
2018-11-26 14:14:48 -08:00
Drew Blessing
409f2f4dd2 Improve performance of tree rendering in repositories with lots of items
Rails is slow to generate paths dynamically especially when called
hundreds/thousands of times. Also, rendering many partials hundreds
of times can be slower. This change reduces the number of partials
rendered and introduces two fast path methods to speed up path
generation.
2018-10-31 15:50:30 -05:00
Douwe Maan
097636575c
Fix links to subdirectories of a directory with a plus character in its path 2018-04-04 17:18:52 +02:00
Bob Van Landuyt
e74879280f Allow maintainers to edit directly in a fork 2018-03-07 16:55:34 +01:00
Phil Hughes
9c132216b7
spec fixes 2017-12-14 11:31:50 +00:00
Phil Hughes
e001f4b772
fixed failing tests 2017-12-11 17:52:52 +00:00
Drew Blessing
03b1bcbb68 Truncate tree to max 1,000 items and display notice to users
Rendering ten thousands of tree items consumes a lot of server
time and can cause timeouts in extreme cases. Realistically,
displaying more than 1,000 files is probably not useful so
truncate and show the user a notice instead. 'Find files' can be
used to locate specific files beyond the 1,000 limit.
2017-11-15 08:28:33 -06:00
Alejandro Rodríguez
c2e99b40f7 Implement fix for n+1 issue on flatten_tree helper 2017-09-06 17:47:25 -03:00
Robert Speicher
2fe13fbc4b Use :empty_project where possible in helper specs 2017-01-25 17:10:32 -05:00
tiagonbotelho
519275c110 fixes part1 of files to start using active tense 2016-08-09 15:06:23 +01:00
Robert Speicher
871bb2f143 Fix bad multi-line split from previous commit 2015-06-22 16:06:04 -04:00
Robert Speicher
15a05be70d Fix Style/Blocks cop violations 2015-06-22 16:00:54 -04:00
Douwe Maan
8ed7ac9d44 Use project.commit convenience method. 2015-04-24 12:29:36 +02:00
Jeroen van Baarsen
0c4a70a306 Updated rspec to rspec 3.x syntax
Signed-off-by: Jeroen van Baarsen <jeroenvanbaarsen@gmail.com>
2015-02-12 19:17:35 +01:00
marmis85
02adb9ccd6 point to a specific branch in the test repo to avoid conflicts 2015-01-11 05:07:34 +01:00
marmis85
3efb06a22b Add test spec for TreeHelper module 2015-01-10 21:37:48 +01:00
Robert Schilling
99eb283101 Use readme we support to render if there are multiple readmes 2014-08-11 08:50:56 +02:00
Robert Schilling
ceabda743a Improve markup gems 2014-07-28 11:47:27 +02:00
Nihad Abbasov
a605943d76 fix broken spec 2012-09-20 22:11:15 +06:00
Robert Speicher
52c521ffe8 Use GitHub::Markup to parse markup files
Closes #1382
2012-09-05 16:52:49 -04:00