Commit Graph

12 Commits

Author SHA1 Message Date
Robert Speicher 87d1e865f5
Use have_link over have_content for GPG feature
It's more semantically accurate for what we're verifying.
2018-11-26 09:39:42 -06:00
Robert Speicher ee17268690
Simplify "changes to verified" GPG feature specs
Previously, we wasted time creating a maintainer and signing them in,
then loaded the entire commit list just to verify the GPG status of a
single commit.

Now, we rely on the project being public so no user needs to be
authenticated, and load just the page for the commit we care about.
2018-11-26 09:39:42 -06:00
Robert Speicher 8afd038122
Remove magic SHAs from GPG badge feature spec
We're trying to give the arbitrary SHAs required by each spec a
meaningful name.

This also adds an explicit `ref` definition to each spec so we're not
dealing with a mystery guest.
2018-11-26 09:39:42 -06:00
Robert Speicher 9250de6aba
Speed up "show GPG badge" feature specs
Previously, this group of specs would create a new user, add them as a
maintainer, sign them in, load the project's commit list, click a
specific GPG key badge, and then verify the content in the popover.

Now, we make the project public in order to skip the user setup and
login, and load a specific commit page because it loads faster than the
commit list while still showing the GPG badge.
2018-11-26 09:39:42 -06:00
Winnie Hellmann fed97a68b9 Fix GPG status badge loading regressions 2018-08-07 14:58:53 +02:00
blackst0ne ddd2a25679 Replace 'Sidekiq::Testing.inline!' with 'perform_enqueued_jobs'
`perform_enqueued_jobs` is a Sidekiq method.
Using this method violates the Dependency inversion principle[0].

This commit replaces `perform_enqueued_jobs` with ActiveJob's abstract
method `perform_enqueued_jobs` in specs.

[0]: https://en.wikipedia.org/wiki/Dependency_inversion_principle
2018-07-23 15:34:54 +11:00
Mark Chao a63bce1a4b Resolve "Rename the `Master` role to `Maintainer`" Backend 2018-07-11 14:36:08 +00:00
Lin Jen-Shin 4ee08b77bc Updates from `rubocop -a` 2018-07-09 21:13:08 +08:00
Clement Ho 0da1f82616 Fix signed commits spec 2018-04-23 16:23:18 -05:00
blackst0ne 27c95364b5 Replace '.team << [user, role]' with 'add_role(user)' in specs 2017-12-22 19:18:28 +11:00
Alexis Reigel 936be35b76 update signature badges to reflect new states 2017-09-05 12:18:33 +02:00
Alexis Reigel e7be70a0d3 extract gpg commit specs to their own file 2017-09-05 12:18:32 +02:00