Mark Chao
f4f8270c9f
Allow resolving git submodule url for subgroup projects using relative path
2018-08-20 19:52:53 +08:00
Mario de la Ossa
d7950bbf09
SubmoduleHelper - Project is not always available as an instance variable
2018-07-15 16:06:53 -06:00
Tiago Botelho
0169dd7f6f
Fixes project denial of service via gitmodules using Extended ASCII.
2017-09-15 17:30:55 +01:00
Robert Speicher
72a7b30c9f
Change all `:empty_project` to `:project`
2017-08-02 17:47:31 -04:00
Douwe Maan
78379f66dd
Strip trailing whitespace in relative submodule URL
2017-06-28 14:01:49 -05:00
Dmitriy Zaporozhets
2eec0b73e8
Fix submodule link to then project under subgroup
...
Before this change only last namespace in full path was extracted. It's
fine unless you have a link to submodule under subgroups. In that case
self_url? method returns false and link is processed as external. I
could not find a proper regex to cover all cases and correctly extract
full path to repository and instead used current instance host name
to get correct path to namespace and project.
Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com>
2017-06-05 09:26:20 +03:00
Stan Hu
59b8165c90
Strip trailing whitespaces in submodule URLs
...
Users attempting to access repositories that had `.gitmodules` entries
with trailing whitespaces would encounter an Error 500. This was due
to a change in bf876ec7 that quietly removed the whitespace stripping.
Closes #33018
2017-05-29 06:16:47 -07:00
David Turner
897a85a461
submodule_links: Handle in-repository submodule urls
...
Sometimes it is useful to store submodules in the same repository which
contains links to them. Make the UI support this.
See
https://github.com/twosigma/git-meta/wiki/The-Omega-Repo
for information about this strategy
Signed-off-by: David Turner <novalis@novalis.org>
2017-05-15 16:04:46 -04:00
Douwe Maan
9ae401cf91
Merge branch 'rs-sanitize-submodule-urls' into 'security'
...
Sanitize submodule URLs before linking to them in the file tree view
See merge request !2084
2017-05-10 16:44:20 +02:00
David Turner
040062cc8a
submodule_links: handle urls that don't end with .git
...
Signed-off-by: David Turner <novalis@novalis.org>
2017-04-21 10:54:31 -04:00
Douwe Maan
c10064aad5
Enable Style/SpaceInsideBrackets
2017-02-23 09:31:56 -06:00
Robert Speicher
2fe13fbc4b
Use `:empty_project` where possible in helper specs
2017-01-25 17:10:32 -05:00
tiagonbotelho
519275c110
fixes part1 of files to start using active tense
2016-08-09 15:06:23 +01:00
Stan Hu
774b7ee277
Fix Error 500 when relative submodule resolves to a namespace that has a different name from its path
...
Closes #1849
2015-06-23 05:49:19 -07:00
Robert Speicher
5a9ede4721
Update mock and stub syntax for specs
2015-06-22 12:13:46 +02:00
Stan Hu
9a2e3d3d81
Fix broken file browsing with relative submodule in personal projects
...
Closes https://github.com/gitlabhq/gitlabhq/issues/7554
2015-04-23 07:42:28 -07:00
Stan Hu
7d089701f1
Fix broken file browsing with a submodule that has a relative link
...
Closes #775
2015-04-09 22:10:59 -07:00
Vinnie Okada
76aad9b76e
Upgrade to Rails 4.1.9
...
Make the following changes to deal with new behavior in Rails 4.1.2:
* Use nested resources to avoid slashes in arguments to path helpers.
2015-02-14 11:09:23 -07:00
Jeroen van Baarsen
0c4a70a306
Updated rspec to rspec 3.x syntax
...
Signed-off-by: Jeroen van Baarsen <jeroenvanbaarsen@gmail.com>
2015-02-12 19:17:35 +01:00
Marin Jankovski
1dca950c28
Fix failing submodule test.
2014-06-03 11:37:23 +02:00
Dmitriy Zaporozhets
bed05a1381
Fix submodule_helper specs
...
Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com>
2014-02-10 13:02:26 +02:00
Jason Hollingsworth
fcc906e6aa
Better submodule links.
...
Detect if submodule is hosted on this GitLab server, gitlab.com or github.com.
Hash links directly to commit in repo.
2014-02-05 20:44:14 -06:00