kotovalexarian-likes-gitlab/gitlab-org--gitlab-foss

Fork 0

Commit graph

Author	SHA1	Message	Date
Sean McGivern	1ab33b15d1	Add cop for use of remove_column remove_column should only be used in the up (or change) step of a migration if it's a post-deployment migration. Otherwise there will be downtime due to the ActiveRecord column cache, which we can avoid by using the IgnorableColumn concern in combination with a post-deployment migration.	2017-12-11 16:34:51 +00:00
Rémy Coutable	187e6c8d7c	New Migration/UpdateColumnInBatches cop Signed-off-by: Rémy Coutable <remy@rymai.me>	2017-05-29 11:28:23 +02:00
Yorick Peterse	c740445ad3	Added RuboCop cops for checking DB migrations There are currently two cops for this: * Migration/AddIndex: checks if indexes are added concurrently * Migration/ColumnWithDefault: checks if columns with default values are added in a concurrent manner Both cops are fairly simple and make no attempt at correcting the code as this is quite hard to do (e.g. modifications may need to be applied in various places in the same file). They however should provide enough to catch people ignoring the comments in generated migrations telling them to use add_concurrent_index or add_column_with_default.	2016-06-29 14:14:02 +02:00

Author

SHA1

Message

Date

Sean McGivern

1ab33b15d1

Add cop for use of remove_column

remove_column should only be used in the up (or change) step of a migration if
it's a post-deployment migration. Otherwise there will be downtime due to the
ActiveRecord column cache, which we can avoid by using the IgnorableColumn
concern in combination with a post-deployment migration.

2017-12-11 16:34:51 +00:00

Rémy Coutable

187e6c8d7c

New Migration/UpdateColumnInBatches cop

Signed-off-by: Rémy Coutable <remy@rymai.me>

2017-05-29 11:28:23 +02:00

Yorick Peterse

c740445ad3

Added RuboCop cops for checking DB migrations

There are currently two cops for this:

* Migration/AddIndex: checks if indexes are added concurrently
* Migration/ColumnWithDefault: checks if columns with default values are
  added in a concurrent manner

Both cops are fairly simple and make no attempt at correcting the code
as this is quite hard to do (e.g. modifications may need to be applied
in various places in the same file). They however should provide enough
to catch people ignoring the comments in generated migrations telling
them to use add_concurrent_index or add_column_with_default.

2016-06-29 14:14:02 +02:00

3 commits