kotovalexarian-likes-gitlab/gitlab-org--gitlab-foss
1
0
Fork 0
Code Releases Activity
86256 commits 1 branch 0 tags 899 MiB
Commit graph

23 commits

Author SHA1 Message Date
gfyoung
73322a0e55 Enable frozen string in app/controllers/**/*.rb 
Enables frozen string for the following:

* app/controllers/*.rb
* app/controllers/admin/**/*.rb
* app/controllers/boards/**/*.rb
* app/controllers/ci/**/*.rb
* app/controllers/concerns/**/*.rb

Partially addresses #47424.
 2018-09-18 21:22:45 -07:00
Yorick Peterse
2039c8280d
Disable existing offenses for the CodeReuse cops 
This whitelists all existing offenses for the various CodeReuse cops, of
which most are triggered by the CodeReuse/ActiveRecord cop.
 2018-09-11 17:32:00 +02:00
Bob Van Landuyt
f1d3ea63cf Show the status of a user in interactions 
The status is shown for
- The author of a commit when viewing a commit
- Notes on a commit (regular/diff)
- The user that triggered a pipeline when viewing a pipeline
- The author of a merge request when viewing a merge request
- The author of notes on a merge request (regular/diff)
- The author of an issue when viewing an issue
- The author of notes on an issue
- The author of a snippet when viewing a snippet
- The author of notes on a snippet
- A user's profile page
- The list of members of a group/user
 2018-07-30 15:01:26 +02:00
Rémy Coutable
1c88d92b3f Improve Member services 
Signed-off-by: Rémy Coutable <remy@rymai.me>
 2018-02-27 16:02:22 +01:00
Rémy Coutable
e82f629be4 Move the #update action from Project/Member controllers to the MembershipActions concern 
Signed-off-by: Rémy Coutable <remy@rymai.me>
 2018-02-27 16:02:22 +01:00
Rémy Coutable
bf41063679 Remove explicit audit event log in MembershipActions 
Move it to Members::ApproveAccessRequestService.

Also, note that there was a double audit event log for access request
destruction.

Signed-off-by: Rémy Coutable <remy@rymai.me>
 2018-02-27 16:02:22 +01:00
Tim Zallmann
64e589c581 Resolve "Inconsistent location of members page between groups and projects" 2017-07-07 14:40:41 +00:00
Grzegorz Bizon
0430b76441 Enable Style/DotPosition Rubocop 👮 2017-06-21 13:48:12 +00:00
Alfredo Sumaran
3ec37e2622 Merge branch 'master' into 25426-group-dashboard-ui 2017-06-07 14:45:57 -05:00
Nick Thomas
5c602e306c Limit non-administrators to adding 100 members at a time to groups and projects 2017-06-06 16:04:26 +01:00
Alfredo Sumaran
d8403ec18f Minor visual adjustments 2017-06-06 09:01:42 -05:00
Dmitriy Zaporozhets
657bc805a4
Add json support to group members leave action in controller 
Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com>
 2017-06-06 13:35:22 +03:00
Dmitriy Zaporozhets
395fca1493
Refactor members controller destroy action 
Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com>
 2017-04-17 17:44:30 +03:00
Dmitriy Zaporozhets
7de75920f7
Refactor controller code that creates project/group members 
Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com>
 2017-04-17 14:45:14 +03:00
Rémy Coutable
c8b1311934 Fix a few things after the initial improvment to Members::DestroyService 
Signed-off-by: Rémy Coutable <remy@rymai.me>
 2016-10-03 16:57:48 +02:00
Rémy Coutable
3158f57dba Improve Members::DestroyService 
Signed-off-by: Rémy Coutable <remy@rymai.me>
 2016-10-03 16:57:48 +02:00
Rémy Coutable
5dcdf1d51b Ensure Members::ApproveAccessRequestService can fin a requester by ID 
Signed-off-by: Rémy Coutable <remy@rymai.me>
 2016-09-22 15:50:48 +02:00
Rémy Coutable
b3f0a82f50 New Members::ApproveAccessRequestService 
Signed-off-by: Rémy Coutable <remy@rymai.me>
 2016-09-22 15:50:47 +02:00
Rémy Coutable
bd78f5733c Exclude requesters from Project#members, Group#members and User#members 
And create new Project#requesters, Group#requesters scopes.

Signed-off-by: Rémy Coutable <remy@rymai.me>
 2016-07-01 17:44:46 +02:00
Rémy Coutable
654565c9dc Raise a new Gitlab::Access::AccessDeniedError when permission is not enough to destroy a member 
This is a try for a new approach to put the access checks at the service level.

Signed-off-by: Rémy Coutable <remy@rymai.me>
 2016-06-18 06:06:34 +02:00
Rémy Coutable
724f986fb2 Redirect to the member's source on request withdrawal 
Signed-off-by: Rémy Coutable <remy@rymai.me>
 2016-06-18 05:46:45 +02:00
Rémy Coutable
4652489f40 New Members::DestroyService 
This is to ensure we don't send unwanted notifications when deleting a
project. In other words, stop abusing AR callbacks and use services.

Signed-off-by: Rémy Coutable <remy@rymai.me>
 2016-06-18 05:46:45 +02:00
Rémy Coutable
515205d3c1 UI and copywriting improvements 
+ Move 'Edit Project/Group' out of membership-related partial
+ Show the access request buttons only to logged-in users
+ Put the request access buttons out of in a more visible button
+ Improve the copy in the #remove_member_message helper

Signed-off-by: Rémy Coutable <remy@rymai.me>
 2016-06-14 13:18:14 +02:00