kotovalexarian-likes-gitlab/gitlab-org--gitlab-foss
1
0
Fork 0
Code Releases Activity
81035 commits 1 branch 0 tags 899 MiB
Commit graph

17 commits

Author SHA1 Message Date
Jarka Kadlecová
501fb04ec6 Delete todos when users loses target read permissions 2018-07-30 13:29:18 +02:00
gfyoung
fbde835404 Enable more frozen string in app/services/**/*.rb 
Partially addresses #47424.
 2018-07-17 15:19:40 -07:00
Douwe Maan
74a24a4fab Don't delete todos or unassign issues and MRs when a user leaves a project 2018-03-07 17:18:01 -06:00
Rémy Coutable
1c88d92b3f Improve Member services 
Signed-off-by: Rémy Coutable <remy@rymai.me>
 2018-02-27 16:02:22 +01:00
Rémy Coutable
bf41063679 Remove explicit audit event log in MembershipActions 
Move it to Members::ApproveAccessRequestService.

Also, note that there was a double audit event log for access request
destruction.

Signed-off-by: Rémy Coutable <remy@rymai.me>
 2018-02-27 16:02:22 +01:00
TM Lee
2cf3fc18a6 Refactor member view by using presenter 
- Create MemberPresenter alongside with GroupMemberPresenter and ProjectMemberPresenter
- Make Member model Presentable
- Move action_member_permission from MembersHelper into the MemberPresenter
- Added rspec using double, separate specs for GroupMemberPresenter and ProjectMemberPresenter

Fixes #28004.

Signed-off-by: Rémy Coutable <remy@rymai.me>
 2017-12-11 18:30:56 +01:00
Robert Speicher
260c8da060 Whitelist or fix additional Gitlab/PublicSend cop violations 
An upcoming update to rubocop-gitlab-security added additional
violations.
 2017-08-14 12:14:11 -04:00
Douwe Maan
b7d8df503c Enable Style/MutableConstant 2017-02-23 09:31:56 -06:00
Rémy Coutable
e9d7b4f765 Invert method's naming 
Signed-off-by: Rémy Coutable <remy@rymai.me>
 2016-10-03 16:57:48 +02:00
Rémy Coutable
c8b1311934 Fix a few things after the initial improvment to Members::DestroyService 
Signed-off-by: Rémy Coutable <remy@rymai.me>
 2016-10-03 16:57:48 +02:00
Rémy Coutable
3158f57dba Improve Members::DestroyService 
Signed-off-by: Rémy Coutable <remy@rymai.me>
 2016-10-03 16:57:48 +02:00
Sean McGivern
8b1656282b Merge branch 'master' into expiration-date-on-memberships 2016-08-18 15:54:07 +01:00
Rémy Coutable
29850364ec New AccessRequests API endpoints for Group & Project 
Also, mutualize AccessRequests and Members endpoints for Group &
Project.
New API documentation for the AccessRequests endpoints.

Signed-off-by: Rémy Coutable <remy@rymai.me>
 2016-08-10 19:07:05 +02:00
Adam Niedzielski
b4b51441aa Extract Members::AuthorizedDestroyService from Members::DestroyService. 2016-08-04 23:34:57 +02:00
Rémy Coutable
654565c9dc Raise a new Gitlab::Access::AccessDeniedError when permission is not enough to destroy a member 
This is a try for a new approach to put the access checks at the service level.

Signed-off-by: Rémy Coutable <remy@rymai.me>
 2016-06-18 06:06:34 +02:00
Rémy Coutable
a08a26ac81 Don't send the "access declined" email on access request withdrawal 
Signed-off-by: Rémy Coutable <remy@rymai.me>
 2016-06-18 05:46:45 +02:00
Rémy Coutable
4652489f40 New Members::DestroyService 
This is to ensure we don't send unwanted notifications when deleting a
project. In other words, stop abusing AR callbacks and use services.

Signed-off-by: Rémy Coutable <remy@rymai.me>
 2016-06-18 05:46:45 +02:00