Commit graph

11 commits

Author SHA1 Message Date
Toon Claes
34a5f77e77 Document database review process
See https://gitlab.com/gitlab-com/gl-infra/infrastructure/issues/6069
2019-07-19 17:33:48 +00:00
Toon Claes
37e4d6d991 DRY up conditions for files require DB review
Stop using two separate lists for the conditions which files require a
database review.

Related discussion:
https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/30156#note_187732053
2019-07-04 18:47:16 +00:00
Yorick Peterse
8469f59d78
Backport the EE schema and migrations to CE
This backports all EE schema changes to CE, including EE migrations,
ensuring both use the same schema.

== Updated tests

A spec related to ghost and support bot users had to be modified to make
it pass. The spec in question assumes that the "support_bot" column
exists when defining the spec. In the single codebase setup this is not
the case, as the column is backported in a later migration. Any attempt
to use a different schema version or use of "around" blocks to
conditionally disable specs won't help, as reverting the backport
migration would also drop the "support_bot" column. Removing the
"support_bot" tests entirely appears to be the only solution.

We also need to update some foreign key tests now that we have
backported the EE columns. Fortunately, these changes are very minor.

== Backporting migrations

This commit moves EE specific migrations (except those for the Geo
tracking database) and related files to CE, and also removes any traces
of the ee/db directory.

Some migrations had to be modified or removed, as they no longer work
with the schema being backported. These migrations were all quite old,
so we opted for removing them where modifying them would take too much
time and effort.

Some old migrations were modified in EE, while also existing in CE. In
these cases we took the EE code, and in one case removed them entirely.
It's not worth spending time trying to merge these changes somehow as we
plan to remove old migrations around the release of 12.0, see
https://gitlab.com/gitlab-org/gitlab-ce/issues/59177 for more details.
2019-06-17 17:09:05 +02:00
Lukas Eipert
253e1818aa
Create helper to get all changed files
Danger apparently has three different objects which could contain files
you often want to check:

 - git.added_files
 - git.modified_files
 - git.renamed_files

The problem: If a file is renamed, `modified_files` contains the file
path before the rename. In some Danger checks we use `added_files` +
`modified_files`, which might contain the deleted paths of renamed
files, but missing the new paths of renamed files.

So we need to consider `renamed_files` as well.
2018-10-22 11:04:55 +02:00
Thong Kuah
8f4745deb4 Fix regexp for detected db/schema.rb and ee/db/geo/schema.rb 2018-07-26 10:31:45 +12:00
Robert Speicher
27843cd2e7
Autocorrect RuboCop violations in danger/**/Dangerfile 2018-07-11 14:44:35 -05:00
Rémy Coutable
545c961dbc
Wrap DB paths in backticks in the Danger check
Signed-off-by: Rémy Coutable <remy@rymai.me>
2018-07-11 19:12:44 +02:00
Yorick Peterse
b851fe8635
Fix "Database Team" typo for Danger 2018-07-11 14:51:48 +02:00
Yorick Peterse
ced15dd531
Tweak the Danger settings for DB changes
Instead of only checking for migrations, we now check for a variety of
files and directories that require a database review. We also include
some steps on how to make sure changes are reviewed.
2018-07-11 14:48:31 +02:00
Rémy Coutable
ab87e7bab1
Improve Danger files after first review
Signed-off-by: Rémy Coutable <remy@rymai.me>
2018-07-11 11:52:03 +02:00
Rémy Coutable
5679837cd4
Start to use Danger for automating MR reviews
Signed-off-by: Rémy Coutable <remy@rymai.me>
2018-07-11 11:52:01 +02:00