3 commits

Author	SHA1	Message	Date
Rémy Coutable	2b8eb7273e	Ensure ApplicationSetting#performance_bar_allowed_group_id is properly set when retrieved from cache ... Signed-off-by: Rémy Coutable <remy@rymai.me>	2018-05-29 10:38:59 +02:00
Rémy Coutable	4af9d592c5	Replace factory_girl_rails with factory_bot_rails ... I've followed the [upgrade guide](https://github.com/thoughtbot/factory_bot/blob/4-9-0-stable/UPGRADE_FROM_FACTORY_GIRL.md) and ran these two commands: ``` grep -e FactoryGirl **/*.rake **/*.rb -s -l | xargs sed -i "" "s|FactoryGirl|FactoryBot|" grep -e factory_girl **/*.rake **/*.rb -s -l | xargs sed -i "" "s|factory_girl|factory_bot|" ``` Signed-off-by: Rémy Coutable <remy@rymai.me>	2017-12-14 15:01:55 +01:00
Stan Hu	575dced5d7	If migrations are pending, make CurrentSettings use existing values and populate missing columns with defaults ... master was failing because `ApplicationSetting.create_from_defaults` attempted to write to a column that did not exist in the database. This occurred in a `rake db:migrate` task, which was unable to perform the migration that would have added the missing column in the first place. In 9.3 RC2, we also had a bug where password sign-ins were disabled because there were many pending migrations. The problem occurred because `fake_application_settings` was being returned with an OpenStruct that did not include the predicate method `signup_enabled?`. As a result, the value would erroneously return `nil` instead of `true`. This commit uses the values of the defaults to mimic this behavior. This commit also refactors some of the logic to be clearer.	2017-06-19 09:54:48 -07:00