Commit Graph

24 Commits

Author SHA1 Message Date
yukihir0 b8bd7ef809 Fix types comment 2018-11-15 19:15:03 +09:00
Mike Greiling dfb0824346 Prettify all the things (part 7) 2018-10-24 19:17:03 +00:00
Jacob Schatz 35c8fd5586 Update to jQuery 3. 2018-02-20 22:20:48 +00:00
Filipa Lacerda cf347a5739
Remove Diff class from globalnamespace 2017-10-19 10:57:25 +01:00
Phil Hughes fe24c0a875
Fixes commit comments in side-by-side diff view
This was caused by the `notes` global class not existing when the
`file_comment_button` code is run. The notes class was used to check
if the diff is currently in parallel view or not. To get around this
I've added a check into the `file_comment_button` JS to check if the
view is currently parallel or not.

Closes #38117
2017-09-27 15:38:13 +01:00
Bryce Johnson 81e9c28425 Render add-diff-note button with server.
This commit moves the rendering of the button back to the server, and
shows/hides it using opacity rather than display. It also removes the
transform applied to the button on hover (scale). Previously, both of these
factors automatically triggered a reflow, which creates a performance
bottleneck on pages with larger DOM size.

MR: !12103
2017-06-29 12:50:45 -04:00
Mike Greiling 306be281cc remove bind polyfill from files_comment_button.js 2017-05-08 17:39:51 -05:00
Douwe Maan bb8cc94668
Don't use original_discussion_id 2017-04-05 17:44:14 +01:00
Douwe Maan 1571835248
Fix merge conflict issue 2017-04-05 17:44:14 +01:00
Douwe Maan 08bbb9fce6
Add option to start a new discussion on an MR 2017-04-05 17:44:14 +01:00
Mike Greiling 8796d17a26 remove IIFEs in preparation for ES module refactor 2017-03-13 14:41:32 -05:00
Phil Hughes 1466b7eecc Added discussion comments avatars to diff 2017-03-08 16:07:26 +00:00
Phil Hughes f5b59dcf36 Grow the button on hover 2017-02-27 10:08:02 +00:00
Phil Hughes cc41ec9795 Improved the diff comment button UX
It now shows the line will be commenting on my highlight the line number cells with a lighter color. The button has also been made smaller, it was previously way over the top & took over a lot more space than it should of done

Closes #27543
2017-02-27 10:08:02 +00:00
Mike Greiling 0f31c5a92b replace implicit this == window with explicit binding 2017-02-17 16:58:32 -06:00
Mike Greiling 04eff5fdb0 resolve all x-spacing and no-spaced-x eslint violations 2017-01-18 17:18:40 -06:00
Mike Greiling ccada28f30 resolve all padded-blocks eslint violations 2017-01-18 17:16:41 -06:00
Mike Greiling 8e0e902b13 resolve all instances of no-undef eslint rule violations 2016-12-14 02:11:13 -06:00
Luke "Jared" Bennett 7cefaea876
explicitly disable eslint inline 2016-11-15 16:30:34 +00:00
winniehell 02f94cf038 disable ESLint for all JavaScript files 2016-10-26 10:02:58 +02:00
Luke Bennett a60c1fc4f8
Added unfold test to parallel and added 'diff discussion' context 2016-08-23 20:45:29 +01:00
Luke Bennett 7d654c0e18
Added addtional 'renderable' validator to check 'data-note-type' attr exists 2016-08-23 15:13:01 +01:00
Douwe Maan 94f22826f3 Don't show comment button in gutter of diffs on MR discussion tab 2016-07-25 22:03:07 -06:00
Fatih Acet aaa9509d12 ES6ify all the things! 2016-07-24 23:45:11 +03:00