Commit graph

22 commits

Author SHA1 Message Date
Maxim Rydkin
ac3e5a5854 replace is_project_milestone? with project_milestone? 2017-08-29 11:14:41 +03:00
Paul Charlton
65eca13f7b Repair Regression caused by - !11573
some changes introduced by 4daa6da540, 26b6e299e1, 17898ce021 were regressed during today's merge conflict resolution of !11573.

This commit serves to reapply those changes.

/cc: @rspeicher @stanhu @mikegreiling
2017-07-11 14:23:51 +08:00
Paul Charlton
cb3b4a15e6 Support multiple Redis instances based on queue type 2017-07-11 03:35:47 +00:00
Felipe Artur
0f7cb96783 Fix milestones destroy service 2017-07-10 14:59:34 -03:00
Felipe Artur
b5f596c3ff Native group milestones 2017-07-07 15:08:49 +00:00
Mark Fletcher
58d02520b0 Ensure validation messages are shown within the milestone form
* Remove call to Milestone#save! instead just Milestone#save
* Add safety specs to stop a regression

Fixes #22033
2016-09-19 09:29:12 +01:00
Grzegorz Bizon
9e211091a8 Enable Style/EmptyLines cop, remove redundant ones 2016-07-01 21:56:17 +02:00
Felipe Artur
0bef4b9764 Implement review suggestions 2016-04-07 10:59:24 -03:00
Dmitriy Zaporozhets
98d6d491b5
Move global milestone specs
Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com>
2015-11-16 14:38:34 +01:00
Dmitriy Zaporozhets
986695e136 Refactor global and group milestones logic
Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com>
2015-11-16 14:07:38 +01:00
Stan Hu
ea5c25bb4e Remove milestones from merge requests when milestones are deleted
Reported by https://github.com/gitlabhq/gitlabhq/issues/9643
2015-09-21 07:00:55 -07:00
Stan Hu
d3d03d1362 Create a "destroyed Milestone" event and keep Milestone events around in the DB
for posterity.

Also fix issue where destroying a Milestone would cause odd, transient messages like
"created milestone" or "imported milestone".

Add "in" preposition when creating and destroying milestones

Closes #2382
2015-09-15 05:51:11 -07:00
Dmitriy Zaporozhets
8fb76a8308 Merge branch 'group_milestones' into 'master'
Group milestones
2014-07-01 07:18:15 +00:00
Marin Jankovski
fdbf77ef99 Fix styling issues. 2014-06-30 13:27:17 +02:00
Marin Jankovski
c223fb1a96 Start building group milestone show page. 2014-06-30 09:45:16 +02:00
Marin Jankovski
b6425f33bc Get one group milestone based on milestone title. 2014-06-30 09:44:30 +02:00
Marin Jankovski
0723bf1afa Move group milestone processing from service to model. 2014-06-30 09:44:30 +02:00
Marin Jankovski
8e8c074205 Reuse existing milestones counting. 2014-06-30 09:44:30 +02:00
Marin Jankovski
58570880f0 Create group milestones service. 2014-06-30 09:44:30 +02:00
Dmitriy Zaporozhets
8fee5a0572
Make app works with strong params
Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com>
2014-06-26 23:24:17 +03:00
Dmitriy Zaporozhets
d65bf4605e
Fix milestone reopen
Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com>
2014-06-10 19:22:39 +03:00
Dmitriy Zaporozhets
c4b02642d2
Replace milestone observer with services
Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com>
2014-06-10 18:07:52 +03:00