# frozen_string_literal: true require 'spec_helper' RSpec.describe 'Value Stream Analytics', :js do include CycleAnalyticsHelpers let_it_be(:user) { create(:user) } let_it_be(:guest) { create(:user) } let_it_be(:stage_table_selector) { '[data-testid="vsa-stage-table"]' } let_it_be(:stage_filter_bar) { '[data-testid="vsa-filter-bar"]' } let_it_be(:stage_table_event_selector) { '[data-testid="vsa-stage-event"]' } let_it_be(:stage_table_event_title_selector) { '[data-testid="vsa-stage-event-title"]' } let_it_be(:stage_table_pagination_selector) { '[data-testid="vsa-stage-pagination"]' } let_it_be(:stage_table_duration_column_header_selector) { '[data-testid="vsa-stage-header-duration"]' } let_it_be(:metrics_selector) { "[data-testid='vsa-metrics']" } let_it_be(:metric_value_selector) { "[data-testid='displayValue']" } let(:stage_table) { find(stage_table_selector) } let(:project) { create(:project, :repository) } let(:issue) { create(:issue, project: project, created_at: 2.days.ago) } let(:milestone) { create(:milestone, project: project) } let(:mr) { create_merge_request_closing_issue(user, project, issue, commit_message: "References #{issue.to_reference}") } let(:pipeline) { create(:ci_empty_pipeline, status: 'created', project: project, ref: mr.source_branch, sha: mr.source_branch_sha, head_pipeline_of: mr) } def metrics_values page.find(metrics_selector).all(metric_value_selector).collect(&:text) end def set_daterange(from_date, to_date) page.find(".js-daterange-picker-from input").set(from_date) page.find(".js-daterange-picker-to input").set(to_date) # simulate a blur event page.find(".js-daterange-picker-to input").send_keys(:tab) wait_for_all_requests end context 'as an allowed user' do context 'when project is new' do before do project.add_maintainer(user) sign_in(user) visit project_cycle_analytics_path(project) wait_for_requests end it 'displays metrics with relevant values' do expect(metrics_values).to eq(['-'] * 4) end it 'shows active stage with empty message' do expect(page).to have_selector('.gl-path-active-item-indigo', text: 'Issue') expect(page).to have_content("We don't have enough data to show this stage.") end end context "when there's value stream analytics data", :sidekiq_inline do # NOTE: in https://gitlab.com/gitlab-org/gitlab/-/merge_requests/68595 travel back # 5 days in time before we create data for these specs, to mitigate some flakiness # So setting the date range to be the last 2 days should skip past the existing data from = 2.days.ago.strftime("%Y-%m-%d") to = 1.day.ago.strftime("%Y-%m-%d") max_items_per_page = 20 around do |example| travel_to(5.days.ago) { example.run } end before do project.add_maintainer(user) create_cycle(user, project, issue, mr, milestone, pipeline) create_list(:issue, max_items_per_page, project: project, created_at: 2.weeks.ago, milestone: milestone) deploy_master(user, project) issue.metrics.update!(first_mentioned_in_commit_at: issue.metrics.first_associated_with_milestone_at + 1.hour) merge_request = issue.merge_requests_closing_issues.first.merge_request merge_request.update!(created_at: issue.metrics.first_associated_with_milestone_at + 1.hour) merge_request.metrics.update!( latest_build_started_at: merge_request.created_at + 3.hours, latest_build_finished_at: merge_request.created_at + 4.hours, merged_at: merge_request.created_at + 4.hours, first_deployed_to_production_at: merge_request.created_at + 5.hours ) sign_in(user) visit project_cycle_analytics_path(project) wait_for_requests end let(:stage_table_events) { stage_table.all(stage_table_event_selector) } it 'displays metrics' do metrics_tiles = page.find(metrics_selector) aggregate_failures 'with relevant values' do expect(metrics_tiles).to have_content('Commit') expect(metrics_tiles).to have_content('Deploy') expect(metrics_tiles).to have_content('Deployment Frequency') expect(metrics_tiles).to have_content('New Issue') end end it 'shows data on each stage', quarantine: 'https://gitlab.com/gitlab-org/gitlab/-/issues/338332' do expect_issue_to_be_present click_stage('Plan') expect_issue_to_be_present click_stage('Code') expect_merge_request_to_be_present click_stage('Test') expect_merge_request_to_be_present click_stage('Review') expect_merge_request_to_be_present click_stage('Staging') expect_merge_request_to_be_present end it 'can filter the issues by date' do expect(page).to have_selector(stage_table_event_selector) set_daterange(from, to) expect(page).not_to have_selector(stage_table_event_selector) expect(page).not_to have_selector(stage_table_pagination_selector) end it 'can filter the metrics by date' do expect(metrics_values).to match_array(%w[21 2 1 0]) set_daterange(from, to) expect(metrics_values).to eq(['-'] * 4) end it 'can sort records', quarantine: 'https://gitlab.com/gitlab-org/gitlab/-/issues/338332' do # NOTE: checking that the string changes should suffice # depending on the order the tests are run we might run into problems with hard coded strings original_first_title = first_stage_title stage_time_column.click expect_to_be_sorted "descending" expect(first_stage_title).not_to have_text(original_first_title, exact: true) stage_time_column.click expect_to_be_sorted "ascending" expect(first_stage_title).to have_text(original_first_title, exact: true) end it 'paginates the results' do original_first_title = first_stage_title expect(page).to have_selector(stage_table_pagination_selector) go_to_next_page expect(page).not_to have_text(original_first_title, exact: true) end it 'can navigate directly to a value stream stream stage with filters applied' do visit project_cycle_analytics_path(project, created_before: '2019-12-31', created_after: '2019-11-01', stage_id: 'code', milestone_title: milestone.title) wait_for_requests expect(page).to have_selector('.gl-path-active-item-indigo', text: 'Code') expect(page.find(".js-daterange-picker-from input").value).to eq("2019-11-01") expect(page.find(".js-daterange-picker-to input").value).to eq("2019-12-31") filter_bar = page.find(stage_filter_bar) expect(filter_bar.find(".gl-filtered-search-token-data-content").text).to eq("%#{milestone.title}") end def stage_time_column stage_table.find(stage_table_duration_column_header_selector).ancestor("th") end def first_stage_title stage_table.all(stage_table_event_title_selector).first.text end def expect_to_be_sorted(direction) expect(stage_time_column['aria-sort']).to eq(direction) end def go_to_next_page page.find(stage_table_pagination_selector).find_link("Next").click end end end context "as a guest" do before do project.add_developer(user) project.add_guest(guest) create_cycle(user, project, issue, mr, milestone, pipeline) deploy_master(user, project) sign_in(guest) visit project_cycle_analytics_path(project) wait_for_requests end it 'does not show the commit stats', :sidekiq_inline do expect(page.find(metrics_selector)).not_to have_selector("#commits") end it 'does not show restricted stages', :aggregate_failures, :sidekiq_inline do expect(find(stage_table_selector)).to have_content(issue.title) expect(page).to have_selector('.gl-path-nav-list-item', text: 'Issue') expect(page).to have_selector('.gl-path-nav-list-item', text: 'Plan') expect(page).to have_selector('.gl-path-nav-list-item', text: 'Test') expect(page).to have_selector('.gl-path-nav-list-item', text: 'Staging') expect(page).not_to have_selector('.gl-path-nav-list-item', text: 'Code') expect(page).not_to have_selector('.gl-path-nav-list-item', text: 'Review') end end def expect_issue_to_be_present expect(find(stage_table_selector)).to have_content(issue.title) expect(find(stage_table_selector)).to have_content(issue.author.name) expect(find(stage_table_selector)).to have_content("##{issue.iid}") end def expect_merge_request_to_be_present expect(find(stage_table_selector)).to have_content(mr.title) expect(find(stage_table_selector)).to have_content(mr.author.name) expect(find(stage_table_selector)).to have_content("!#{mr.iid}") end def click_stage(stage_name) find('.gl-path-nav-list-item', text: stage_name).click wait_for_requests end end