require 'rails_helper' describe GroupsController do let(:user) { create(:user) } let(:group) { create(:group, :public) } let(:project) { create(:empty_project, namespace: group) } let!(:group_member) { create(:group_member, group: group, user: user) } describe 'GET #index' do context 'as a user' do it 'redirects to Groups Dashboard' do sign_in(user) get :index expect(response).to redirect_to(dashboard_groups_path) end end context 'as a guest' do it 'redirects to Explore Groups' do get :index expect(response).to redirect_to(explore_groups_path) end end end describe 'GET #subgroups', :nested_groups do let!(:public_subgroup) { create(:group, :public, parent: group) } let!(:private_subgroup) { create(:group, :private, parent: group) } context 'as a user' do before do sign_in(user) end it 'shows all subgroups' do get :subgroups, id: group.to_param expect(assigns(:nested_groups)).to contain_exactly(public_subgroup, private_subgroup) end context 'being member of private subgroup' do it 'shows public and private subgroups the user is member of' do group_member.destroy! private_subgroup.add_guest(user) get :subgroups, id: group.to_param expect(assigns(:nested_groups)).to contain_exactly(public_subgroup, private_subgroup) end end end context 'as a guest' do it 'shows the public subgroups' do get :subgroups, id: group.to_param expect(assigns(:nested_groups)).to contain_exactly(public_subgroup) end end end describe 'GET #issues' do let(:issue_1) { create(:issue, project: project) } let(:issue_2) { create(:issue, project: project) } before do create_list(:award_emoji, 3, awardable: issue_2) create_list(:award_emoji, 2, awardable: issue_1) create_list(:award_emoji, 2, :downvote, awardable: issue_2) sign_in(user) end context 'sorting by votes' do it 'sorts most popular issues' do get :issues, id: group.to_param, sort: 'upvotes_desc' expect(assigns(:issues)).to eq [issue_2, issue_1] end it 'sorts least popular issues' do get :issues, id: group.to_param, sort: 'downvotes_desc' expect(assigns(:issues)).to eq [issue_2, issue_1] end end end describe 'GET #merge_requests' do let(:merge_request_1) { create(:merge_request, source_project: project) } let(:merge_request_2) { create(:merge_request, :simple, source_project: project) } before do create_list(:award_emoji, 3, awardable: merge_request_2) create_list(:award_emoji, 2, awardable: merge_request_1) create_list(:award_emoji, 2, :downvote, awardable: merge_request_2) sign_in(user) end context 'sorting by votes' do it 'sorts most popular merge requests' do get :merge_requests, id: group.to_param, sort: 'upvotes_desc' expect(assigns(:merge_requests)).to eq [merge_request_2, merge_request_1] end it 'sorts least popular merge requests' do get :merge_requests, id: group.to_param, sort: 'downvotes_desc' expect(assigns(:merge_requests)).to eq [merge_request_2, merge_request_1] end end end describe 'DELETE #destroy' do context 'as another user' do it 'returns 404' do sign_in(create(:user)) delete :destroy, id: group.to_param expect(response.status).to eq(404) end end context 'as the group owner' do before do sign_in(user) end it 'schedules a group destroy' do Sidekiq::Testing.fake! do expect { delete :destroy, id: group.to_param }.to change(GroupDestroyWorker.jobs, :size).by(1) end end it 'redirects to the root path' do delete :destroy, id: group.to_param expect(response).to redirect_to(root_path) end end end describe 'PUT update' do before do sign_in(user) end it 'updates the path successfully' do post :update, id: group.to_param, group: { path: 'new_path' } expect(response).to have_http_status(302) expect(controller).to set_flash[:notice] end it 'does not update the path on error' do allow_any_instance_of(Group).to receive(:move_dir).and_raise(Gitlab::UpdatePathError) post :update, id: group.to_param, group: { path: 'new_path' } expect(assigns(:group).errors).not_to be_empty expect(assigns(:group).path).not_to eq('new_path') end end describe '#ensure_canonical_path' do before do sign_in(user) end context 'for a GET request' do context 'when requesting groups at the root path' do before do allow(request).to receive(:original_fullpath).and_return("/#{group_full_path}") get :show, id: group_full_path end context 'when requesting the canonical path with different casing' do let(:group_full_path) { group.to_param.upcase } it 'redirects to the correct casing' do expect(response).to redirect_to(group) expect(controller).not_to set_flash[:notice] end end context 'when requesting a redirected path' do let(:redirect_route) { group.redirect_routes.create(path: 'old-path') } let(:group_full_path) { redirect_route.path } it 'redirects to the canonical path' do expect(response).to redirect_to(group) expect(controller).to set_flash[:notice].to(group_moved_message(redirect_route, group)) end context 'when the old group path is a substring of the scheme or host' do let(:redirect_route) { group.redirect_routes.create(path: 'http') } it 'does not modify the requested host' do expect(response).to redirect_to(group) expect(controller).to set_flash[:notice].to(group_moved_message(redirect_route, group)) end end context 'when the old group path is substring of groups' do # I.e. /groups/oups should not become /grfoo/oups let(:redirect_route) { group.redirect_routes.create(path: 'oups') } it 'does not modify the /groups part of the path' do expect(response).to redirect_to(group) expect(controller).to set_flash[:notice].to(group_moved_message(redirect_route, group)) end end end end context 'when requesting groups under the /groups path' do context 'when requesting the canonical path' do context 'non-show path' do context 'with exactly matching casing' do it 'does not redirect' do get :issues, id: group.to_param expect(response).not_to have_http_status(301) end end context 'with different casing' do it 'redirects to the correct casing' do get :issues, id: group.to_param.upcase expect(response).to redirect_to(issues_group_path(group.to_param)) expect(controller).not_to set_flash[:notice] end end end context 'show path' do context 'with exactly matching casing' do it 'does not redirect' do get :show, id: group.to_param expect(response).not_to have_http_status(301) end end context 'with different casing' do it 'redirects to the correct casing at the root path' do get :show, id: group.to_param.upcase expect(response).to redirect_to(group) expect(controller).not_to set_flash[:notice] end end end end context 'when requesting a redirected path' do let(:redirect_route) { group.redirect_routes.create(path: 'old-path') } it 'redirects to the canonical path' do get :issues, id: redirect_route.path expect(response).to redirect_to(issues_group_path(group.to_param)) expect(controller).to set_flash[:notice].to(group_moved_message(redirect_route, group)) end context 'when the old group path is a substring of the scheme or host' do let(:redirect_route) { group.redirect_routes.create(path: 'http') } it 'does not modify the requested host' do get :issues, id: redirect_route.path expect(response).to redirect_to(issues_group_path(group.to_param)) expect(controller).to set_flash[:notice].to(group_moved_message(redirect_route, group)) end end context 'when the old group path is substring of groups' do # I.e. /groups/oups should not become /grfoo/oups let(:redirect_route) { group.redirect_routes.create(path: 'oups') } it 'does not modify the /groups part of the path' do get :issues, id: redirect_route.path expect(response).to redirect_to(issues_group_path(group.to_param)) expect(controller).to set_flash[:notice].to(group_moved_message(redirect_route, group)) end end context 'when the old group path is substring of groups plus the new path' do # I.e. /groups/oups/oup should not become /grfoos let(:redirect_route) { group.redirect_routes.create(path: 'oups/oup') } it 'does not modify the /groups part of the path' do get :issues, id: redirect_route.path expect(response).to redirect_to(issues_group_path(group.to_param)) expect(controller).to set_flash[:notice].to(group_moved_message(redirect_route, group)) end end end end end context 'for a POST request' do context 'when requesting the canonical path with different casing' do it 'does not 404' do post :update, id: group.to_param.upcase, group: { path: 'new_path' } expect(response).not_to have_http_status(404) end it 'does not redirect to the correct casing' do post :update, id: group.to_param.upcase, group: { path: 'new_path' } expect(response).not_to have_http_status(301) end end context 'when requesting a redirected path' do let(:redirect_route) { group.redirect_routes.create(path: 'old-path') } it 'returns not found' do post :update, id: redirect_route.path, group: { path: 'new_path' } expect(response).to have_http_status(404) end end end context 'for a DELETE request' do context 'when requesting the canonical path with different casing' do it 'does not 404' do delete :destroy, id: group.to_param.upcase expect(response).not_to have_http_status(404) end it 'does not redirect to the correct casing' do delete :destroy, id: group.to_param.upcase expect(response).not_to have_http_status(301) end end context 'when requesting a redirected path' do let(:redirect_route) { group.redirect_routes.create(path: 'old-path') } it 'returns not found' do delete :destroy, id: redirect_route.path expect(response).to have_http_status(404) end end end end def group_moved_message(redirect_route, group) "Group '#{redirect_route.path}' was moved to '#{group.full_path}'. Please update any links and bookmarks that may still have the old path." end end