# frozen_string_literal: true require 'spec_helper' RSpec.describe SearchHelper do include MarkupHelper include BadgesHelper # Override simple_sanitize for our testing purposes def simple_sanitize(str) str end describe 'search_autocomplete_opts' do context "with no current user" do before do allow(self).to receive(:current_user).and_return(nil) end it "returns nil" do expect(search_autocomplete_opts("q")).to be_nil end end context "with a standard user" do let(:user) { create(:user) } before do allow(self).to receive(:current_user).and_return(user) end it "includes Help sections" do expect(search_autocomplete_opts("hel").size).to eq(8) end it "includes default sections" do expect(search_autocomplete_opts("dash").size).to eq(1) end it "does not include admin sections" do expect(search_autocomplete_opts("admin").size).to eq(0) end it "does not allow regular expression in search term" do expect(search_autocomplete_opts("(webhooks|api)").size).to eq(0) end it "includes the user's groups" do create(:group).add_owner(user) expect(search_autocomplete_opts("gro").size).to eq(1) end it "includes nested group" do create(:group, :nested, name: 'foo').add_owner(user) expect(search_autocomplete_opts('foo').size).to eq(1) end it "includes the user's projects" do project = create(:project, namespace: create(:namespace, owner: user)) expect(search_autocomplete_opts(project.name).size).to eq(1) end it "includes the required project attrs" do project = create(:project, namespace: create(:namespace, owner: user)) result = search_autocomplete_opts(project.name).first expect(result.keys).to match_array(%i[category id value label url avatar_url]) end it "includes the required group attrs" do create(:group).add_owner(user) result = search_autocomplete_opts("gro").first expect(result.keys).to match_array(%i[category id label url avatar_url]) end it 'includes the users recently viewed issues', :aggregate_failures do recent_issues = instance_double(::Gitlab::Search::RecentIssues) expect(::Gitlab::Search::RecentIssues).to receive(:new).with(user: user).and_return(recent_issues) project1 = create(:project, :with_avatar, namespace: user.namespace) project2 = create(:project, namespace: user.namespace) issue1 = create(:issue, title: 'issue 1', project: project1) issue2 = create(:issue, title: 'issue 2', project: project2) expect(recent_issues).to receive(:search).with('the search term').and_return(Issue.id_in_ordered([issue1.id, issue2.id])) results = search_autocomplete_opts("the search term") expect(results.count).to eq(2) expect(results[0]).to include({ category: 'Recent issues', id: issue1.id, label: 'issue 1', url: Gitlab::Routing.url_helpers.project_issue_path(issue1.project, issue1), avatar_url: project1.avatar_url }) expect(results[1]).to include({ category: 'Recent issues', id: issue2.id, label: 'issue 2', url: Gitlab::Routing.url_helpers.project_issue_path(issue2.project, issue2), avatar_url: '' # This project didn't have an avatar so set this to '' }) end it 'includes the users recently viewed issues with the exact same name', :aggregate_failures do recent_issues = instance_double(::Gitlab::Search::RecentIssues) expect(::Gitlab::Search::RecentIssues).to receive(:new).with(user: user).and_return(recent_issues) project1 = create(:project, namespace: user.namespace) project2 = create(:project, namespace: user.namespace) issue1 = create(:issue, title: 'issue same_name', project: project1) issue2 = create(:issue, title: 'issue same_name', project: project2) expect(recent_issues).to receive(:search).with('the search term').and_return(Issue.id_in_ordered([issue1.id, issue2.id])) results = search_autocomplete_opts("the search term") expect(results.count).to eq(2) expect(results[0]).to include({ category: 'Recent issues', id: issue1.id, label: 'issue same_name', url: Gitlab::Routing.url_helpers.project_issue_path(issue1.project, issue1), avatar_url: '' # This project didn't have an avatar so set this to '' }) expect(results[1]).to include({ category: 'Recent issues', id: issue2.id, label: 'issue same_name', url: Gitlab::Routing.url_helpers.project_issue_path(issue2.project, issue2), avatar_url: '' # This project didn't have an avatar so set this to '' }) end it 'includes the users recently viewed merge requests', :aggregate_failures do recent_merge_requests = instance_double(::Gitlab::Search::RecentMergeRequests) expect(::Gitlab::Search::RecentMergeRequests).to receive(:new).with(user: user).and_return(recent_merge_requests) project1 = create(:project, :with_avatar, namespace: user.namespace) project2 = create(:project, namespace: user.namespace) merge_request1 = create(:merge_request, :unique_branches, title: 'Merge request 1', target_project: project1, source_project: project1) merge_request2 = create(:merge_request, :unique_branches, title: 'Merge request 2', target_project: project2, source_project: project2) expect(recent_merge_requests).to receive(:search).with('the search term').and_return(MergeRequest.id_in_ordered([merge_request1.id, merge_request2.id])) results = search_autocomplete_opts("the search term") expect(results.count).to eq(2) expect(results[0]).to include({ category: 'Recent merge requests', id: merge_request1.id, label: 'Merge request 1', url: Gitlab::Routing.url_helpers.project_merge_request_path(merge_request1.project, merge_request1), avatar_url: project1.avatar_url }) expect(results[1]).to include({ category: 'Recent merge requests', id: merge_request2.id, label: 'Merge request 2', url: Gitlab::Routing.url_helpers.project_merge_request_path(merge_request2.project, merge_request2), avatar_url: '' # This project didn't have an avatar so set this to '' }) end it "does not include the public group" do group = create(:group) expect(search_autocomplete_opts(group.name).size).to eq(0) end context "with a current project" do before do @project = create(:project, :repository) allow(self).to receive(:can?).and_return(true) allow(self).to receive(:can?).with(user, :read_feature_flag, @project).and_return(false) end it 'returns repository related labels based on users abilities', :aggregate_failures do expect(search_autocomplete_opts("Files").size).to eq(1) expect(search_autocomplete_opts("Commits").size).to eq(1) expect(search_autocomplete_opts("Network").size).to eq(1) expect(search_autocomplete_opts("Graph").size).to eq(1) allow(self).to receive(:can?).with(user, :download_code, @project).and_return(false) expect(search_autocomplete_opts("Files").size).to eq(0) expect(search_autocomplete_opts("Commits").size).to eq(0) allow(self).to receive(:can?).with(user, :read_repository_graphs, @project).and_return(false) expect(search_autocomplete_opts("Network").size).to eq(0) expect(search_autocomplete_opts("Graph").size).to eq(0) end context 'when user does not have access to project' do it 'does not include issues by iid' do issue = create(:issue, project: @project) results = search_autocomplete_opts("\##{issue.iid}") expect(results.count).to eq(0) end end context 'when user has project access' do before do @project = create(:project, :repository, namespace: user.namespace) allow(self).to receive(:can?).with(user, :read_feature_flag, @project).and_return(true) end it 'includes issues by iid', :aggregate_failures do issue = create(:issue, project: @project, title: 'test title') results = search_autocomplete_opts("\##{issue.iid}") expect(results.count).to eq(1) expect(results.first).to include({ category: 'In this project', id: issue.id, label: 'test title (#1)', url: ::Gitlab::Routing.url_helpers.project_issue_path(issue.project, issue), avatar_url: '' # project has no avatar }) end end end end context 'with an admin user' do let(:admin) { create(:admin) } before do allow(self).to receive(:current_user).and_return(admin) end it "includes admin sections" do expect(search_autocomplete_opts("admin").size).to eq(1) end end end describe 'search_entries_info' do using RSpec::Parameterized::TableSyntax where(:scope, :label) do 'blobs' | 'code result' 'commits' | 'commit' 'issues' | 'issue' 'merge_requests' | 'merge request' 'milestones' | 'milestone' 'notes' | 'comment' 'projects' | 'project' 'snippet_titles' | 'snippet' 'users' | 'user' 'wiki_blobs' | 'wiki result' end with_them do it 'uses the correct singular label' do collection = Kaminari.paginate_array([:foo]).page(1).per(10) expect(search_entries_info(collection, scope, 'foo')).to eq("Showing 1 #{label} for  foo ") end it 'uses the correct plural label' do collection = Kaminari.paginate_array([:foo] * 23).page(1).per(10) expect(search_entries_info(collection, scope, 'foo')).to eq("Showing 1 - 10 of 23 #{label.pluralize} for  foo ") end end it 'raises an error for unrecognized scopes' do expect do collection = Kaminari.paginate_array([:foo]).page(1).per(10) search_entries_info(collection, 'unknown', 'foo') end.to raise_error(RuntimeError) end end describe 'search_entries_empty_message' do let!(:group) { build(:group) } let!(:project) { build(:project, group: group) } context 'global search' do let(:message) { search_entries_empty_message('projects', '

foo

', nil, nil) } it 'returns the formatted entry message' do expect(message).to eq("We couldn't find any projects matching <h1>foo</h1>") expect(message).to be_html_safe end end context 'group search' do let(:message) { search_entries_empty_message('projects', '

foo

', group, nil) } it 'returns the formatted entry message' do expect(message).to start_with('We couldn't find any projects matching <h1>foo</h1> in group foo', group, project) } it 'returns the formatted entry message' do expect(message).to start_with('We couldn't find any projects matching <h1>foo</h1> in project test' 'this test should not be blue' | 'this test should not be blue' 'Click Me test' | 'Click Me test' ' test' | ' test' 'Lorem test ipsum dolor sit amet, consectetuer adipiscing elit. Aenean commodo ligula eget dolor. Aenean massa. Cum sociis natoque penatibus et magnis dis parturient montes, nascetur ridiculus mus. Donec quam felis, ultricies nec, pellentesque eu, pretium quis, sem. Nulla consequat massa quis enim. Donec.' | 'Lorem test ipsum dolor sit amet, consectetuer adipiscing elit. Aenean commodo ligula eget dolor. Aenean massa. Cum sociis natoque penatibus et magnis dis parturient montes, nascetur ridiculus mus. Don...' 'some image' | 'some image' end with_them do it 'sanitizes, truncates, and highlights the search term' do expect(subject).to eq(expected) end end end end describe '#search_service' do using RSpec::Parameterized::TableSyntax subject { search_service } before do allow(self).to receive(:current_user).and_return(:the_current_user) end where(:confidential, :expected) do '0' | false '1' | true 'yes' | true 'no' | false true | true false | false end let(:params) {{ confidential: confidential }} with_them do it 'transforms confidentiality param' do expect(::SearchService).to receive(:new).with(:the_current_user, { confidential: expected }) subject end end end describe '#issuable_state_to_badge_class' do context 'with merge request' do it 'returns correct badge based on status' do expect(issuable_state_to_badge_class(build(:merge_request, :merged))).to eq(:info) expect(issuable_state_to_badge_class(build(:merge_request, :closed))).to eq(:danger) expect(issuable_state_to_badge_class(build(:merge_request, :opened))).to eq(:success) end end context 'with an issue' do it 'returns correct badge based on status' do expect(issuable_state_to_badge_class(build(:issue, :closed))).to eq(:info) expect(issuable_state_to_badge_class(build(:issue, :opened))).to eq(:success) end end end describe '#issuable_state_text' do context 'with merge request' do it 'returns correct badge based on status' do expect(issuable_state_text(build(:merge_request, :merged))).to eq(_('Merged')) expect(issuable_state_text(build(:merge_request, :closed))).to eq(_('Closed')) expect(issuable_state_text(build(:merge_request, :opened))).to eq(_('Open')) end end context 'with an issue' do it 'returns correct badge based on status' do expect(issuable_state_text(build(:issue, :closed))).to eq(_('Closed')) expect(issuable_state_text(build(:issue, :opened))).to eq(_('Open')) end end end describe '#search_sort_options' do let(:user) { create(:user) } mock_created_sort = [ { title: _('Created date'), sortable: true, sortParam: { asc: 'created_asc', desc: 'created_desc' } }, { title: _('Updated date'), sortable: true, sortParam: { asc: 'updated_asc', desc: 'updated_desc' } } ] before do allow(self).to receive(:current_user).and_return(user) end it 'returns the correct data' do expect(search_sort_options).to eq(mock_created_sort) end end describe '#header_search_context' do let(:user) { create(:user) } let(:can_download) { false } let(:for_group) { false } let(:group) { nil } let(:group_metadata) { nil } let(:for_project) { false } let(:project) { nil } let(:project_metadata) { nil } let(:scope) { nil } let(:code_search) { false } let(:ref) { nil } let(:for_snippets) { false } let(:search_context) do instance_double(Gitlab::SearchContext, group: group, group_metadata: group_metadata, project: project, project_metadata: project_metadata, scope: scope, ref: ref) end before do allow(self).to receive(:search_context).and_return(search_context) allow(self).to receive(:current_user).and_return(user) allow(self).to receive(:can?).and_return(can_download) allow(search_context).to receive(:for_group?).and_return(for_group) allow(search_context).to receive(:for_project?).and_return(for_project) allow(search_context).to receive(:code_search?).and_return(code_search) allow(search_context).to receive(:for_snippets?).and_return(for_snippets) end context 'group data' do let(:group) { create(:group) } let(:group_metadata) { { group_path: group.path, issues_path: "/issues" } } let(:scope) { 'issues' } let(:code_search) { true } context 'when for_group? is true' do let(:for_group) { true } it 'adds the :group and :group_metadata correctly to hash' do expect(header_search_context[:group]).to eq({ id: group.id, name: group.name }) expect(header_search_context[:group_metadata]).to eq(group_metadata) end it 'adds scope and code_search? correctly to hash' do expect(header_search_context[:scope]).to eq(scope) expect(header_search_context[:code_search]).to eq(code_search) end end context 'when for_group? is false' do let(:for_group) { false } it 'does not add the :group and :group_metadata to hash' do expect(header_search_context[:group]).to eq(nil) expect(header_search_context[:group_metadata]).to eq(nil) end it 'does not add scope and code_search? to hash' do expect(header_search_context[:scope]).to eq(nil) expect(header_search_context[:code_search]).to eq(nil) end end end context 'project data' do let(:project) { create(:project) } let(:project_metadata) { { project_path: project.path, issues_path: "/issues" } } let(:scope) { 'issues' } let(:code_search) { true } context 'when for_project? is true' do let(:for_project) { true } it 'adds the :project and :project_metadata correctly to hash' do expect(header_search_context[:project]).to eq({ id: project.id, name: project.name }) expect(header_search_context[:project_metadata]).to eq(project_metadata) end it 'adds scope and code_search? correctly to hash' do expect(header_search_context[:scope]).to eq(scope) expect(header_search_context[:code_search]).to eq(code_search) end end context 'when for_project? is false' do let(:for_project) { false } it 'does not add the :project and :project_metadata to hash' do expect(header_search_context[:project]).to eq(nil) expect(header_search_context[:project_metadata]).to eq(nil) end it 'does not add scope and code_search? to hash' do expect(header_search_context[:scope]).to eq(nil) expect(header_search_context[:code_search]).to eq(nil) end end end context 'ref data' do let(:ref) { 'test-branch' } context 'when user can? download project data' do let(:can_download) { true } it 'adds the :ref correctly to hash' do expect(header_search_context[:ref]).to eq(ref) end end context 'when user cannot download project data' do let(:can_download) { false } it 'does not add the :ref to hash' do expect(header_search_context[:ref]).to eq(nil) end end end context 'snippets' do context 'when for_snippets? is true' do let(:for_snippets) { true } it 'adds :for_snippets correctly to hash' do expect(header_search_context[:for_snippets]).to eq(for_snippets) end end context 'when for_snippets? is false' do let(:for_snippets) { false } it 'adds :for_snippets correctly to hash' do expect(header_search_context[:for_snippets]).to eq(for_snippets) end end end end end