require 'spec_helper' describe GitlabMarkdownHelper do include ApplicationHelper include IssuesHelper # TODO: Properly test this def can?(*) true end let!(:project) { create(:project) } let(:empty_project) { create(:empty_project) } let(:user) { create(:user, username: 'gfm') } let(:commit) { project.repository.commit } let(:earlier_commit){ project.repository.commit("HEAD~2") } let(:issue) { create(:issue, project: project) } let(:merge_request) { create(:merge_request, source_project: project, target_project: project) } let(:snippet) { create(:project_snippet, project: project) } let(:member) { project.project_members.where(user_id: user).first } # Helper expects a current_user method. let(:current_user) { user } def url_helper(image_name) File.join(root_url, 'assets', image_name) end before do # Helper expects a @project instance variable @project = project @ref = 'markdown' @repository = project.repository @request.host = Gitlab.config.gitlab.host end describe "#gfm" do it "should return unaltered text if project is nil" do skip "rspeicher - This isn't actually checked in this method anymore." actual = "Testing references: ##{issue.iid}" expect(gfm(actual)).not_to eq(actual) @project = nil expect(gfm(actual)).to eq(actual) end it "should not alter non-references" do skip "rspeicher - Invalid test: markdown has already been parsed by the time gfm gets it" actual = expected = "_Please_ *stop* 'helping' and all the other b*$#%' you do." expect(gfm(actual)).to eq(expected) end it "should not touch HTML entities" do skip "rspeicher - Invalid test: Sanitize (or Nokogiri?) translates the HTML entity back" allow(@project).to receive(:issue_exists?). with(39).and_return([issue]) actual = 'We'll accept good pull requests.' expect(gfm(actual)).to eq("We'll accept good pull requests.") end it "should forward HTML options to links" do expect(gfm("Fixed in #{commit.id}", @project, class: 'foo')). to have_selector('a.gfm.foo') end describe "referencing multiple objects" do let(:actual) { "!#{merge_request.iid} -> #{commit.id} -> ##{issue.iid}" } it "should link to the merge request" do expected = namespace_project_merge_request_path(project.namespace, project, merge_request) expect(gfm(actual)).to match(expected) end it "should link to the commit" do expected = namespace_project_commit_path(project.namespace, project, commit) expect(gfm(actual)).to match(expected) end it "should link to the issue" do expected = namespace_project_issue_path(project.namespace, project, issue) expect(gfm(actual)).to match(expected) end end # TODO (rspeicher): These tests belong in the emoji filter spec describe "emoji" do it "matches at the start of a string" do expect(gfm(":+1:")).to match(/ big time/) end it "ignores invalid emoji" do expect(gfm(":invalid-emoji:")).not_to match(/") # Leading commit link expect(groups[0]).to match(/href="#{commit_path}"/) expect(groups[0]).to match(/This should finally fix $/) # First issue link expect(groups[1]). to match(/href="#{namespace_project_issue_path(project.namespace, project, issues[0])}"/) expect(groups[1]).to match(/##{issues[0].iid}$/) # Internal commit link expect(groups[2]).to match(/href="#{commit_path}"/) expect(groups[2]).to match(/ and /) # Second issue link expect(groups[3]). to match(/href="#{namespace_project_issue_path(project.namespace, project, issues[1])}"/) expect(groups[3]).to match(/##{issues[1].iid}$/) # Trailing commit link expect(groups[4]).to match(/href="#{commit_path}"/) expect(groups[4]).to match(/ for real$/) end it "should forward HTML options" do actual = link_to_gfm("Fixed in #{commit.id}", commit_path, class: 'foo') expect(actual).to have_selector 'a.gfm.gfm-commit.foo' end it "escapes HTML passed in as the body" do actual = "This is a

test

- see ##{issues[0].iid}" expect(link_to_gfm(actual, commit_path)). to match('<h1>test</h1>') end end describe "#markdown" do # TODO (rspeicher) - This block tests multiple different contexts. Break this up! it "should handle references in paragraphs" do skip "rspeicher - redundant" actual = "\n\nLorem ipsum dolor sit amet. #{commit.id} Nam pulvinar sapien eget.\n" expected = namespace_project_commit_path(project.namespace, project, commit) expect(markdown(actual)).to match(expected) end # REFERENCES (PART TWO: THE REVENGE) --------------------------------------- it "should handle references in headers" do actual = "\n# Working around ##{issue.iid}\n## Apply !#{merge_request.iid}" expect(markdown(actual, no_header_anchors: true)). to match(%r{Working around ##{issue.iid}}) expect(markdown(actual, no_header_anchors: true)). to match(%r{Apply !#{merge_request.iid}}) end it "should add ids and links to headers" do # Test every rule except nested tags. text = '..Ab_c-d. e..' id = 'ab_c-d-e' expect(markdown("# #{text}")). to match(%r{

#{text}

}) expect(markdown("# #{text}", {no_header_anchors:true})). to eq("

#{text}

") id = 'link-text' expect(markdown("# [link text](url) ![img alt](url)")).to match( %r{

link text ]*>

} ) end it "should handle references in lists" do skip "rspeicher - redundant" project.team << [user, :master] actual = "\n* dark: ##{issue.iid}\n* light by @#{member.user.username}" expect(markdown(actual)). to match(%r{
  • dark: ##{issue.iid}
  • }) expect(markdown(actual)). to match(%r{
  • light by @#{member.user.username}
  • }) end it "should not link the apostrophe to issue 39" do skip "rspeicher - Redundant" project.team << [user, :master] allow(project.issues). to receive(:where).with(iid: '39').and_return([issue]) actual = "Yes, it is @#{member.user.username}'s task." expected = /Yes, it is @#{member.user.username}<\/a>'s task/ expect(markdown(actual)).to match(expected) end it "should not link the apostrophe to issue 39 in code blocks" do skip "rspeicher - Redundant" project.team << [user, :master] allow(project.issues). to receive(:where).with(iid: '39').and_return([issue]) actual = "Yes, `it is @#{member.user.username}'s task.`" expected = /Yes, it is @gfm\'s task.<\/code>/ expect(markdown(actual)).to match(expected) end it "should handle references in " do actual = "Apply _!#{merge_request.iid}_ ASAP" expect(markdown(actual)). to match(%r{Apply !#{merge_request.iid}}) end it "should handle tables" do skip "rspeicher - Aren't we just testing Redcarpet here?" actual = %Q{| header 1 | header 2 | | -------- | -------- | | cell 1 | cell 2 | | cell 3 | cell 4 |} expect(markdown(actual)).to match(/\Asome code from $#{snippet.id}\nhere too\n\n" expect(helper.markdown("\n some code from $#{snippet.id}\n here too\n")). to eq(target_html) expect(helper.markdown("\n```\nsome code from $#{snippet.id}\nhere too\n```\n")). to eq(target_html) end it "should leave inline code untouched" do expect(markdown("\nDon't use `$#{snippet.id}` here.\n")).to eq( "

    Don't use $#{snippet.id} here.

    \n" ) end # REF-LIKE AUTOLINKS? ----------------------------------------------------- # Basically: Don't parse references inside `` tags. it "should leave ref-like autolinks untouched" do expect(markdown("look at http://example.tld/#!#{merge_request.iid}")).to eq("

    look at http://example.tld/#!#{merge_request.iid}

    \n") end it "should leave ref-like href of 'manual' links untouched" do expect(markdown("why not [inspect !#{merge_request.iid}](http://example.tld/#!#{merge_request.iid})")).to eq("

    why not inspect !#{merge_request.iid}

    \n") end it "should leave ref-like src of images untouched" do expect(markdown("screen shot: ![some image](http://example.tld/#!#{merge_request.iid})")).to eq("

    screen shot: \"some

    \n") end it "should generate absolute urls for refs" do expect(markdown("##{issue.iid}")).to include(namespace_project_issue_path(project.namespace, project, issue)) end # EMOJI ------------------------------------------------------------------- it "should generate absolute urls for emoji" do # TODO (rspeicher): Why isn't this with the emoji tests? expect(markdown(':smile:')).to( include(%(src="#{Gitlab.config.gitlab.url}/assets/emoji/#{Emoji.emoji_filename('smile')}.png)) ) end it "should generate absolute urls for emoji if relative url is present" do # TODO (rspeicher): Why isn't this with the emoji tests? allow(Gitlab.config.gitlab).to receive(:url).and_return('http://localhost/gitlab/root') expect(markdown(":smile:")).to include("src=\"http://localhost/gitlab/root/assets/emoji/#{Emoji.emoji_filename('smile')}.png") end it "should generate absolute urls for emoji if asset_host is present" do # TODO (rspeicher): Why isn't this with the emoji tests? allow(Gitlab::Application.config).to receive(:asset_host).and_return("https://cdn.example.com") ActionView::Base.any_instance.stub_chain(:config, :asset_host).and_return("https://cdn.example.com") expect(markdown(":smile:")).to include("src=\"https://cdn.example.com/assets/emoji/#{Emoji.emoji_filename('smile')}.png") end # RELATIVE URLS ----------------------------------------------------------- # TODO (rspeicher): These belong in a relative link filter spec it "should handle relative urls for a file in master" do actual = "[GitLab API doc](doc/api/README.md)\n" expected = "

    GitLab API doc

    \n" expect(markdown(actual)).to match(expected) end it "should handle relative urls for a file in master with an anchor" do actual = "[GitLab API doc](doc/api/README.md#section)\n" expected = "

    GitLab API doc

    \n" expect(markdown(actual)).to match(expected) end it "should not handle relative urls for the current file with an anchor" do actual = "[GitLab API doc](#section)\n" expected = "

    GitLab API doc

    \n" expect(markdown(actual)).to match(expected) end it "should handle relative urls for a directory in master" do actual = "[GitLab API doc](doc/api)\n" expected = "

    GitLab API doc

    \n" expect(markdown(actual)).to match(expected) end it "should handle absolute urls" do actual = "[GitLab](https://www.gitlab.com)\n" expected = "

    GitLab

    \n" expect(markdown(actual)).to match(expected) end it "should handle relative urls in reference links for a file in master" do actual = "[GitLab API doc][GitLab readme]\n [GitLab readme]: doc/api/README.md\n" expected = "

    GitLab API doc

    \n" expect(markdown(actual)).to match(expected) end it "should handle relative urls in reference links for a directory in master" do actual = "[GitLab API doc directory][GitLab readmes]\n [GitLab readmes]: doc/api/\n" expected = "

    GitLab API doc directory

    \n" expect(markdown(actual)).to match(expected) end it "should not handle malformed relative urls in reference links for a file in master" do actual = "[GitLab readme]: doc/api/README.md\n" expected = "" expect(markdown(actual)).to match(expected) end it 'should allow whitelisted HTML tags from the user' do actual = '
    Term
    Definition
    ' expect(markdown(actual)).to match(actual) end # SANITIZATION ------------------------------------------------------------ it 'should sanitize tags that are not whitelisted' do actual = 'no blinks' expected = 'no inputs allowed no blinks' expect(markdown(actual)).to match(expected) expect(markdown(actual)).not_to match('<.textarea>') expect(markdown(actual)).not_to match('<.blink>') end it 'should allow whitelisted tag attributes from the user' do actual = 'link text' expect(markdown(actual)).to match(actual) end it 'should sanitize tag attributes that are not whitelisted' do actual = 'link text' expected = 'link text' expect(markdown(actual)).to match(expected) end it 'should sanitize javascript in attributes' do actual = %q(link text) expected = 'link text' expect(markdown(actual)).to match(expected) end end # TODO (rspeicher): This should be a context of relative link specs, not its own thing describe 'markdown for empty repository' do before do @project = empty_project @repository = empty_project.repository end it "should not touch relative urls" do actual = "[GitLab API doc][GitLab readme]\n [GitLab readme]: doc/api/README.md\n" expected = "

    GitLab API doc

    \n" expect(markdown(actual)).to match(expected) end end describe "#render_wiki_content" do before do @wiki = double('WikiPage') allow(@wiki).to receive(:content).and_return('wiki content') end it "should use GitLab Flavored Markdown for markdown files" do allow(@wiki).to receive(:format).and_return(:markdown) expect(helper).to receive(:markdown).with('wiki content') helper.render_wiki_content(@wiki) end it "should use the Gollum renderer for all other file types" do allow(@wiki).to receive(:format).and_return(:rdoc) formatted_content_stub = double('formatted_content') expect(formatted_content_stub).to receive(:html_safe) allow(@wiki).to receive(:formatted_content).and_return(formatted_content_stub) helper.render_wiki_content(@wiki) end end describe '#gfm_with_tasks' do before(:all) do @source_text_asterisk = <