352 lines
10 KiB
Ruby
352 lines
10 KiB
Ruby
# frozen_string_literal: true
|
|
|
|
require 'spec_helper'
|
|
|
|
RSpec.describe ServicePing::SubmitService do
|
|
include StubRequests
|
|
include UsageDataHelpers
|
|
|
|
let(:usage_data_id) { 31643 }
|
|
let(:score_params) do
|
|
{
|
|
score: {
|
|
leader_issues: 10.2,
|
|
instance_issues: 3.2,
|
|
percentage_issues: 31.37,
|
|
|
|
leader_notes: 25.3,
|
|
instance_notes: 23.2,
|
|
|
|
leader_milestones: 16.2,
|
|
instance_milestones: 5.5,
|
|
|
|
leader_boards: 5.2,
|
|
instance_boards: 3.2,
|
|
|
|
leader_merge_requests: 5.2,
|
|
instance_merge_requests: 3.2,
|
|
|
|
leader_ci_pipelines: 25.1,
|
|
instance_ci_pipelines: 21.3,
|
|
|
|
leader_environments: 3.3,
|
|
instance_environments: 2.2,
|
|
|
|
leader_deployments: 41.3,
|
|
instance_deployments: 15.2,
|
|
|
|
leader_projects_prometheus_active: 0.31,
|
|
instance_projects_prometheus_active: 0.30,
|
|
|
|
leader_service_desk_issues: 15.8,
|
|
instance_service_desk_issues: 15.1,
|
|
|
|
usage_data_id: usage_data_id,
|
|
|
|
non_existing_column: 'value'
|
|
}
|
|
}
|
|
end
|
|
|
|
let(:with_dev_ops_score_params) { { dev_ops_score: score_params[:score] } }
|
|
let(:with_conv_index_params) { { conv_index: score_params[:score] } }
|
|
let(:with_usage_data_id_params) { { conv_index: { usage_data_id: usage_data_id } } }
|
|
let(:service_ping_payload_url) { File.join(described_class::STAGING_BASE_URL, described_class::USAGE_DATA_PATH) }
|
|
let(:service_ping_errors_url) { File.join(described_class::STAGING_BASE_URL, described_class::ERROR_PATH) }
|
|
let(:service_ping_metadata_url) { File.join(described_class::STAGING_BASE_URL, described_class::METADATA_PATH) }
|
|
let!(:usage_data) { { uuid: 'uuid', recorded_at: Time.current } }
|
|
|
|
let(:subject) { described_class.new(payload: usage_data) }
|
|
|
|
shared_examples 'does not run' do
|
|
it do
|
|
expect(Gitlab::HTTP).not_to receive(:post)
|
|
|
|
subject.execute
|
|
end
|
|
end
|
|
|
|
shared_examples 'does not send a blank usage ping payload' do
|
|
it do
|
|
expect(Gitlab::HTTP).not_to receive(:post).with(service_ping_payload_url, any_args)
|
|
|
|
expect { subject.execute }.to raise_error(described_class::SubmissionError) do |error|
|
|
expect(error.message).to include('Usage data payload is blank')
|
|
end
|
|
end
|
|
end
|
|
|
|
shared_examples 'saves DevOps report data from the response' do
|
|
it do
|
|
expect { subject.execute }
|
|
.to change { DevOpsReport::Metric.count }
|
|
.by(1)
|
|
|
|
expect(DevOpsReport::Metric.last.leader_issues).to eq 10.2
|
|
expect(DevOpsReport::Metric.last.instance_issues).to eq 3.2
|
|
expect(DevOpsReport::Metric.last.percentage_issues).to eq 31.37
|
|
end
|
|
end
|
|
|
|
context 'when usage ping is disabled' do
|
|
before do
|
|
stub_application_setting(usage_ping_enabled: false)
|
|
end
|
|
|
|
it_behaves_like 'does not run'
|
|
end
|
|
|
|
context 'when usage ping is disabled from GitLab config file' do
|
|
before do
|
|
stub_config_setting(usage_ping_enabled: false)
|
|
end
|
|
|
|
it_behaves_like 'does not run'
|
|
end
|
|
|
|
context 'when product_intelligence_enabled is false' do
|
|
before do
|
|
allow(ServicePing::ServicePingSettings).to receive(:product_intelligence_enabled?).and_return(false)
|
|
end
|
|
|
|
it_behaves_like 'does not run'
|
|
end
|
|
|
|
context 'when product_intelligence_enabled is true' do
|
|
before do
|
|
stub_usage_data_connections
|
|
stub_database_flavor_check
|
|
|
|
allow(ServicePing::ServicePingSettings).to receive(:product_intelligence_enabled?).and_return(true)
|
|
end
|
|
|
|
it 'submits a service ping payload without errors', :aggregate_failures do
|
|
response = stub_response(body: with_dev_ops_score_params)
|
|
error_response = stub_response(body: nil, url: service_ping_errors_url, status: 201)
|
|
metadata_response = stub_response(body: nil, url: service_ping_metadata_url, status: 201)
|
|
|
|
expect(Gitlab::HTTP).to receive(:post).twice.and_call_original
|
|
|
|
subject.execute
|
|
|
|
expect(response).to have_been_requested
|
|
expect(error_response).not_to have_been_requested
|
|
expect(metadata_response).to have_been_requested
|
|
end
|
|
end
|
|
|
|
context 'when usage ping is enabled' do
|
|
before do
|
|
stub_usage_data_connections
|
|
stub_database_flavor_check
|
|
stub_application_setting(usage_ping_enabled: true)
|
|
stub_response(body: nil, url: service_ping_errors_url, status: 201)
|
|
stub_response(body: nil, url: service_ping_metadata_url, status: 201)
|
|
end
|
|
|
|
context 'and user requires usage stats consent' do
|
|
before do
|
|
allow(User).to receive(:single_user)
|
|
.and_return(instance_double(User, :user, requires_usage_stats_consent?: true))
|
|
end
|
|
|
|
it_behaves_like 'does not run'
|
|
end
|
|
|
|
it 'sends a POST request' do
|
|
stub_response(body: nil, url: service_ping_metadata_url, status: 201)
|
|
response = stub_response(body: with_dev_ops_score_params)
|
|
|
|
subject.execute
|
|
|
|
expect(response).to have_been_requested
|
|
end
|
|
|
|
context 'when conv_index data is passed' do
|
|
let(:usage_data) { { uuid: 'uuid', recorded_at: Time.current } }
|
|
|
|
before do
|
|
stub_response(body: with_conv_index_params)
|
|
end
|
|
|
|
it_behaves_like 'saves DevOps report data from the response'
|
|
|
|
it 'saves usage_data_id to version_usage_data_id_value' do
|
|
subject.execute
|
|
|
|
raw_usage_data = RawUsageData.find_by(recorded_at: usage_data[:recorded_at])
|
|
|
|
expect(raw_usage_data.version_usage_data_id_value).to eq(31643)
|
|
end
|
|
end
|
|
|
|
context 'when only usage_data_id is passed in response' do
|
|
let(:usage_data) { { uuid: 'uuid', recorded_at: Time.current } }
|
|
|
|
before do
|
|
stub_response(body: with_usage_data_id_params)
|
|
end
|
|
|
|
it 'does not save DevOps report data' do
|
|
expect { subject.execute }.not_to change { DevOpsReport::Metric.count }
|
|
end
|
|
|
|
it 'saves usage_data_id to version_usage_data_id_value' do
|
|
subject.execute
|
|
|
|
raw_usage_data = RawUsageData.find_by(recorded_at: usage_data[:recorded_at])
|
|
|
|
expect(raw_usage_data.version_usage_data_id_value).to eq(31643)
|
|
end
|
|
end
|
|
|
|
context 'when version app usage_data_id is invalid' do
|
|
let(:usage_data_id) { -1000 }
|
|
|
|
before do
|
|
stub_response(body: with_conv_index_params)
|
|
end
|
|
|
|
it 'raises an exception' do
|
|
expect { subject.execute }.to raise_error(described_class::SubmissionError) do |error|
|
|
expect(error.message).to include('Invalid usage_data_id in response: -1000')
|
|
end
|
|
end
|
|
end
|
|
|
|
context 'when DevOps report data is passed' do
|
|
before do
|
|
stub_response(body: with_dev_ops_score_params)
|
|
end
|
|
|
|
it_behaves_like 'saves DevOps report data from the response'
|
|
end
|
|
|
|
context 'with saving raw_usage_data' do
|
|
let(:usage_data) { { uuid: 'uuid', recorded_at: Time.current } }
|
|
|
|
before do
|
|
stub_response(body: with_dev_ops_score_params)
|
|
end
|
|
|
|
it 'creates a raw_usage_data record' do
|
|
expect { subject.execute }.to change(RawUsageData, :count).by(1)
|
|
end
|
|
|
|
it 'saves the correct payload' do
|
|
subject.execute
|
|
|
|
raw_usage_data = RawUsageData.find_by(recorded_at: usage_data[:recorded_at])
|
|
|
|
expect(raw_usage_data.payload.to_json).to eq(usage_data.to_json)
|
|
end
|
|
end
|
|
|
|
context 'and usage ping response has unsuccessful status' do
|
|
before do
|
|
stub_response(body: nil, status: 504)
|
|
end
|
|
|
|
it 'raises an exception' do
|
|
expect { subject.execute }.to raise_error(described_class::SubmissionError) do |error|
|
|
expect(error.message).to include('Unsuccessful response code: 504')
|
|
end
|
|
end
|
|
end
|
|
|
|
context 'and usage data is empty string' do
|
|
let(:usage_data) { {} }
|
|
|
|
it_behaves_like 'does not send a blank usage ping payload'
|
|
end
|
|
|
|
context 'and usage data is nil' do
|
|
let(:usage_data) { nil }
|
|
|
|
it_behaves_like 'does not send a blank usage ping payload'
|
|
end
|
|
|
|
context 'if version app response fails' do
|
|
before do
|
|
stub_response(body: with_dev_ops_score_params, status: 404)
|
|
end
|
|
|
|
it 'raises SubmissionError' do
|
|
# SubmissionError is raised as a result of 404 in response from HTTP Request
|
|
expect { subject.execute }.to raise_error(described_class::SubmissionError)
|
|
end
|
|
end
|
|
|
|
context 'when skip_db_write passed to service' do
|
|
let(:subject) { described_class.new(payload: usage_data, skip_db_write: true) }
|
|
|
|
before do
|
|
stub_response(body: with_dev_ops_score_params)
|
|
end
|
|
|
|
it 'does not save RawUsageData' do
|
|
expect { subject.execute }
|
|
.not_to change { RawUsageData.count }
|
|
end
|
|
|
|
it 'does not call DevOpsReport service' do
|
|
expect(ServicePing::DevopsReport).not_to receive(:new)
|
|
|
|
subject.execute
|
|
end
|
|
end
|
|
end
|
|
|
|
context 'metadata reporting' do
|
|
before do
|
|
stub_usage_data_connections
|
|
stub_database_flavor_check
|
|
stub_application_setting(usage_ping_enabled: true)
|
|
stub_response(body: with_conv_index_params)
|
|
end
|
|
|
|
let(:metric_double) { instance_double(Gitlab::Usage::ServicePing::LegacyMetricTimingDecorator, duration: 123) }
|
|
let(:usage_data) do
|
|
{
|
|
uuid: 'uuid',
|
|
metric_a: metric_double,
|
|
metric_group: {
|
|
metric_b: metric_double
|
|
},
|
|
metric_without_timing: "value",
|
|
recorded_at: Time.current
|
|
}
|
|
end
|
|
|
|
let(:metadata_payload) do
|
|
{
|
|
metadata: {
|
|
uuid: 'uuid',
|
|
metrics: [
|
|
{ name: 'metric_a', time_elapsed: 123 },
|
|
{ name: 'metric_group.metric_b', time_elapsed: 123 }
|
|
]
|
|
}
|
|
}
|
|
end
|
|
|
|
it 'submits metadata' do
|
|
response = stub_full_request(service_ping_metadata_url, method: :post)
|
|
.with(body: metadata_payload)
|
|
|
|
subject.execute
|
|
|
|
expect(response).to have_been_requested
|
|
end
|
|
end
|
|
|
|
def stub_response(url: service_ping_payload_url, body:, status: 201)
|
|
stub_full_request(url, method: :post)
|
|
.to_return(
|
|
headers: { 'Content-Type' => 'application/json' },
|
|
body: body.to_json,
|
|
status: status
|
|
)
|
|
end
|
|
end
|