7b25add30f
Group similar builds We group builds by removing from the builds name two numbers which are delimited by whitespace or colon: * `name 0 1` => `name` * `name 0:1` => `name` * `name 0/1` => `name` * `name 0:1 ruby` => `name ruby` * `name 0/1 ruby` => `name ruby` * `0 1 name ruby` => `name ruby` * `0:1 name ruby` => `name ruby` * `0/1 name ruby` => `name ruby` See merge request !6242
255 lines
7.6 KiB
Ruby
255 lines
7.6 KiB
Ruby
require 'spec_helper'
|
|
|
|
describe CommitStatus, models: true do
|
|
let(:project) { create(:project) }
|
|
|
|
let(:pipeline) do
|
|
create(:ci_pipeline, project: project, sha: project.commit.id)
|
|
end
|
|
|
|
let(:commit_status) { create(:commit_status, pipeline: pipeline) }
|
|
|
|
it { is_expected.to belong_to(:pipeline) }
|
|
it { is_expected.to belong_to(:user) }
|
|
it { is_expected.to belong_to(:project) }
|
|
|
|
it { is_expected.to validate_presence_of(:name) }
|
|
it { is_expected.to validate_inclusion_of(:status).in_array(%w(pending running failed success canceled)) }
|
|
|
|
it { is_expected.to delegate_method(:sha).to(:pipeline) }
|
|
it { is_expected.to delegate_method(:short_sha).to(:pipeline) }
|
|
|
|
it { is_expected.to respond_to :success? }
|
|
it { is_expected.to respond_to :failed? }
|
|
it { is_expected.to respond_to :running? }
|
|
it { is_expected.to respond_to :pending? }
|
|
|
|
describe '#author' do
|
|
subject { commit_status.author }
|
|
before { commit_status.author = User.new }
|
|
|
|
it { is_expected.to eq(commit_status.user) }
|
|
end
|
|
|
|
describe '#started?' do
|
|
subject { commit_status.started? }
|
|
|
|
context 'without started_at' do
|
|
before { commit_status.started_at = nil }
|
|
|
|
it { is_expected.to be_falsey }
|
|
end
|
|
|
|
%w[running success failed].each do |status|
|
|
context "if commit status is #{status}" do
|
|
before { commit_status.status = status }
|
|
|
|
it { is_expected.to be_truthy }
|
|
end
|
|
end
|
|
|
|
%w[pending canceled].each do |status|
|
|
context "if commit status is #{status}" do
|
|
before { commit_status.status = status }
|
|
|
|
it { is_expected.to be_falsey }
|
|
end
|
|
end
|
|
end
|
|
|
|
describe '#active?' do
|
|
subject { commit_status.active? }
|
|
|
|
%w[pending running].each do |state|
|
|
context "if commit_status.status is #{state}" do
|
|
before { commit_status.status = state }
|
|
|
|
it { is_expected.to be_truthy }
|
|
end
|
|
end
|
|
|
|
%w[success failed canceled].each do |state|
|
|
context "if commit_status.status is #{state}" do
|
|
before { commit_status.status = state }
|
|
|
|
it { is_expected.to be_falsey }
|
|
end
|
|
end
|
|
end
|
|
|
|
describe '#complete?' do
|
|
subject { commit_status.complete? }
|
|
|
|
%w[success failed canceled].each do |state|
|
|
context "if commit_status.status is #{state}" do
|
|
before { commit_status.status = state }
|
|
|
|
it { is_expected.to be_truthy }
|
|
end
|
|
end
|
|
|
|
%w[pending running].each do |state|
|
|
context "if commit_status.status is #{state}" do
|
|
before { commit_status.status = state }
|
|
|
|
it { is_expected.to be_falsey }
|
|
end
|
|
end
|
|
end
|
|
|
|
describe '#duration' do
|
|
subject { commit_status.duration }
|
|
|
|
it { is_expected.to eq(120.0) }
|
|
|
|
context 'if the building process has not started yet' do
|
|
before do
|
|
commit_status.started_at = nil
|
|
commit_status.finished_at = nil
|
|
end
|
|
|
|
it { is_expected.to be_nil }
|
|
end
|
|
|
|
context 'if the building process has started' do
|
|
before do
|
|
commit_status.started_at = Time.now - 1.minute
|
|
commit_status.finished_at = nil
|
|
end
|
|
|
|
it { is_expected.to be_a(Float) }
|
|
it { is_expected.to be > 0.0 }
|
|
end
|
|
end
|
|
|
|
describe '.latest' do
|
|
subject { CommitStatus.latest.order(:id) }
|
|
|
|
before do
|
|
@commit1 = FactoryGirl.create :commit_status, pipeline: pipeline, name: 'aa', ref: 'bb', status: 'running'
|
|
@commit2 = FactoryGirl.create :commit_status, pipeline: pipeline, name: 'cc', ref: 'cc', status: 'pending'
|
|
@commit3 = FactoryGirl.create :commit_status, pipeline: pipeline, name: 'aa', ref: 'cc', status: 'success'
|
|
@commit4 = FactoryGirl.create :commit_status, pipeline: pipeline, name: 'cc', ref: 'bb', status: 'success'
|
|
@commit5 = FactoryGirl.create :commit_status, pipeline: pipeline, name: 'aa', ref: 'bb', status: 'success'
|
|
end
|
|
|
|
it 'returns unique statuses' do
|
|
is_expected.to eq([@commit4, @commit5])
|
|
end
|
|
end
|
|
|
|
describe '.running_or_pending' do
|
|
subject { CommitStatus.running_or_pending.order(:id) }
|
|
|
|
before do
|
|
@commit1 = FactoryGirl.create :commit_status, pipeline: pipeline, name: 'aa', ref: 'bb', status: 'running'
|
|
@commit2 = FactoryGirl.create :commit_status, pipeline: pipeline, name: 'cc', ref: 'cc', status: 'pending'
|
|
@commit3 = FactoryGirl.create :commit_status, pipeline: pipeline, name: 'aa', ref: nil, status: 'success'
|
|
@commit4 = FactoryGirl.create :commit_status, pipeline: pipeline, name: 'dd', ref: nil, status: 'failed'
|
|
@commit5 = FactoryGirl.create :commit_status, pipeline: pipeline, name: 'ee', ref: nil, status: 'canceled'
|
|
end
|
|
|
|
it 'returns statuses that are running or pending' do
|
|
is_expected.to eq([@commit1, @commit2])
|
|
end
|
|
end
|
|
|
|
describe '#before_sha' do
|
|
subject { commit_status.before_sha }
|
|
|
|
context 'when no before_sha is set for pipeline' do
|
|
before { pipeline.before_sha = nil }
|
|
|
|
it 'returns blank sha' do
|
|
is_expected.to eq(Gitlab::Git::BLANK_SHA)
|
|
end
|
|
end
|
|
|
|
context 'for before_sha set for pipeline' do
|
|
let(:value) { '1234' }
|
|
before { pipeline.before_sha = value }
|
|
|
|
it 'returns the set value' do
|
|
is_expected.to eq(value)
|
|
end
|
|
end
|
|
end
|
|
|
|
describe '#stages' do
|
|
before do
|
|
create :commit_status, pipeline: pipeline, stage: 'build', name: 'linux', stage_idx: 0, status: 'success'
|
|
create :commit_status, pipeline: pipeline, stage: 'build', name: 'mac', stage_idx: 0, status: 'failed'
|
|
create :commit_status, pipeline: pipeline, stage: 'deploy', name: 'staging', stage_idx: 2, status: 'running'
|
|
create :commit_status, pipeline: pipeline, stage: 'test', name: 'rspec', stage_idx: 1, status: 'success'
|
|
end
|
|
|
|
context 'stages list' do
|
|
subject { CommitStatus.where(pipeline: pipeline).stages }
|
|
|
|
it 'returns ordered list of stages' do
|
|
is_expected.to eq(%w[build test deploy])
|
|
end
|
|
end
|
|
|
|
context 'stages with statuses' do
|
|
subject { CommitStatus.where(pipeline: pipeline).latest.stages_status }
|
|
|
|
it 'returns list of stages with statuses' do
|
|
is_expected.to eq({
|
|
'build' => 'failed',
|
|
'test' => 'success',
|
|
'deploy' => 'running'
|
|
})
|
|
end
|
|
|
|
context 'when build is retried' do
|
|
before do
|
|
create :commit_status, pipeline: pipeline, stage: 'build', name: 'mac', stage_idx: 0, status: 'success'
|
|
end
|
|
|
|
it 'ignores a previous state' do
|
|
is_expected.to eq({
|
|
'build' => 'success',
|
|
'test' => 'success',
|
|
'deploy' => 'running'
|
|
})
|
|
end
|
|
end
|
|
end
|
|
end
|
|
|
|
describe '#commit' do
|
|
it 'returns commit pipeline has been created for' do
|
|
expect(commit_status.commit).to eq project.commit
|
|
end
|
|
end
|
|
|
|
describe '#group_name' do
|
|
subject { commit_status.group_name }
|
|
|
|
tests = {
|
|
'rspec:windows' => 'rspec:windows',
|
|
'rspec:windows 0' => 'rspec:windows 0',
|
|
'rspec:windows 0 test' => 'rspec:windows 0 test',
|
|
'rspec:windows 0 1' => 'rspec:windows',
|
|
'rspec:windows 0 1 name' => 'rspec:windows name',
|
|
'rspec:windows 0/1' => 'rspec:windows',
|
|
'rspec:windows 0/1 name' => 'rspec:windows name',
|
|
'rspec:windows 0:1' => 'rspec:windows',
|
|
'rspec:windows 0:1 name' => 'rspec:windows name',
|
|
'rspec:windows 10000 20000' => 'rspec:windows',
|
|
'rspec:windows 0 : / 1' => 'rspec:windows',
|
|
'rspec:windows 0 : / 1 name' => 'rspec:windows name',
|
|
'0 1 name ruby' => 'name ruby',
|
|
'0 :/ 1 name ruby' => 'name ruby'
|
|
}
|
|
|
|
tests.each do |name, group_name|
|
|
it "'#{name}' puts in '#{group_name}'" do
|
|
commit_status.name = name
|
|
|
|
is_expected.to eq(group_name)
|
|
end
|
|
end
|
|
end
|
|
end
|