0444fa560a
1. Allow subscribing (the current user) to a label
- Refactor the `Subscription` coffeescript class
- The main change is that it accepts a container, and conducts all
DOM queries within its scope. We need this because the labels
page has multiple instances of `Subscription` on the same page.
2. Creating an issue or MR with labels notifies users subscribed to those labels
- Label `has_many` subscribers through subscriptions.
3. Adding a label to an issue or MR notifies users subscribed to those labels
- This only applies to subscribers of the label that has just been
added, not all labels for the issue.
101 lines
3.1 KiB
Ruby
101 lines
3.1 KiB
Ruby
class IssuableBaseService < BaseService
|
|
private
|
|
|
|
def create_assignee_note(issuable)
|
|
SystemNoteService.change_assignee(
|
|
issuable, issuable.project, current_user, issuable.assignee)
|
|
end
|
|
|
|
def create_milestone_note(issuable)
|
|
SystemNoteService.change_milestone(
|
|
issuable, issuable.project, current_user, issuable.milestone)
|
|
end
|
|
|
|
def create_labels_note(issuable, added_labels, removed_labels)
|
|
SystemNoteService.change_label(
|
|
issuable, issuable.project, current_user, added_labels, removed_labels)
|
|
end
|
|
|
|
def create_title_change_note(issuable, old_title)
|
|
SystemNoteService.change_title(
|
|
issuable, issuable.project, current_user, old_title)
|
|
end
|
|
|
|
def create_branch_change_note(issuable, branch_type, old_branch, new_branch)
|
|
SystemNoteService.change_branch(
|
|
issuable, issuable.project, current_user, branch_type,
|
|
old_branch, new_branch)
|
|
end
|
|
|
|
def create_task_status_note(issuable)
|
|
issuable.updated_tasks.each do |task|
|
|
SystemNoteService.change_task_status(issuable, issuable.project, current_user, task)
|
|
end
|
|
end
|
|
|
|
def filter_params(issuable_ability_name = :issue)
|
|
params[:assignee_id] = "" if params[:assignee_id] == IssuableFinder::NONE
|
|
params[:milestone_id] = "" if params[:milestone_id] == IssuableFinder::NONE
|
|
|
|
ability = :"admin_#{issuable_ability_name}"
|
|
|
|
unless can?(current_user, ability, project)
|
|
params.delete(:milestone_id)
|
|
params.delete(:label_ids)
|
|
params.delete(:assignee_id)
|
|
end
|
|
end
|
|
|
|
def update(issuable)
|
|
change_state(issuable)
|
|
filter_params
|
|
old_labels = issuable.labels.to_a
|
|
|
|
if params.present? && issuable.update_attributes(params.merge(updated_by: current_user))
|
|
issuable.reset_events_cache
|
|
handle_common_system_notes(issuable, old_labels: old_labels)
|
|
handle_changes(issuable, old_labels: old_labels)
|
|
issuable.create_new_cross_references!(current_user)
|
|
execute_hooks(issuable, 'update')
|
|
end
|
|
|
|
issuable
|
|
end
|
|
|
|
def change_state(issuable)
|
|
case params.delete(:state_event)
|
|
when 'reopen'
|
|
reopen_service.new(project, current_user, {}).execute(issuable)
|
|
when 'close'
|
|
close_service.new(project, current_user, {}).execute(issuable)
|
|
end
|
|
end
|
|
|
|
def has_changes?(issuable, options = {})
|
|
valid_attrs = [:title, :description, :assignee_id, :milestone_id, :target_branch]
|
|
|
|
attrs_changed = valid_attrs.any? do |attr|
|
|
issuable.previous_changes.include?(attr.to_s)
|
|
end
|
|
|
|
old_labels = options[:old_labels]
|
|
labels_changed = old_labels && issuable.labels != old_labels
|
|
|
|
attrs_changed || labels_changed
|
|
end
|
|
|
|
def handle_common_system_notes(issuable, options = {})
|
|
if issuable.previous_changes.include?('title')
|
|
create_title_change_note(issuable, issuable.previous_changes['title'].first)
|
|
end
|
|
|
|
if issuable.previous_changes.include?('description') && issuable.tasks?
|
|
create_task_status_note(issuable)
|
|
end
|
|
|
|
old_labels = options[:old_labels]
|
|
if old_labels && (issuable.labels != old_labels)
|
|
create_labels_note(issuable, issuable.added_labels(old_labels), old_labels - issuable.labels)
|
|
end
|
|
end
|
|
end
|