3b76b73ab1
GitLab EE adds an extra relation that selects a "project_id" column instead of an "id" column, making it very hard for this method to be re-used in EE. Since using User#authorized_groups in ProjectsFinder#all_groups apparently has no performance impact we can just use it and keep everything compatible with EE. |
||
---|---|---|
.. | ||
README.md | ||
contributed_projects_finder.rb | ||
issuable_finder.rb | ||
issues_finder.rb | ||
merge_requests_finder.rb | ||
milestones_finder.rb | ||
notes_finder.rb | ||
personal_projects_finder.rb | ||
projects_finder.rb | ||
snippets_finder.rb | ||
todos_finder.rb | ||
trending_projects_finder.rb |
README.md
Finders
This type of classes responsible for collection items based on different conditions. To prevent lookup methods in models like this:
class Project
def issues_for_user_filtered_by(user, filter)
# A lot of logic not related to project model itself
end
end
issues = project.issues_for_user_filtered_by(user, params)
Better use this:
issues = IssuesFinder.new(project, user, filter).execute
It will help keep models thiner.