2385 lines
76 KiB
Ruby
2385 lines
76 KiB
Ruby
# frozen_string_literal: true
|
|
|
|
require 'spec_helper'
|
|
|
|
RSpec.describe ProjectPolicy do
|
|
include ExternalAuthorizationServiceHelpers
|
|
include AdminModeHelper
|
|
include_context 'ProjectPolicy context'
|
|
|
|
let(:project) { public_project }
|
|
|
|
subject { described_class.new(current_user, project) }
|
|
|
|
def expect_allowed(*permissions)
|
|
permissions.each { |p| is_expected.to be_allowed(p) }
|
|
end
|
|
|
|
def expect_disallowed(*permissions)
|
|
permissions.each { |p| is_expected.not_to be_allowed(p) }
|
|
end
|
|
|
|
context 'with no project feature' do
|
|
let(:current_user) { owner }
|
|
|
|
before do
|
|
project.project_feature.destroy!
|
|
project.reload
|
|
end
|
|
|
|
it 'returns false' do
|
|
is_expected.to be_disallowed(:read_build)
|
|
end
|
|
end
|
|
|
|
it 'does not include the read permissions when the issue author is not a member of the private project' do
|
|
project = create(:project, :private)
|
|
issue = create(:issue, project: project, author: create(:user))
|
|
user = issue.author
|
|
|
|
expect(project.team.member?(issue.author)).to be false
|
|
|
|
expect(Ability).not_to be_allowed(user, :read_issue, project)
|
|
expect(Ability).not_to be_allowed(user, :read_work_item, project)
|
|
end
|
|
|
|
it_behaves_like 'model with wiki policies' do
|
|
let(:container) { project }
|
|
let_it_be(:user) { owner }
|
|
|
|
def set_access_level(access_level)
|
|
project.project_feature.update_attribute(:wiki_access_level, access_level)
|
|
end
|
|
end
|
|
|
|
context 'issues feature' do
|
|
let(:current_user) { owner }
|
|
|
|
context 'when the feature is disabled' do
|
|
before do
|
|
project.issues_enabled = false
|
|
project.save!
|
|
end
|
|
|
|
it 'does not include the issues permissions' do
|
|
expect_disallowed :read_issue, :read_issue_iid, :create_issue, :update_issue, :admin_issue, :create_incident, :create_work_item, :create_task, :read_work_item
|
|
end
|
|
|
|
it 'disables boards and lists permissions' do
|
|
expect_disallowed :read_issue_board, :create_board, :update_board
|
|
expect_disallowed :read_issue_board_list, :create_list, :update_list, :admin_issue_board_list
|
|
end
|
|
|
|
context 'when external tracker configured' do
|
|
it 'does not include the issues permissions' do
|
|
create(:jira_integration, project: project)
|
|
|
|
expect_disallowed :read_issue, :read_issue_iid, :create_issue, :update_issue, :admin_issue, :create_incident, :create_work_item, :create_task, :read_work_item
|
|
end
|
|
end
|
|
end
|
|
end
|
|
|
|
context 'merge requests feature' do
|
|
let(:current_user) { owner }
|
|
let(:mr_permissions) do
|
|
[:create_merge_request_from, :read_merge_request, :update_merge_request,
|
|
:admin_merge_request, :create_merge_request_in]
|
|
end
|
|
|
|
it 'disallows all permissions when the feature is disabled' do
|
|
project.project_feature.update!(merge_requests_access_level: ProjectFeature::DISABLED)
|
|
|
|
expect_disallowed(*mr_permissions)
|
|
end
|
|
|
|
context 'for a guest in a private project' do
|
|
let(:current_user) { guest }
|
|
let(:project) { private_project }
|
|
|
|
it 'disallows the guest from all merge request permissions' do
|
|
expect_disallowed(*mr_permissions)
|
|
end
|
|
end
|
|
end
|
|
|
|
context 'creating_merge_request_in' do
|
|
context 'when the current_user can download_code' do
|
|
before do
|
|
expect(subject).to receive(:allowed?).with(:download_code).and_return(true)
|
|
allow(subject).to receive(:allowed?).with(any_args).and_call_original
|
|
end
|
|
|
|
context 'when project is public' do
|
|
let(:project) { public_project }
|
|
|
|
context 'when the current_user is guest' do
|
|
let(:current_user) { guest }
|
|
|
|
it { is_expected.to be_allowed(:create_merge_request_in) }
|
|
end
|
|
end
|
|
|
|
context 'when project is internal' do
|
|
let(:project) { internal_project }
|
|
|
|
context 'when the current_user is guest' do
|
|
let(:current_user) { guest }
|
|
|
|
it { is_expected.to be_allowed(:create_merge_request_in) }
|
|
end
|
|
end
|
|
|
|
context 'when project is private' do
|
|
let(:project) { private_project }
|
|
|
|
context 'when the current_user is guest' do
|
|
let(:current_user) { guest }
|
|
|
|
it { is_expected.not_to be_allowed(:create_merge_request_in) }
|
|
end
|
|
|
|
context 'when the current_user is reporter or above' do
|
|
let(:current_user) { reporter }
|
|
|
|
it { is_expected.to be_allowed(:create_merge_request_in) }
|
|
end
|
|
end
|
|
end
|
|
|
|
context 'when the current_user can not download code' do
|
|
before do
|
|
expect(subject).to receive(:allowed?).with(:download_code).and_return(false)
|
|
allow(subject).to receive(:allowed?).with(any_args).and_call_original
|
|
end
|
|
|
|
context 'when project is public' do
|
|
let(:project) { public_project }
|
|
|
|
context 'when the current_user is guest' do
|
|
let(:current_user) { guest }
|
|
|
|
it { is_expected.not_to be_allowed(:create_merge_request_in) }
|
|
end
|
|
end
|
|
|
|
context 'when project is internal' do
|
|
let(:project) { internal_project }
|
|
|
|
context 'when the current_user is guest' do
|
|
let(:current_user) { guest }
|
|
|
|
it { is_expected.not_to be_allowed(:create_merge_request_in) }
|
|
end
|
|
end
|
|
|
|
context 'when project is private' do
|
|
let(:project) { private_project }
|
|
|
|
context 'when the current_user is guest' do
|
|
let(:current_user) { guest }
|
|
|
|
it { is_expected.not_to be_allowed(:create_merge_request_in) }
|
|
end
|
|
|
|
context 'when the current_user is reporter or above' do
|
|
let(:current_user) { reporter }
|
|
|
|
it { is_expected.not_to be_allowed(:create_merge_request_in) }
|
|
end
|
|
end
|
|
end
|
|
end
|
|
|
|
context 'pipeline feature' do
|
|
let(:project) { private_project }
|
|
let(:current_user) { developer }
|
|
let(:pipeline) { create(:ci_pipeline, project: project) }
|
|
|
|
describe 'for confirmed user' do
|
|
it 'allows modify pipelines' do
|
|
expect_allowed(:create_pipeline)
|
|
expect_allowed(:update_pipeline)
|
|
expect_allowed(:create_pipeline_schedule)
|
|
end
|
|
end
|
|
|
|
describe 'for unconfirmed user' do
|
|
let(:current_user) { project.first_owner.tap { |u| u.update!(confirmed_at: nil) } }
|
|
|
|
it 'disallows to modify pipelines' do
|
|
expect_disallowed(:create_pipeline)
|
|
expect_disallowed(:update_pipeline)
|
|
expect_disallowed(:destroy_pipeline)
|
|
expect_disallowed(:create_pipeline_schedule)
|
|
end
|
|
end
|
|
|
|
describe 'destroy permission' do
|
|
describe 'for developers' do
|
|
it 'prevents :destroy_pipeline' do
|
|
expect(current_user.can?(:destroy_pipeline, pipeline)).to be_falsey
|
|
end
|
|
end
|
|
|
|
describe 'for maintainers' do
|
|
let(:current_user) { maintainer }
|
|
|
|
it 'prevents :destroy_pipeline' do
|
|
project.add_maintainer(maintainer)
|
|
expect(current_user.can?(:destroy_pipeline, pipeline)).to be_falsey
|
|
end
|
|
end
|
|
|
|
describe 'for project owner' do
|
|
let(:current_user) { project.first_owner }
|
|
|
|
it 'allows :destroy_pipeline' do
|
|
expect(current_user.can?(:destroy_pipeline, pipeline)).to be_truthy
|
|
end
|
|
|
|
context 'on archived projects' do
|
|
before do
|
|
project.update!(archived: true)
|
|
end
|
|
|
|
it 'prevents :destroy_pipeline' do
|
|
expect(current_user.can?(:destroy_pipeline, pipeline)).to be_falsey
|
|
end
|
|
end
|
|
|
|
context 'on archived pending_delete projects' do
|
|
before do
|
|
project.update!(archived: true, pending_delete: true)
|
|
end
|
|
|
|
it 'allows :destroy_pipeline' do
|
|
expect(current_user.can?(:destroy_pipeline, pipeline)).to be_truthy
|
|
end
|
|
end
|
|
end
|
|
end
|
|
end
|
|
|
|
context 'builds feature' do
|
|
context 'when builds are disabled' do
|
|
let(:current_user) { owner }
|
|
|
|
before do
|
|
project.project_feature.update!(builds_access_level: ProjectFeature::DISABLED)
|
|
end
|
|
|
|
it 'disallows all permissions except pipeline when the feature is disabled' do
|
|
builds_permissions = [
|
|
:create_build, :read_build, :update_build, :admin_build, :destroy_build,
|
|
:create_pipeline_schedule, :read_pipeline_schedule_variables, :update_pipeline_schedule, :admin_pipeline_schedule, :destroy_pipeline_schedule,
|
|
:create_environment, :read_environment, :update_environment, :admin_environment, :destroy_environment,
|
|
:create_cluster, :read_cluster, :update_cluster, :admin_cluster, :destroy_cluster,
|
|
:create_deployment, :read_deployment, :update_deployment, :admin_deployment, :destroy_deployment
|
|
]
|
|
|
|
expect_disallowed(*builds_permissions)
|
|
end
|
|
end
|
|
|
|
context 'when builds are disabled only for some users' do
|
|
let(:current_user) { guest }
|
|
|
|
before do
|
|
project.project_feature.update!(builds_access_level: ProjectFeature::PRIVATE)
|
|
end
|
|
|
|
it 'disallows pipeline and commit_status permissions' do
|
|
builds_permissions = [
|
|
:create_pipeline, :update_pipeline, :admin_pipeline, :destroy_pipeline,
|
|
:create_commit_status, :update_commit_status, :admin_commit_status, :destroy_commit_status
|
|
]
|
|
|
|
expect_disallowed(*builds_permissions)
|
|
end
|
|
end
|
|
end
|
|
|
|
context 'repository feature' do
|
|
let(:repository_permissions) do
|
|
[
|
|
:create_pipeline, :update_pipeline, :admin_pipeline, :destroy_pipeline,
|
|
:create_build, :read_build, :update_build, :admin_build, :destroy_build,
|
|
:create_pipeline_schedule, :read_pipeline_schedule, :update_pipeline_schedule, :admin_pipeline_schedule, :destroy_pipeline_schedule,
|
|
:create_environment, :read_environment, :update_environment, :admin_environment, :destroy_environment,
|
|
:create_cluster, :read_cluster, :update_cluster, :admin_cluster,
|
|
:create_deployment, :read_deployment, :update_deployment, :admin_deployment, :destroy_deployment,
|
|
:destroy_release, :download_code, :build_download_code
|
|
]
|
|
end
|
|
|
|
context 'when user is a project member' do
|
|
let(:current_user) { owner }
|
|
|
|
context 'when it is disabled' do
|
|
before do
|
|
project.project_feature.update!(
|
|
repository_access_level: ProjectFeature::DISABLED,
|
|
merge_requests_access_level: ProjectFeature::DISABLED,
|
|
builds_access_level: ProjectFeature::DISABLED,
|
|
forking_access_level: ProjectFeature::DISABLED
|
|
)
|
|
end
|
|
|
|
it 'disallows all permissions' do
|
|
expect_disallowed(*repository_permissions)
|
|
end
|
|
end
|
|
end
|
|
|
|
context 'when user is non-member' do
|
|
let(:current_user) { non_member }
|
|
|
|
context 'when access level is private' do
|
|
before do
|
|
project.project_feature.update!(
|
|
repository_access_level: ProjectFeature::PRIVATE,
|
|
merge_requests_access_level: ProjectFeature::PRIVATE,
|
|
builds_access_level: ProjectFeature::PRIVATE,
|
|
forking_access_level: ProjectFeature::PRIVATE
|
|
)
|
|
end
|
|
|
|
it 'disallows all permissions' do
|
|
expect_disallowed(*repository_permissions)
|
|
end
|
|
end
|
|
end
|
|
end
|
|
|
|
it_behaves_like 'project policies as anonymous'
|
|
it_behaves_like 'project policies as guest'
|
|
it_behaves_like 'project policies as reporter'
|
|
it_behaves_like 'project policies as developer'
|
|
it_behaves_like 'project policies as maintainer'
|
|
it_behaves_like 'project policies as owner'
|
|
it_behaves_like 'project policies as admin with admin mode'
|
|
it_behaves_like 'project policies as admin without admin mode'
|
|
|
|
context 'when a public project has merge requests allowing access' do
|
|
include ProjectForksHelper
|
|
let(:current_user) { create(:user) }
|
|
let(:target_project) { create(:project, :public) }
|
|
let(:project) { fork_project(target_project) }
|
|
let!(:merge_request) do
|
|
create(
|
|
:merge_request,
|
|
target_project: target_project,
|
|
source_project: project,
|
|
allow_collaboration: true
|
|
)
|
|
end
|
|
|
|
let(:maintainer_abilities) do
|
|
%w(create_build create_pipeline)
|
|
end
|
|
|
|
it 'does not allow pushing code' do
|
|
expect_disallowed(*maintainer_abilities)
|
|
end
|
|
|
|
it 'allows pushing if the user is a member with push access to the target project' do
|
|
target_project.add_developer(current_user)
|
|
|
|
expect_allowed(*maintainer_abilities)
|
|
end
|
|
|
|
it 'disallows abilities to a maintainer if the merge request was closed' do
|
|
target_project.add_developer(current_user)
|
|
merge_request.close!
|
|
|
|
expect_disallowed(*maintainer_abilities)
|
|
end
|
|
end
|
|
|
|
context 'importing members from another project' do
|
|
%w(maintainer owner).each do |role|
|
|
context "with #{role}" do
|
|
let(:current_user) { send(role) }
|
|
|
|
it { is_expected.to be_allowed(:import_project_members_from_another_project) }
|
|
end
|
|
end
|
|
|
|
%w(guest reporter developer anonymous).each do |role|
|
|
context "with #{role}" do
|
|
let(:current_user) { send(role) }
|
|
|
|
it { is_expected.to be_disallowed(:import_project_members_from_another_project) }
|
|
end
|
|
end
|
|
|
|
context 'with an admin' do
|
|
let(:current_user) { admin }
|
|
|
|
context 'when admin mode is enabled', :enable_admin_mode do
|
|
it { expect_allowed(:import_project_members_from_another_project) }
|
|
end
|
|
|
|
context 'when admin mode is disabled' do
|
|
it { expect_disallowed(:import_project_members_from_another_project) }
|
|
end
|
|
end
|
|
end
|
|
|
|
context 'reading usage quotas' do
|
|
%w(maintainer owner).each do |role|
|
|
context "with #{role}" do
|
|
let(:current_user) { send(role) }
|
|
|
|
it { is_expected.to be_allowed(:read_usage_quotas) }
|
|
end
|
|
end
|
|
|
|
%w(guest reporter developer anonymous).each do |role|
|
|
context "with #{role}" do
|
|
let(:current_user) { send(role) }
|
|
|
|
it { is_expected.to be_disallowed(:read_usage_quotas) }
|
|
end
|
|
end
|
|
|
|
context 'with an admin' do
|
|
let(:current_user) { admin }
|
|
|
|
context 'when admin mode is enabled', :enable_admin_mode do
|
|
it { expect_allowed(:read_usage_quotas) }
|
|
end
|
|
|
|
context 'when admin mode is disabled' do
|
|
it { expect_disallowed(:read_usage_quotas) }
|
|
end
|
|
end
|
|
end
|
|
|
|
it_behaves_like 'clusterable policies' do
|
|
let_it_be(:clusterable) { create(:project, :repository) }
|
|
let_it_be(:cluster) do
|
|
create(:cluster, :provided_by_gcp, :project, projects: [clusterable])
|
|
end
|
|
end
|
|
|
|
context 'owner access' do
|
|
let!(:owner_user) { create(:user) }
|
|
let!(:owner_of_different_thing) { create(:user) }
|
|
let(:stranger) { create(:user) }
|
|
|
|
context 'personal project' do
|
|
let!(:project) { create(:project) }
|
|
let!(:project2) { create(:project) }
|
|
|
|
before do
|
|
project.add_guest(guest)
|
|
project.add_reporter(reporter)
|
|
project.add_developer(developer)
|
|
project.add_maintainer(maintainer)
|
|
project2.add_owner(owner_of_different_thing)
|
|
end
|
|
|
|
it 'allows owner access', :aggregate_failures do
|
|
expect(described_class.new(owner_of_different_thing, project)).to be_disallowed(:owner_access)
|
|
expect(described_class.new(stranger, project)).to be_disallowed(:owner_access)
|
|
expect(described_class.new(guest, project)).to be_disallowed(:owner_access)
|
|
expect(described_class.new(reporter, project)).to be_disallowed(:owner_access)
|
|
expect(described_class.new(developer, project)).to be_disallowed(:owner_access)
|
|
expect(described_class.new(maintainer, project)).to be_disallowed(:owner_access)
|
|
expect(described_class.new(project.owner, project)).to be_allowed(:owner_access)
|
|
end
|
|
end
|
|
|
|
context 'group project' do
|
|
let(:group) { create(:group) }
|
|
let!(:group2) { create(:group) }
|
|
let!(:project) { create(:project, group: group) }
|
|
|
|
context 'group members' do
|
|
before do
|
|
group.add_guest(guest)
|
|
group.add_reporter(reporter)
|
|
group.add_developer(developer)
|
|
group.add_maintainer(maintainer)
|
|
group.add_owner(owner_user)
|
|
group2.add_owner(owner_of_different_thing)
|
|
end
|
|
|
|
it 'allows owner access', :aggregate_failures do
|
|
expect(described_class.new(owner_of_different_thing, project)).to be_disallowed(:owner_access)
|
|
expect(described_class.new(stranger, project)).to be_disallowed(:owner_access)
|
|
expect(described_class.new(guest, project)).to be_disallowed(:owner_access)
|
|
expect(described_class.new(reporter, project)).to be_disallowed(:owner_access)
|
|
expect(described_class.new(developer, project)).to be_disallowed(:owner_access)
|
|
expect(described_class.new(maintainer, project)).to be_disallowed(:owner_access)
|
|
expect(described_class.new(owner_user, project)).to be_allowed(:owner_access)
|
|
end
|
|
end
|
|
end
|
|
end
|
|
|
|
context 'reading a project' do
|
|
it 'allows access when a user has read access to the repo' do
|
|
expect(described_class.new(owner, project)).to be_allowed(:read_project)
|
|
expect(described_class.new(developer, project)).to be_allowed(:read_project)
|
|
expect(described_class.new(admin, project)).to be_allowed(:read_project)
|
|
end
|
|
|
|
it 'never checks the external service' do
|
|
expect(::Gitlab::ExternalAuthorization).not_to receive(:access_allowed?)
|
|
|
|
expect(described_class.new(owner, project)).to be_allowed(:read_project)
|
|
end
|
|
|
|
context 'with an external authorization service' do
|
|
before do
|
|
enable_external_authorization_service_check
|
|
end
|
|
|
|
it 'allows access when the external service allows it' do
|
|
external_service_allow_access(owner, project)
|
|
external_service_allow_access(developer, project)
|
|
|
|
expect(described_class.new(owner, project)).to be_allowed(:read_project)
|
|
expect(described_class.new(developer, project)).to be_allowed(:read_project)
|
|
end
|
|
|
|
context 'with an admin' do
|
|
context 'when admin mode is enabled', :enable_admin_mode do
|
|
it 'does not check the external service and allows access' do
|
|
expect(::Gitlab::ExternalAuthorization).not_to receive(:access_allowed?)
|
|
|
|
expect(described_class.new(admin, project)).to be_allowed(:read_project)
|
|
end
|
|
end
|
|
|
|
context 'when admin mode is disabled' do
|
|
it 'checks the external service and allows access' do
|
|
external_service_allow_access(admin, project)
|
|
|
|
expect(::Gitlab::ExternalAuthorization).to receive(:access_allowed?)
|
|
|
|
expect(described_class.new(admin, project)).to be_allowed(:read_project)
|
|
end
|
|
end
|
|
end
|
|
|
|
it 'prevents all but seeing a public project in a list when access is denied' do
|
|
[developer, owner, build(:user), nil].each do |user|
|
|
external_service_deny_access(user, project)
|
|
policy = described_class.new(user, project)
|
|
|
|
expect(policy).not_to be_allowed(:read_project)
|
|
expect(policy).not_to be_allowed(:owner_access)
|
|
expect(policy).not_to be_allowed(:change_namespace)
|
|
end
|
|
end
|
|
|
|
it 'passes the full path to external authorization for logging purposes' do
|
|
expect(::Gitlab::ExternalAuthorization)
|
|
.to receive(:access_allowed?).with(owner, 'default_label', project.full_path).and_call_original
|
|
|
|
described_class.new(owner, project).allowed?(:read_project)
|
|
end
|
|
end
|
|
end
|
|
|
|
context 'forking a project' do
|
|
context 'anonymous user' do
|
|
let(:current_user) { anonymous }
|
|
|
|
it { is_expected.to be_disallowed(:fork_project) }
|
|
end
|
|
|
|
context 'project member' do
|
|
let(:project) { private_project }
|
|
|
|
context 'guest' do
|
|
let(:current_user) { guest }
|
|
|
|
it { is_expected.to be_disallowed(:fork_project) }
|
|
end
|
|
|
|
%w(reporter developer maintainer).each do |role|
|
|
context role do
|
|
let(:current_user) { send(role) }
|
|
|
|
it { is_expected.to be_allowed(:fork_project) }
|
|
end
|
|
end
|
|
end
|
|
end
|
|
|
|
describe 'create_task' do
|
|
context 'when user is member of the project' do
|
|
let(:current_user) { developer }
|
|
|
|
context 'when work_items feature flag is enabled' do
|
|
it { expect_allowed(:create_task) }
|
|
end
|
|
|
|
context 'when work_items feature flag is disabled' do
|
|
before do
|
|
stub_feature_flags(work_items: false)
|
|
end
|
|
|
|
it { expect_disallowed(:create_task) }
|
|
end
|
|
end
|
|
end
|
|
|
|
describe 'update_max_artifacts_size' do
|
|
context 'when no user' do
|
|
let(:current_user) { anonymous }
|
|
|
|
it { expect_disallowed(:update_max_artifacts_size) }
|
|
end
|
|
|
|
context 'admin' do
|
|
let(:current_user) { admin }
|
|
|
|
context 'when admin mode is enabled', :enable_admin_mode do
|
|
it { expect_allowed(:update_max_artifacts_size) }
|
|
end
|
|
|
|
context 'when admin mode is disabled' do
|
|
it { expect_disallowed(:update_max_artifacts_size) }
|
|
end
|
|
end
|
|
|
|
%w(guest reporter developer maintainer owner).each do |role|
|
|
context role do
|
|
let(:current_user) { send(role) }
|
|
|
|
it { expect_disallowed(:update_max_artifacts_size) }
|
|
end
|
|
end
|
|
end
|
|
|
|
describe 'read_storage_disk_path' do
|
|
context 'when no user' do
|
|
let(:current_user) { anonymous }
|
|
|
|
it { expect_disallowed(:read_storage_disk_path) }
|
|
end
|
|
|
|
context 'admin' do
|
|
let(:current_user) { admin }
|
|
|
|
context 'when admin mode is enabled', :enable_admin_mode do
|
|
it { expect_allowed(:read_storage_disk_path) }
|
|
end
|
|
|
|
context 'when admin mode is disabled' do
|
|
it { expect_disallowed(:read_storage_disk_path) }
|
|
end
|
|
end
|
|
|
|
%w(guest reporter developer maintainer owner).each do |role|
|
|
context role do
|
|
let(:current_user) { send(role) }
|
|
|
|
it { expect_disallowed(:read_storage_disk_path) }
|
|
end
|
|
end
|
|
end
|
|
|
|
context 'alert bot' do
|
|
let(:current_user) { User.alert_bot }
|
|
|
|
it { is_expected.to be_allowed(:reporter_access) }
|
|
|
|
context 'within a private project' do
|
|
let(:project) { private_project }
|
|
|
|
it { is_expected.to be_allowed(:admin_issue) }
|
|
end
|
|
end
|
|
|
|
describe 'set_pipeline_variables' do
|
|
context 'when user is developer' do
|
|
let(:current_user) { developer }
|
|
|
|
context 'when project allows user defined variables' do
|
|
before do
|
|
project.update!(restrict_user_defined_variables: false)
|
|
end
|
|
|
|
it { is_expected.to be_allowed(:set_pipeline_variables) }
|
|
end
|
|
|
|
context 'when project restricts use of user defined variables' do
|
|
before do
|
|
project.update!(restrict_user_defined_variables: true)
|
|
end
|
|
|
|
it { is_expected.not_to be_allowed(:set_pipeline_variables) }
|
|
end
|
|
end
|
|
|
|
context 'when user is maintainer' do
|
|
let(:current_user) { maintainer }
|
|
|
|
context 'when project allows user defined variables' do
|
|
before do
|
|
project.update!(restrict_user_defined_variables: false)
|
|
end
|
|
|
|
it { is_expected.to be_allowed(:set_pipeline_variables) }
|
|
end
|
|
|
|
context 'when project restricts use of user defined variables' do
|
|
before do
|
|
project.update!(restrict_user_defined_variables: true)
|
|
end
|
|
|
|
it { is_expected.to be_allowed(:set_pipeline_variables) }
|
|
end
|
|
end
|
|
end
|
|
|
|
context 'support bot' do
|
|
let(:current_user) { User.support_bot }
|
|
|
|
context 'with service desk disabled' do
|
|
it { expect_allowed(:public_access) }
|
|
it { expect_disallowed(:guest_access, :create_note, :read_project) }
|
|
end
|
|
|
|
context 'with service desk enabled' do
|
|
before do
|
|
allow(project).to receive(:service_desk_enabled?).and_return(true)
|
|
end
|
|
|
|
it { expect_allowed(:reporter_access, :create_note, :read_issue, :read_work_item) }
|
|
|
|
context 'when issues are protected members only' do
|
|
before do
|
|
project.project_feature.update!(issues_access_level: ProjectFeature::PRIVATE)
|
|
end
|
|
|
|
it { expect_allowed(:reporter_access, :create_note, :read_issue, :read_work_item) }
|
|
end
|
|
end
|
|
end
|
|
|
|
context "project bots" do
|
|
let(:project_bot) { create(:user, :project_bot) }
|
|
let(:user) { create(:user) }
|
|
|
|
context "project_bot_access" do
|
|
context "when regular user and part of the project" do
|
|
let(:current_user) { user }
|
|
|
|
before do
|
|
project.add_developer(user)
|
|
end
|
|
|
|
it { is_expected.not_to be_allowed(:project_bot_access)}
|
|
end
|
|
|
|
context "when project bot and not part of the project" do
|
|
let(:current_user) { project_bot }
|
|
|
|
it { is_expected.not_to be_allowed(:project_bot_access)}
|
|
end
|
|
|
|
context "when project bot and part of the project" do
|
|
let(:current_user) { project_bot }
|
|
|
|
before do
|
|
project.add_developer(project_bot)
|
|
end
|
|
|
|
it { is_expected.to be_allowed(:project_bot_access)}
|
|
end
|
|
end
|
|
|
|
context 'with resource access tokens' do
|
|
let(:current_user) { project_bot }
|
|
|
|
before do
|
|
project.add_maintainer(project_bot)
|
|
end
|
|
|
|
it { is_expected.not_to be_allowed(:create_resource_access_tokens)}
|
|
end
|
|
end
|
|
|
|
describe 'read_prometheus_alerts' do
|
|
context 'with admin' do
|
|
let(:current_user) { admin }
|
|
|
|
context 'when admin mode is enabled', :enable_admin_mode do
|
|
it { is_expected.to be_allowed(:read_prometheus_alerts) }
|
|
end
|
|
|
|
context 'when admin mode is disabled' do
|
|
it { is_expected.to be_disallowed(:read_prometheus_alerts) }
|
|
end
|
|
end
|
|
|
|
context 'with owner' do
|
|
let(:current_user) { owner }
|
|
|
|
it { is_expected.to be_allowed(:read_prometheus_alerts) }
|
|
end
|
|
|
|
context 'with maintainer' do
|
|
let(:current_user) { maintainer }
|
|
|
|
it { is_expected.to be_allowed(:read_prometheus_alerts) }
|
|
end
|
|
|
|
context 'with developer' do
|
|
let(:current_user) { developer }
|
|
|
|
it { is_expected.to be_disallowed(:read_prometheus_alerts) }
|
|
end
|
|
|
|
context 'with reporter' do
|
|
let(:current_user) { reporter }
|
|
|
|
it { is_expected.to be_disallowed(:read_prometheus_alerts) }
|
|
end
|
|
|
|
context 'with guest' do
|
|
let(:current_user) { guest }
|
|
|
|
it { is_expected.to be_disallowed(:read_prometheus_alerts) }
|
|
end
|
|
|
|
context 'with anonymous' do
|
|
let(:current_user) { anonymous }
|
|
|
|
it { is_expected.to be_disallowed(:read_prometheus_alerts) }
|
|
end
|
|
end
|
|
|
|
describe 'metrics_dashboard feature' do
|
|
context 'public project' do
|
|
let(:project) { public_project }
|
|
|
|
context 'feature private' do
|
|
context 'with reporter' do
|
|
let(:current_user) { reporter }
|
|
|
|
it { is_expected.to be_allowed(:metrics_dashboard) }
|
|
it { is_expected.to be_allowed(:read_prometheus) }
|
|
it { is_expected.to be_allowed(:read_deployment) }
|
|
it { is_expected.to be_allowed(:read_metrics_user_starred_dashboard) }
|
|
it { is_expected.to be_allowed(:create_metrics_user_starred_dashboard) }
|
|
end
|
|
|
|
context 'with guest' do
|
|
let(:current_user) { guest }
|
|
|
|
it { is_expected.to be_disallowed(:metrics_dashboard) }
|
|
end
|
|
|
|
context 'with anonymous' do
|
|
let(:current_user) { anonymous }
|
|
|
|
it { is_expected.to be_disallowed(:metrics_dashboard) }
|
|
end
|
|
end
|
|
|
|
context 'feature enabled' do
|
|
before do
|
|
project.project_feature.update!(metrics_dashboard_access_level: ProjectFeature::ENABLED)
|
|
end
|
|
|
|
context 'with reporter' do
|
|
let(:current_user) { reporter }
|
|
|
|
it { is_expected.to be_allowed(:metrics_dashboard) }
|
|
it { is_expected.to be_allowed(:read_prometheus) }
|
|
it { is_expected.to be_allowed(:read_deployment) }
|
|
it { is_expected.to be_allowed(:read_metrics_user_starred_dashboard) }
|
|
it { is_expected.to be_allowed(:create_metrics_user_starred_dashboard) }
|
|
end
|
|
|
|
context 'with guest' do
|
|
let(:current_user) { guest }
|
|
|
|
it { is_expected.to be_allowed(:metrics_dashboard) }
|
|
it { is_expected.to be_allowed(:read_prometheus) }
|
|
it { is_expected.to be_allowed(:read_deployment) }
|
|
it { is_expected.to be_allowed(:read_metrics_user_starred_dashboard) }
|
|
it { is_expected.to be_allowed(:create_metrics_user_starred_dashboard) }
|
|
end
|
|
|
|
context 'with anonymous' do
|
|
let(:current_user) { anonymous }
|
|
|
|
it { is_expected.to be_allowed(:metrics_dashboard) }
|
|
it { is_expected.to be_allowed(:read_prometheus) }
|
|
it { is_expected.to be_allowed(:read_deployment) }
|
|
it { is_expected.to be_disallowed(:read_metrics_user_starred_dashboard) }
|
|
it { is_expected.to be_disallowed(:create_metrics_user_starred_dashboard) }
|
|
end
|
|
end
|
|
end
|
|
|
|
context 'internal project' do
|
|
let(:project) { internal_project }
|
|
|
|
context 'feature private' do
|
|
context 'with reporter' do
|
|
let(:current_user) { reporter }
|
|
|
|
it { is_expected.to be_allowed(:metrics_dashboard) }
|
|
it { is_expected.to be_allowed(:read_prometheus) }
|
|
it { is_expected.to be_allowed(:read_deployment) }
|
|
it { is_expected.to be_allowed(:read_metrics_user_starred_dashboard) }
|
|
it { is_expected.to be_allowed(:create_metrics_user_starred_dashboard) }
|
|
end
|
|
|
|
context 'with guest' do
|
|
let(:current_user) { guest }
|
|
|
|
it { is_expected.to be_disallowed(:metrics_dashboard) }
|
|
end
|
|
|
|
context 'with anonymous' do
|
|
let(:current_user) { anonymous }
|
|
|
|
it { is_expected.to be_disallowed(:metrics_dashboard)}
|
|
end
|
|
end
|
|
|
|
context 'feature enabled' do
|
|
before do
|
|
project.project_feature.update!(metrics_dashboard_access_level: ProjectFeature::ENABLED)
|
|
end
|
|
|
|
context 'with reporter' do
|
|
let(:current_user) { reporter }
|
|
|
|
it { is_expected.to be_allowed(:metrics_dashboard) }
|
|
it { is_expected.to be_allowed(:read_prometheus) }
|
|
it { is_expected.to be_allowed(:read_deployment) }
|
|
it { is_expected.to be_allowed(:read_metrics_user_starred_dashboard) }
|
|
it { is_expected.to be_allowed(:create_metrics_user_starred_dashboard) }
|
|
end
|
|
|
|
context 'with guest' do
|
|
let(:current_user) { guest }
|
|
|
|
it { is_expected.to be_allowed(:metrics_dashboard) }
|
|
it { is_expected.to be_allowed(:read_prometheus) }
|
|
it { is_expected.to be_allowed(:read_deployment) }
|
|
it { is_expected.to be_allowed(:read_metrics_user_starred_dashboard) }
|
|
it { is_expected.to be_allowed(:create_metrics_user_starred_dashboard) }
|
|
end
|
|
|
|
context 'with anonymous' do
|
|
let(:current_user) { anonymous }
|
|
|
|
it { is_expected.to be_disallowed(:metrics_dashboard) }
|
|
end
|
|
end
|
|
end
|
|
|
|
context 'private project' do
|
|
let(:project) { private_project }
|
|
|
|
context 'feature private' do
|
|
context 'with reporter' do
|
|
let(:current_user) { reporter }
|
|
|
|
it { is_expected.to be_allowed(:metrics_dashboard) }
|
|
it { is_expected.to be_allowed(:read_prometheus) }
|
|
it { is_expected.to be_allowed(:read_deployment) }
|
|
it { is_expected.to be_allowed(:read_metrics_user_starred_dashboard) }
|
|
it { is_expected.to be_allowed(:create_metrics_user_starred_dashboard) }
|
|
end
|
|
|
|
context 'with guest' do
|
|
let(:current_user) { guest }
|
|
|
|
it { is_expected.to be_disallowed(:metrics_dashboard) }
|
|
end
|
|
|
|
context 'with anonymous' do
|
|
let(:current_user) { anonymous }
|
|
|
|
it { is_expected.to be_disallowed(:metrics_dashboard) }
|
|
end
|
|
end
|
|
|
|
context 'feature enabled' do
|
|
context 'with reporter' do
|
|
let(:current_user) { reporter }
|
|
|
|
it { is_expected.to be_allowed(:metrics_dashboard) }
|
|
it { is_expected.to be_allowed(:read_prometheus) }
|
|
it { is_expected.to be_allowed(:read_deployment) }
|
|
it { is_expected.to be_allowed(:read_metrics_user_starred_dashboard) }
|
|
it { is_expected.to be_allowed(:create_metrics_user_starred_dashboard) }
|
|
end
|
|
|
|
context 'with guest' do
|
|
let(:current_user) { guest }
|
|
|
|
it { is_expected.to be_disallowed(:metrics_dashboard) }
|
|
end
|
|
|
|
context 'with anonymous' do
|
|
let(:current_user) { anonymous }
|
|
|
|
it { is_expected.to be_disallowed(:metrics_dashboard) }
|
|
end
|
|
end
|
|
end
|
|
|
|
context 'feature disabled' do
|
|
before do
|
|
project.project_feature.update!(metrics_dashboard_access_level: ProjectFeature::DISABLED)
|
|
end
|
|
|
|
context 'with reporter' do
|
|
let(:current_user) { reporter }
|
|
|
|
it { is_expected.to be_disallowed(:metrics_dashboard) }
|
|
end
|
|
|
|
context 'with guest' do
|
|
let(:current_user) { guest }
|
|
|
|
it { is_expected.to be_disallowed(:metrics_dashboard) }
|
|
end
|
|
|
|
context 'with anonymous' do
|
|
let(:current_user) { anonymous }
|
|
|
|
it { is_expected.to be_disallowed(:metrics_dashboard) }
|
|
end
|
|
end
|
|
end
|
|
|
|
context 'deploy key access' do
|
|
context 'private project' do
|
|
let(:project) { private_project }
|
|
let!(:deploy_key) { create(:deploy_key, user: owner) }
|
|
|
|
subject { described_class.new(deploy_key, project) }
|
|
|
|
context 'when a read deploy key is enabled in the project' do
|
|
let!(:deploy_keys_project) { create(:deploy_keys_project, project: project, deploy_key: deploy_key) }
|
|
|
|
it { is_expected.to be_allowed(:download_code) }
|
|
it { is_expected.to be_disallowed(:push_code) }
|
|
it { is_expected.to be_disallowed(:read_project) }
|
|
end
|
|
|
|
context 'when a write deploy key is enabled in the project' do
|
|
let!(:deploy_keys_project) { create(:deploy_keys_project, :write_access, project: project, deploy_key: deploy_key) }
|
|
|
|
it { is_expected.to be_allowed(:download_code) }
|
|
it { is_expected.to be_allowed(:push_code) }
|
|
it { is_expected.to be_disallowed(:read_project) }
|
|
end
|
|
|
|
context 'when the deploy key is not enabled in the project' do
|
|
it { is_expected.to be_disallowed(:download_code) }
|
|
it { is_expected.to be_disallowed(:push_code) }
|
|
it { is_expected.to be_disallowed(:read_project) }
|
|
end
|
|
end
|
|
end
|
|
|
|
context 'deploy token access' do
|
|
let!(:project_deploy_token) do
|
|
create(:project_deploy_token, project: project, deploy_token: deploy_token)
|
|
end
|
|
|
|
subject { described_class.new(deploy_token, project) }
|
|
|
|
context 'private project' do
|
|
let(:project) { private_project }
|
|
|
|
context 'a deploy token with read_registry scope' do
|
|
let(:deploy_token) { create(:deploy_token, read_registry: true, write_registry: false) }
|
|
|
|
it { is_expected.to be_allowed(:read_container_image) }
|
|
it { is_expected.to be_disallowed(:create_container_image) }
|
|
|
|
context 'with registry disabled' do
|
|
include_context 'registry disabled via project features'
|
|
|
|
it { is_expected.to be_disallowed(:read_container_image) }
|
|
it { is_expected.to be_disallowed(:create_container_image) }
|
|
end
|
|
end
|
|
|
|
context 'a deploy token with write_registry scope' do
|
|
let(:deploy_token) { create(:deploy_token, read_registry: false, write_registry: true) }
|
|
|
|
it { is_expected.to be_disallowed(:read_container_image) }
|
|
it { is_expected.to be_allowed(:create_container_image) }
|
|
|
|
context 'with registry disabled' do
|
|
include_context 'registry disabled via project features'
|
|
|
|
it { is_expected.to be_disallowed(:read_container_image) }
|
|
it { is_expected.to be_disallowed(:create_container_image) }
|
|
end
|
|
end
|
|
|
|
context 'a deploy token with no registry scope' do
|
|
let(:deploy_token) { create(:deploy_token, read_registry: false, write_registry: false) }
|
|
|
|
it { is_expected.to be_disallowed(:read_container_image) }
|
|
it { is_expected.to be_disallowed(:create_container_image) }
|
|
end
|
|
|
|
context 'a deploy token with read_package_registry scope' do
|
|
let(:deploy_token) { create(:deploy_token, read_repository: false, read_registry: false, read_package_registry: true) }
|
|
|
|
it { is_expected.to be_allowed(:read_project) }
|
|
it { is_expected.to be_allowed(:read_package) }
|
|
it { is_expected.to be_disallowed(:create_package) }
|
|
|
|
it_behaves_like 'package access with repository disabled'
|
|
end
|
|
|
|
context 'a deploy token with write_package_registry scope' do
|
|
let(:deploy_token) { create(:deploy_token, read_repository: false, read_registry: false, write_package_registry: true) }
|
|
|
|
it { is_expected.to be_allowed(:create_package) }
|
|
it { is_expected.to be_allowed(:read_package) }
|
|
it { is_expected.to be_allowed(:read_project) }
|
|
it { is_expected.to be_disallowed(:destroy_package) }
|
|
|
|
it_behaves_like 'package access with repository disabled'
|
|
end
|
|
end
|
|
|
|
context 'public project' do
|
|
let(:project) { public_project }
|
|
|
|
context 'a deploy token with read_registry scope' do
|
|
let(:deploy_token) { create(:deploy_token, read_registry: true, write_registry: false) }
|
|
|
|
it { is_expected.to be_allowed(:read_container_image) }
|
|
it { is_expected.to be_disallowed(:create_container_image) }
|
|
|
|
context 'with registry disabled' do
|
|
include_context 'registry disabled via project features'
|
|
|
|
it { is_expected.to be_disallowed(:read_container_image) }
|
|
it { is_expected.to be_disallowed(:create_container_image) }
|
|
end
|
|
|
|
context 'with registry private' do
|
|
include_context 'registry set to private via project features'
|
|
|
|
it { is_expected.to be_allowed(:read_container_image) }
|
|
it { is_expected.to be_disallowed(:create_container_image) }
|
|
end
|
|
end
|
|
|
|
context 'a deploy token with write_registry scope' do
|
|
let(:deploy_token) { create(:deploy_token, read_registry: false, write_registry: true) }
|
|
|
|
it { is_expected.to be_allowed(:read_container_image) }
|
|
it { is_expected.to be_allowed(:create_container_image) }
|
|
|
|
context 'with registry disabled' do
|
|
include_context 'registry disabled via project features'
|
|
|
|
it { is_expected.to be_disallowed(:read_container_image) }
|
|
it { is_expected.to be_disallowed(:create_container_image) }
|
|
end
|
|
|
|
context 'with registry private' do
|
|
include_context 'registry set to private via project features'
|
|
|
|
it { is_expected.to be_allowed(:read_container_image) }
|
|
it { is_expected.to be_allowed(:create_container_image) }
|
|
end
|
|
end
|
|
|
|
context 'a deploy token with no registry scope' do
|
|
let(:deploy_token) { create(:deploy_token, read_registry: false, write_registry: false) }
|
|
|
|
it { is_expected.to be_disallowed(:read_container_image) }
|
|
it { is_expected.to be_disallowed(:create_container_image) }
|
|
end
|
|
end
|
|
end
|
|
|
|
describe 'create_web_ide_terminal' do
|
|
context 'with admin' do
|
|
let(:current_user) { admin }
|
|
|
|
context 'when admin mode enabled', :enable_admin_mode do
|
|
it { is_expected.to be_allowed(:create_web_ide_terminal) }
|
|
end
|
|
|
|
context 'when admin mode disabled' do
|
|
it { is_expected.to be_disallowed(:create_web_ide_terminal) }
|
|
end
|
|
end
|
|
|
|
context 'with owner' do
|
|
let(:current_user) { owner }
|
|
|
|
it { is_expected.to be_allowed(:create_web_ide_terminal) }
|
|
end
|
|
|
|
context 'with maintainer' do
|
|
let(:current_user) { maintainer }
|
|
|
|
it { is_expected.to be_allowed(:create_web_ide_terminal) }
|
|
end
|
|
|
|
context 'with developer' do
|
|
let(:current_user) { developer }
|
|
|
|
it { is_expected.to be_disallowed(:create_web_ide_terminal) }
|
|
end
|
|
|
|
context 'with reporter' do
|
|
let(:current_user) { reporter }
|
|
|
|
it { is_expected.to be_disallowed(:create_web_ide_terminal) }
|
|
end
|
|
|
|
context 'with guest' do
|
|
let(:current_user) { guest }
|
|
|
|
it { is_expected.to be_disallowed(:create_web_ide_terminal) }
|
|
end
|
|
|
|
context 'with non member' do
|
|
let(:current_user) { non_member }
|
|
|
|
it { is_expected.to be_disallowed(:create_web_ide_terminal) }
|
|
end
|
|
|
|
context 'with anonymous' do
|
|
let(:current_user) { anonymous }
|
|
|
|
it { is_expected.to be_disallowed(:create_web_ide_terminal) }
|
|
end
|
|
end
|
|
|
|
describe 'read_repository_graphs' do
|
|
let(:current_user) { guest }
|
|
|
|
before do
|
|
allow(subject).to receive(:allowed?).with(:read_repository_graphs).and_call_original
|
|
allow(subject).to receive(:allowed?).with(:download_code).and_return(can_download_code)
|
|
end
|
|
|
|
context 'when user can download_code' do
|
|
let(:can_download_code) { true }
|
|
|
|
it { is_expected.to be_allowed(:read_repository_graphs) }
|
|
end
|
|
|
|
context 'when user cannot download_code' do
|
|
let(:can_download_code) { false }
|
|
|
|
it { is_expected.to be_disallowed(:read_repository_graphs) }
|
|
end
|
|
end
|
|
|
|
context 'security configuration feature' do
|
|
%w(guest reporter).each do |role|
|
|
context role do
|
|
let(:current_user) { send(role) }
|
|
|
|
it 'prevents reading security configuration' do
|
|
expect_disallowed(:read_security_configuration)
|
|
end
|
|
end
|
|
end
|
|
|
|
%w(developer maintainer owner).each do |role|
|
|
context role do
|
|
let(:current_user) { send(role) }
|
|
|
|
it 'allows reading security configuration' do
|
|
expect_allowed(:read_security_configuration)
|
|
end
|
|
end
|
|
end
|
|
end
|
|
|
|
context 'infrastructure google cloud feature' do
|
|
%w(guest reporter developer).each do |role|
|
|
context role do
|
|
let(:current_user) { send(role) }
|
|
|
|
it 'disallows managing google cloud' do
|
|
expect_disallowed(:admin_project_google_cloud)
|
|
end
|
|
end
|
|
end
|
|
|
|
%w(maintainer owner).each do |role|
|
|
context role do
|
|
let(:current_user) { send(role) }
|
|
|
|
it 'allows managing google cloud' do
|
|
expect_allowed(:admin_project_google_cloud)
|
|
end
|
|
end
|
|
end
|
|
end
|
|
|
|
describe 'design permissions' do
|
|
include DesignManagementTestHelpers
|
|
|
|
let(:current_user) { guest }
|
|
|
|
let(:design_permissions) do
|
|
%i[read_design_activity read_design]
|
|
end
|
|
|
|
context 'when design management is not available' do
|
|
before do
|
|
enable_design_management(false)
|
|
end
|
|
|
|
it { is_expected.not_to be_allowed(*design_permissions) }
|
|
end
|
|
|
|
context 'when design management is available' do
|
|
before do
|
|
enable_design_management
|
|
end
|
|
|
|
it { is_expected.to be_allowed(*design_permissions) }
|
|
end
|
|
end
|
|
|
|
describe 'read_build_report_results' do
|
|
let(:current_user) { guest }
|
|
|
|
before do
|
|
allow(subject).to receive(:allowed?).with(:read_build_report_results).and_call_original
|
|
allow(subject).to receive(:allowed?).with(:read_build).and_return(can_read_build)
|
|
allow(subject).to receive(:allowed?).with(:read_pipeline).and_return(can_read_pipeline)
|
|
end
|
|
|
|
context 'when user can read_build and read_pipeline' do
|
|
let(:can_read_build) { true }
|
|
let(:can_read_pipeline) { true }
|
|
|
|
it { is_expected.to be_allowed(:read_build_report_results) }
|
|
end
|
|
|
|
context 'when user can read_build but cannot read_pipeline' do
|
|
let(:can_read_build) { true }
|
|
let(:can_read_pipeline) { false }
|
|
|
|
it { is_expected.to be_disallowed(:read_build_report_results) }
|
|
end
|
|
|
|
context 'when user cannot read_build but can read_pipeline' do
|
|
let(:can_read_build) { false }
|
|
let(:can_read_pipeline) { true }
|
|
|
|
it { is_expected.to be_disallowed(:read_build_report_results) }
|
|
end
|
|
|
|
context 'when user cannot read_build and cannot read_pipeline' do
|
|
let(:can_read_build) { false }
|
|
let(:can_read_pipeline) { false }
|
|
|
|
it { is_expected.to be_disallowed(:read_build_report_results) }
|
|
end
|
|
end
|
|
|
|
describe 'read_package' do
|
|
context 'with admin' do
|
|
let(:current_user) { admin }
|
|
|
|
it { is_expected.to be_allowed(:read_package) }
|
|
|
|
it_behaves_like 'package access with repository disabled'
|
|
end
|
|
|
|
context 'with owner' do
|
|
let(:current_user) { owner }
|
|
|
|
it { is_expected.to be_allowed(:read_package) }
|
|
end
|
|
|
|
context 'with maintainer' do
|
|
let(:current_user) { maintainer }
|
|
|
|
it { is_expected.to be_allowed(:read_package) }
|
|
end
|
|
|
|
context 'with developer' do
|
|
let(:current_user) { developer }
|
|
|
|
it { is_expected.to be_allowed(:read_package) }
|
|
end
|
|
|
|
context 'with reporter' do
|
|
let(:current_user) { reporter }
|
|
|
|
it { is_expected.to be_allowed(:read_package) }
|
|
end
|
|
|
|
context 'with guest' do
|
|
let(:current_user) { guest }
|
|
|
|
it { is_expected.to be_allowed(:read_package) }
|
|
end
|
|
|
|
context 'with non member' do
|
|
let(:current_user) { non_member }
|
|
|
|
it { is_expected.to be_allowed(:read_package) }
|
|
end
|
|
|
|
context 'with anonymous' do
|
|
let(:current_user) { anonymous }
|
|
|
|
it { is_expected.to be_allowed(:read_package) }
|
|
end
|
|
end
|
|
|
|
describe 'admin_package' do
|
|
context 'with admin' do
|
|
let(:current_user) { admin }
|
|
|
|
context 'when admin mode enabled', :enable_admin_mode do
|
|
it { is_expected.to be_allowed(:admin_package) }
|
|
end
|
|
|
|
context 'when admin mode disabled' do
|
|
it { is_expected.to be_disallowed(:admin_package) }
|
|
end
|
|
end
|
|
|
|
%i[owner maintainer].each do |role|
|
|
context "with #{role}" do
|
|
let(:current_user) { public_send(role) }
|
|
|
|
it { is_expected.to be_allowed(:admin_package) }
|
|
end
|
|
end
|
|
|
|
%i[developer reporter guest non_member anonymous].each do |role|
|
|
context "with #{role}" do
|
|
let(:current_user) { public_send(role) }
|
|
|
|
it { is_expected.to be_disallowed(:admin_package) }
|
|
end
|
|
end
|
|
end
|
|
|
|
describe 'view_package_registry_project_settings' do
|
|
context 'with registry enabled' do
|
|
before do
|
|
stub_config(registry: { enabled: true })
|
|
end
|
|
|
|
context 'with an admin user' do
|
|
let(:current_user) { admin }
|
|
|
|
context 'when admin mode enabled', :enable_admin_mode do
|
|
it { is_expected.to be_allowed(:view_package_registry_project_settings) }
|
|
end
|
|
|
|
context 'when admin mode disabled' do
|
|
it { is_expected.to be_disallowed(:view_package_registry_project_settings) }
|
|
end
|
|
end
|
|
|
|
%i[owner maintainer].each do |role|
|
|
context "with #{role}" do
|
|
let(:current_user) { public_send(role) }
|
|
|
|
it { is_expected.to be_allowed(:view_package_registry_project_settings) }
|
|
end
|
|
end
|
|
|
|
%i[developer reporter guest non_member anonymous].each do |role|
|
|
context "with #{role}" do
|
|
let(:current_user) { public_send(role) }
|
|
|
|
it { is_expected.to be_disallowed(:view_package_registry_project_settings) }
|
|
end
|
|
end
|
|
end
|
|
|
|
context 'with registry disabled' do
|
|
before do
|
|
stub_config(registry: { enabled: false })
|
|
end
|
|
|
|
context 'with admin user' do
|
|
let(:current_user) { admin }
|
|
|
|
context 'when admin mode enabled', :enable_admin_mode do
|
|
it { is_expected.to be_disallowed(:view_package_registry_project_settings) }
|
|
end
|
|
|
|
context 'when admin mode disabled' do
|
|
it { is_expected.to be_disallowed(:view_package_registry_project_settings) }
|
|
end
|
|
end
|
|
|
|
%i[owner maintainer developer reporter guest non_member anonymous].each do |role|
|
|
context "with #{role}" do
|
|
let(:current_user) { public_send(role) }
|
|
|
|
it { is_expected.to be_disallowed(:view_package_registry_project_settings) }
|
|
end
|
|
end
|
|
end
|
|
end
|
|
|
|
describe 'read_feature_flag' do
|
|
subject { described_class.new(current_user, project) }
|
|
|
|
context 'with maintainer' do
|
|
let(:current_user) { maintainer }
|
|
|
|
context 'when repository is available' do
|
|
it { is_expected.to be_allowed(:read_feature_flag) }
|
|
end
|
|
|
|
context 'when repository is disabled' do
|
|
before do
|
|
project.project_feature.update!(
|
|
merge_requests_access_level: ProjectFeature::DISABLED,
|
|
builds_access_level: ProjectFeature::DISABLED,
|
|
repository_access_level: ProjectFeature::DISABLED
|
|
)
|
|
end
|
|
|
|
it { is_expected.to be_disallowed(:read_feature_flag) }
|
|
end
|
|
end
|
|
|
|
context 'with developer' do
|
|
let(:current_user) { developer }
|
|
|
|
context 'when repository is available' do
|
|
it { is_expected.to be_allowed(:read_feature_flag) }
|
|
end
|
|
end
|
|
|
|
context 'with reporter' do
|
|
let(:current_user) { reporter }
|
|
|
|
context 'when repository is available' do
|
|
it { is_expected.to be_disallowed(:read_feature_flag) }
|
|
end
|
|
end
|
|
end
|
|
|
|
describe 'read_analytics' do
|
|
context 'anonymous user' do
|
|
let(:current_user) { anonymous }
|
|
|
|
it { is_expected.to be_allowed(:read_analytics) }
|
|
end
|
|
|
|
context 'with various analytics features' do
|
|
let_it_be(:project_with_analytics_disabled) { create(:project, :analytics_disabled) }
|
|
let_it_be(:project_with_analytics_private) { create(:project, :analytics_private) }
|
|
let_it_be(:project_with_analytics_enabled) { create(:project, :analytics_enabled) }
|
|
|
|
before do
|
|
project_with_analytics_disabled.add_guest(guest)
|
|
project_with_analytics_private.add_guest(guest)
|
|
project_with_analytics_enabled.add_guest(guest)
|
|
|
|
project_with_analytics_disabled.add_reporter(reporter)
|
|
project_with_analytics_private.add_reporter(reporter)
|
|
project_with_analytics_enabled.add_reporter(reporter)
|
|
|
|
project_with_analytics_disabled.add_developer(developer)
|
|
project_with_analytics_private.add_developer(developer)
|
|
project_with_analytics_enabled.add_developer(developer)
|
|
end
|
|
|
|
context 'when analytics is disabled for the project' do
|
|
let(:project) { project_with_analytics_disabled }
|
|
|
|
context 'for guest user' do
|
|
let(:current_user) { guest }
|
|
|
|
it { is_expected.to be_disallowed(:read_cycle_analytics) }
|
|
it { is_expected.to be_disallowed(:read_insights) }
|
|
it { is_expected.to be_disallowed(:read_repository_graphs) }
|
|
it { is_expected.to be_disallowed(:read_ci_cd_analytics) }
|
|
end
|
|
|
|
context 'for reporter user' do
|
|
let(:current_user) { reporter }
|
|
|
|
it { is_expected.to be_disallowed(:read_cycle_analytics) }
|
|
it { is_expected.to be_disallowed(:read_insights) }
|
|
it { is_expected.to be_disallowed(:read_repository_graphs) }
|
|
it { is_expected.to be_disallowed(:read_ci_cd_analytics) }
|
|
end
|
|
|
|
context 'for developer' do
|
|
let(:current_user) { developer }
|
|
|
|
it { is_expected.to be_disallowed(:read_cycle_analytics) }
|
|
it { is_expected.to be_disallowed(:read_insights) }
|
|
it { is_expected.to be_disallowed(:read_repository_graphs) }
|
|
it { is_expected.to be_disallowed(:read_ci_cd_analytics) }
|
|
end
|
|
end
|
|
|
|
context 'when analytics is private for the project' do
|
|
let(:project) { project_with_analytics_private }
|
|
|
|
context 'for guest user' do
|
|
let(:current_user) { guest }
|
|
|
|
it { is_expected.to be_allowed(:read_cycle_analytics) }
|
|
it { is_expected.to be_allowed(:read_insights) }
|
|
it { is_expected.to be_disallowed(:read_repository_graphs) }
|
|
it { is_expected.to be_disallowed(:read_ci_cd_analytics) }
|
|
end
|
|
|
|
context 'for reporter user' do
|
|
let(:current_user) { reporter }
|
|
|
|
it { is_expected.to be_allowed(:read_cycle_analytics) }
|
|
it { is_expected.to be_allowed(:read_insights) }
|
|
it { is_expected.to be_allowed(:read_repository_graphs) }
|
|
it { is_expected.to be_allowed(:read_ci_cd_analytics) }
|
|
end
|
|
|
|
context 'for developer' do
|
|
let(:current_user) { developer }
|
|
|
|
it { is_expected.to be_allowed(:read_cycle_analytics) }
|
|
it { is_expected.to be_allowed(:read_insights) }
|
|
it { is_expected.to be_allowed(:read_repository_graphs) }
|
|
it { is_expected.to be_allowed(:read_ci_cd_analytics) }
|
|
end
|
|
end
|
|
|
|
context 'when analytics is enabled for the project' do
|
|
let(:project) { project_with_analytics_enabled }
|
|
|
|
context 'for guest user' do
|
|
let(:current_user) { guest }
|
|
|
|
it { is_expected.to be_allowed(:read_cycle_analytics) }
|
|
it { is_expected.to be_allowed(:read_insights) }
|
|
it { is_expected.to be_disallowed(:read_repository_graphs) }
|
|
it { is_expected.to be_disallowed(:read_ci_cd_analytics) }
|
|
end
|
|
|
|
context 'for reporter user' do
|
|
let(:current_user) { reporter }
|
|
|
|
it { is_expected.to be_allowed(:read_cycle_analytics) }
|
|
it { is_expected.to be_allowed(:read_insights) }
|
|
it { is_expected.to be_allowed(:read_repository_graphs) }
|
|
it { is_expected.to be_allowed(:read_ci_cd_analytics) }
|
|
end
|
|
|
|
context 'for developer' do
|
|
let(:current_user) { developer }
|
|
|
|
it { is_expected.to be_allowed(:read_cycle_analytics) }
|
|
it { is_expected.to be_allowed(:read_insights) }
|
|
it { is_expected.to be_allowed(:read_repository_graphs) }
|
|
it { is_expected.to be_allowed(:read_ci_cd_analytics) }
|
|
end
|
|
end
|
|
end
|
|
|
|
context 'project member' do
|
|
let(:project) { private_project }
|
|
|
|
%w(guest reporter developer maintainer).each do |role|
|
|
context role do
|
|
let(:current_user) { send(role) }
|
|
|
|
it { is_expected.to be_allowed(:read_analytics) }
|
|
|
|
context "without access to Analytics" do
|
|
before do
|
|
project.project_feature.update!(analytics_access_level: ProjectFeature::DISABLED)
|
|
end
|
|
|
|
it { is_expected.to be_disallowed(:read_analytics) }
|
|
end
|
|
end
|
|
end
|
|
end
|
|
end
|
|
|
|
describe 'read_ci_cd_analytics' do
|
|
context 'public project' do
|
|
let(:project) { create(:project, :public, :analytics_enabled) }
|
|
let(:current_user) { create(:user) }
|
|
|
|
context 'when public pipelines are disabled for the project' do
|
|
before do
|
|
project.update!(public_builds: false)
|
|
end
|
|
|
|
context 'project member' do
|
|
%w(guest reporter developer maintainer).each do |role|
|
|
context role do
|
|
before do
|
|
project.add_user(current_user, role.to_sym)
|
|
end
|
|
|
|
if role == 'guest'
|
|
it { is_expected.to be_disallowed(:read_ci_cd_analytics) }
|
|
else
|
|
it { is_expected.to be_allowed(:read_ci_cd_analytics) }
|
|
end
|
|
end
|
|
end
|
|
end
|
|
|
|
context 'non member' do
|
|
let(:current_user) { non_member }
|
|
|
|
it { is_expected.to be_disallowed(:read_ci_cd_analytics) }
|
|
end
|
|
|
|
context 'anonymous' do
|
|
let(:current_user) { anonymous }
|
|
|
|
it { is_expected.to be_disallowed(:read_ci_cd_analytics) }
|
|
end
|
|
end
|
|
|
|
context 'when public pipelines are enabled for the project' do
|
|
before do
|
|
project.update!(public_builds: true)
|
|
end
|
|
|
|
context 'project member' do
|
|
%w(guest reporter developer maintainer).each do |role|
|
|
context role do
|
|
before do
|
|
project.add_user(current_user, role.to_sym)
|
|
end
|
|
|
|
it { is_expected.to be_allowed(:read_ci_cd_analytics) }
|
|
end
|
|
end
|
|
end
|
|
|
|
context 'non member' do
|
|
let(:current_user) { non_member }
|
|
|
|
it { is_expected.to be_allowed(:read_ci_cd_analytics) }
|
|
end
|
|
|
|
context 'anonymous' do
|
|
let(:current_user) { anonymous }
|
|
|
|
it { is_expected.to be_allowed(:read_ci_cd_analytics) }
|
|
end
|
|
end
|
|
end
|
|
|
|
context 'private project' do
|
|
let(:project) { create(:project, :private, :analytics_enabled) }
|
|
let(:current_user) { create(:user) }
|
|
|
|
context 'project member' do
|
|
%w(guest reporter developer maintainer).each do |role|
|
|
context role do
|
|
before do
|
|
project.add_user(current_user, role.to_sym)
|
|
end
|
|
|
|
if role == 'guest'
|
|
it { is_expected.to be_disallowed(:read_ci_cd_analytics) }
|
|
else
|
|
it { is_expected.to be_allowed(:read_ci_cd_analytics) }
|
|
end
|
|
end
|
|
end
|
|
end
|
|
|
|
context 'non member' do
|
|
let(:current_user) { non_member }
|
|
|
|
it { is_expected.to be_disallowed(:read_ci_cd_analytics) }
|
|
end
|
|
|
|
context 'anonymous' do
|
|
let(:current_user) { anonymous }
|
|
|
|
it { is_expected.to be_disallowed(:read_ci_cd_analytics) }
|
|
end
|
|
end
|
|
end
|
|
|
|
it_behaves_like 'Self-managed Core resource access tokens'
|
|
|
|
describe 'operations feature' do
|
|
using RSpec::Parameterized::TableSyntax
|
|
|
|
let(:guest_operations_permissions) { [:read_environment, :read_deployment] }
|
|
|
|
let(:developer_operations_permissions) do
|
|
guest_operations_permissions + [
|
|
:read_feature_flag, :read_sentry_issue, :read_alert_management_alert, :read_terraform_state,
|
|
:metrics_dashboard, :read_pod_logs, :read_prometheus, :create_feature_flag,
|
|
:create_environment, :create_deployment, :update_feature_flag, :update_environment,
|
|
:update_sentry_issue, :update_alert_management_alert, :update_deployment,
|
|
:destroy_feature_flag, :destroy_environment, :admin_feature_flag
|
|
]
|
|
end
|
|
|
|
let(:maintainer_operations_permissions) do
|
|
developer_operations_permissions + [
|
|
:read_cluster, :create_cluster, :update_cluster, :admin_environment,
|
|
:admin_cluster, :admin_terraform_state, :admin_deployment
|
|
]
|
|
end
|
|
|
|
where(:project_visibility, :access_level, :role, :allowed) do
|
|
:public | ProjectFeature::ENABLED | :maintainer | true
|
|
:public | ProjectFeature::ENABLED | :developer | true
|
|
:public | ProjectFeature::ENABLED | :guest | true
|
|
:public | ProjectFeature::ENABLED | :anonymous | true
|
|
:public | ProjectFeature::PRIVATE | :maintainer | true
|
|
:public | ProjectFeature::PRIVATE | :developer | true
|
|
:public | ProjectFeature::PRIVATE | :guest | true
|
|
:public | ProjectFeature::PRIVATE | :anonymous | false
|
|
:public | ProjectFeature::DISABLED | :maintainer | false
|
|
:public | ProjectFeature::DISABLED | :developer | false
|
|
:public | ProjectFeature::DISABLED | :guest | false
|
|
:public | ProjectFeature::DISABLED | :anonymous | false
|
|
:internal | ProjectFeature::ENABLED | :maintainer | true
|
|
:internal | ProjectFeature::ENABLED | :developer | true
|
|
:internal | ProjectFeature::ENABLED | :guest | true
|
|
:internal | ProjectFeature::ENABLED | :anonymous | false
|
|
:internal | ProjectFeature::PRIVATE | :maintainer | true
|
|
:internal | ProjectFeature::PRIVATE | :developer | true
|
|
:internal | ProjectFeature::PRIVATE | :guest | true
|
|
:internal | ProjectFeature::PRIVATE | :anonymous | false
|
|
:internal | ProjectFeature::DISABLED | :maintainer | false
|
|
:internal | ProjectFeature::DISABLED | :developer | false
|
|
:internal | ProjectFeature::DISABLED | :guest | false
|
|
:internal | ProjectFeature::DISABLED | :anonymous | false
|
|
:private | ProjectFeature::ENABLED | :maintainer | true
|
|
:private | ProjectFeature::ENABLED | :developer | true
|
|
:private | ProjectFeature::ENABLED | :guest | false
|
|
:private | ProjectFeature::ENABLED | :anonymous | false
|
|
:private | ProjectFeature::PRIVATE | :maintainer | true
|
|
:private | ProjectFeature::PRIVATE | :developer | true
|
|
:private | ProjectFeature::PRIVATE | :guest | false
|
|
:private | ProjectFeature::PRIVATE | :anonymous | false
|
|
:private | ProjectFeature::DISABLED | :maintainer | false
|
|
:private | ProjectFeature::DISABLED | :developer | false
|
|
:private | ProjectFeature::DISABLED | :guest | false
|
|
:private | ProjectFeature::DISABLED | :anonymous | false
|
|
end
|
|
|
|
with_them do
|
|
let(:current_user) { user_subject(role) }
|
|
let(:project) { project_subject(project_visibility) }
|
|
|
|
it 'allows/disallows the abilities based on the operation feature access level' do
|
|
project.project_feature.update!(operations_access_level: access_level)
|
|
|
|
if allowed
|
|
expect_allowed(*permissions_abilities(role))
|
|
else
|
|
expect_disallowed(*permissions_abilities(role))
|
|
end
|
|
end
|
|
|
|
def project_subject(project_type)
|
|
case project_type
|
|
when :public
|
|
public_project
|
|
when :internal
|
|
internal_project
|
|
else
|
|
private_project
|
|
end
|
|
end
|
|
|
|
def user_subject(role)
|
|
case role
|
|
when :maintainer
|
|
maintainer
|
|
when :developer
|
|
developer
|
|
when :guest
|
|
guest
|
|
when :anonymous
|
|
anonymous
|
|
end
|
|
end
|
|
|
|
def permissions_abilities(role)
|
|
case role
|
|
when :maintainer
|
|
maintainer_operations_permissions
|
|
when :developer
|
|
developer_operations_permissions
|
|
else
|
|
guest_operations_permissions
|
|
end
|
|
end
|
|
end
|
|
end
|
|
|
|
describe 'access_security_and_compliance' do
|
|
context 'when the "Security & Compliance" is enabled' do
|
|
before do
|
|
project.project_feature.update!(security_and_compliance_access_level: Featurable::PRIVATE)
|
|
end
|
|
|
|
%w[owner maintainer developer].each do |role|
|
|
context "when the role is #{role}" do
|
|
let(:current_user) { public_send(role) }
|
|
|
|
it { is_expected.to be_allowed(:access_security_and_compliance) }
|
|
end
|
|
end
|
|
|
|
context 'with admin' do
|
|
let(:current_user) { admin }
|
|
|
|
context 'when admin mode enabled', :enable_admin_mode do
|
|
it { is_expected.to be_allowed(:access_security_and_compliance) }
|
|
end
|
|
|
|
context 'when admin mode disabled' do
|
|
it { is_expected.to be_disallowed(:access_security_and_compliance) }
|
|
end
|
|
end
|
|
|
|
%w[reporter guest].each do |role|
|
|
context "when the role is #{role}" do
|
|
let(:current_user) { public_send(role) }
|
|
|
|
it { is_expected.to be_disallowed(:access_security_and_compliance) }
|
|
end
|
|
end
|
|
|
|
context 'with non member' do
|
|
let(:current_user) { non_member }
|
|
|
|
it { is_expected.to be_disallowed(:access_security_and_compliance) }
|
|
end
|
|
|
|
context 'with anonymous' do
|
|
let(:current_user) { anonymous }
|
|
|
|
it { is_expected.to be_disallowed(:access_security_and_compliance) }
|
|
end
|
|
end
|
|
|
|
context 'when the "Security & Compliance" is not enabled' do
|
|
before do
|
|
project.project_feature.update!(security_and_compliance_access_level: Featurable::DISABLED)
|
|
end
|
|
|
|
%w[owner maintainer developer reporter guest].each do |role|
|
|
context "when the role is #{role}" do
|
|
let(:current_user) { public_send(role) }
|
|
|
|
it { is_expected.to be_disallowed(:access_security_and_compliance) }
|
|
end
|
|
end
|
|
|
|
context 'with admin' do
|
|
let(:current_user) { admin }
|
|
|
|
context 'when admin mode enabled', :enable_admin_mode do
|
|
it { is_expected.to be_disallowed(:access_security_and_compliance) }
|
|
end
|
|
|
|
context 'when admin mode disabled' do
|
|
it { is_expected.to be_disallowed(:access_security_and_compliance) }
|
|
end
|
|
end
|
|
|
|
context 'with non member' do
|
|
let(:current_user) { non_member }
|
|
|
|
it { is_expected.to be_disallowed(:access_security_and_compliance) }
|
|
end
|
|
|
|
context 'with anonymous' do
|
|
let(:current_user) { anonymous }
|
|
|
|
it { is_expected.to be_disallowed(:access_security_and_compliance) }
|
|
end
|
|
end
|
|
end
|
|
|
|
describe 'when user is authenticated via CI_JOB_TOKEN', :request_store do
|
|
using RSpec::Parameterized::TableSyntax
|
|
|
|
where(:project_visibility, :user_role, :external_user, :scope_project_type, :token_scope_enabled, :result) do
|
|
:private | :reporter | false | :same | true | true
|
|
:private | :reporter | false | :same | false | true
|
|
:private | :reporter | false | :different | true | false
|
|
:private | :reporter | false | :different | false | true
|
|
:private | :guest | false | :same | true | true
|
|
:private | :guest | false | :same | false | true
|
|
:private | :guest | false | :different | true | false
|
|
:private | :guest | false | :different | false | true
|
|
|
|
:internal | :reporter | false | :same | true | true
|
|
:internal | :reporter | true | :same | true | true
|
|
:internal | :reporter | false | :same | false | true
|
|
:internal | :reporter | false | :different | true | true
|
|
:internal | :reporter | true | :different | true | false
|
|
:internal | :reporter | false | :different | false | true
|
|
:internal | :guest | false | :same | true | true
|
|
:internal | :guest | true | :same | true | true
|
|
:internal | :guest | false | :same | false | true
|
|
:internal | :guest | false | :different | true | true
|
|
:internal | :guest | true | :different | true | false
|
|
:internal | :guest | false | :different | false | true
|
|
|
|
:public | :reporter | false | :same | true | true
|
|
:public | :reporter | false | :same | false | true
|
|
:public | :reporter | false | :different | true | true
|
|
:public | :reporter | false | :different | false | true
|
|
:public | :guest | false | :same | true | true
|
|
:public | :guest | false | :same | false | true
|
|
:public | :guest | false | :different | true | true
|
|
:public | :guest | false | :different | false | true
|
|
end
|
|
|
|
with_them do
|
|
let(:current_user) { public_send(user_role) }
|
|
let(:project) { public_send("#{project_visibility}_project") }
|
|
let(:job) { build_stubbed(:ci_build, project: scope_project, user: current_user) }
|
|
|
|
let(:scope_project) do
|
|
if scope_project_type == :same
|
|
project
|
|
else
|
|
create(:project, :private)
|
|
end
|
|
end
|
|
|
|
before do
|
|
current_user.set_ci_job_token_scope!(job)
|
|
current_user.external = external_user
|
|
scope_project.update!(ci_job_token_scope_enabled: token_scope_enabled)
|
|
end
|
|
|
|
it "enforces the expected permissions" do
|
|
if result
|
|
is_expected.to be_allowed("#{user_role}_access".to_sym)
|
|
else
|
|
is_expected.to be_disallowed("#{user_role}_access".to_sym)
|
|
end
|
|
end
|
|
end
|
|
end
|
|
|
|
describe 'container_image policies' do
|
|
using RSpec::Parameterized::TableSyntax
|
|
|
|
# These are permissions that admins should not have when the project is private
|
|
# or the container registry is private.
|
|
let(:admin_excluded_permissions) { [:build_read_container_image] }
|
|
|
|
let(:anonymous_operations_permissions) { [:read_container_image] }
|
|
let(:guest_operations_permissions) { anonymous_operations_permissions + [:build_read_container_image] }
|
|
|
|
let(:developer_operations_permissions) do
|
|
guest_operations_permissions + [
|
|
:create_container_image, :update_container_image, :destroy_container_image
|
|
]
|
|
end
|
|
|
|
let(:maintainer_operations_permissions) do
|
|
developer_operations_permissions + [
|
|
:admin_container_image
|
|
]
|
|
end
|
|
|
|
let(:all_permissions) { maintainer_operations_permissions }
|
|
|
|
where(:project_visibility, :access_level, :role, :allowed) do
|
|
:public | ProjectFeature::ENABLED | :admin | true
|
|
:public | ProjectFeature::ENABLED | :owner | true
|
|
:public | ProjectFeature::ENABLED | :maintainer | true
|
|
:public | ProjectFeature::ENABLED | :developer | true
|
|
:public | ProjectFeature::ENABLED | :reporter | true
|
|
:public | ProjectFeature::ENABLED | :guest | true
|
|
:public | ProjectFeature::ENABLED | :anonymous | true
|
|
:public | ProjectFeature::PRIVATE | :admin | true
|
|
:public | ProjectFeature::PRIVATE | :owner | true
|
|
:public | ProjectFeature::PRIVATE | :maintainer | true
|
|
:public | ProjectFeature::PRIVATE | :developer | true
|
|
:public | ProjectFeature::PRIVATE | :reporter | true
|
|
:public | ProjectFeature::PRIVATE | :guest | false
|
|
:public | ProjectFeature::PRIVATE | :anonymous | false
|
|
:public | ProjectFeature::DISABLED | :admin | false
|
|
:public | ProjectFeature::DISABLED | :owner | false
|
|
:public | ProjectFeature::DISABLED | :maintainer | false
|
|
:public | ProjectFeature::DISABLED | :developer | false
|
|
:public | ProjectFeature::DISABLED | :reporter | false
|
|
:public | ProjectFeature::DISABLED | :guest | false
|
|
:public | ProjectFeature::DISABLED | :anonymous | false
|
|
:internal | ProjectFeature::ENABLED | :admin | true
|
|
:internal | ProjectFeature::ENABLED | :owner | true
|
|
:internal | ProjectFeature::ENABLED | :maintainer | true
|
|
:internal | ProjectFeature::ENABLED | :developer | true
|
|
:internal | ProjectFeature::ENABLED | :reporter | true
|
|
:internal | ProjectFeature::ENABLED | :guest | true
|
|
:internal | ProjectFeature::ENABLED | :anonymous | false
|
|
:internal | ProjectFeature::PRIVATE | :admin | true
|
|
:internal | ProjectFeature::PRIVATE | :owner | true
|
|
:internal | ProjectFeature::PRIVATE | :maintainer | true
|
|
:internal | ProjectFeature::PRIVATE | :developer | true
|
|
:internal | ProjectFeature::PRIVATE | :reporter | true
|
|
:internal | ProjectFeature::PRIVATE | :guest | false
|
|
:internal | ProjectFeature::PRIVATE | :anonymous | false
|
|
:internal | ProjectFeature::DISABLED | :admin | false
|
|
:internal | ProjectFeature::DISABLED | :owner | false
|
|
:internal | ProjectFeature::DISABLED | :maintainer | false
|
|
:internal | ProjectFeature::DISABLED | :developer | false
|
|
:internal | ProjectFeature::DISABLED | :reporter | false
|
|
:internal | ProjectFeature::DISABLED | :guest | false
|
|
:internal | ProjectFeature::DISABLED | :anonymous | false
|
|
:private | ProjectFeature::ENABLED | :admin | true
|
|
:private | ProjectFeature::ENABLED | :owner | true
|
|
:private | ProjectFeature::ENABLED | :maintainer | true
|
|
:private | ProjectFeature::ENABLED | :developer | true
|
|
:private | ProjectFeature::ENABLED | :reporter | true
|
|
:private | ProjectFeature::ENABLED | :guest | false
|
|
:private | ProjectFeature::ENABLED | :anonymous | false
|
|
:private | ProjectFeature::PRIVATE | :admin | true
|
|
:private | ProjectFeature::PRIVATE | :owner | true
|
|
:private | ProjectFeature::PRIVATE | :maintainer | true
|
|
:private | ProjectFeature::PRIVATE | :developer | true
|
|
:private | ProjectFeature::PRIVATE | :reporter | true
|
|
:private | ProjectFeature::PRIVATE | :guest | false
|
|
:private | ProjectFeature::PRIVATE | :anonymous | false
|
|
:private | ProjectFeature::DISABLED | :admin | false
|
|
:private | ProjectFeature::DISABLED | :owner | false
|
|
:private | ProjectFeature::DISABLED | :maintainer | false
|
|
:private | ProjectFeature::DISABLED | :developer | false
|
|
:private | ProjectFeature::DISABLED | :reporter | false
|
|
:private | ProjectFeature::DISABLED | :guest | false
|
|
:private | ProjectFeature::DISABLED | :anonymous | false
|
|
end
|
|
|
|
with_them do
|
|
let(:current_user) { send(role) }
|
|
let(:project) { send("#{project_visibility}_project") }
|
|
|
|
before do
|
|
enable_admin_mode!(admin) if role == :admin
|
|
project.project_feature.update!(container_registry_access_level: access_level)
|
|
end
|
|
|
|
it 'allows/disallows the abilities based on the container_registry feature access level' do
|
|
if allowed
|
|
expect_allowed(*permissions_abilities(role))
|
|
expect_disallowed(*(all_permissions - permissions_abilities(role)))
|
|
else
|
|
expect_disallowed(*all_permissions)
|
|
end
|
|
end
|
|
|
|
it 'allows build_read_container_image to admins who are also team members' do
|
|
if allowed && role == :admin
|
|
project.add_reporter(current_user)
|
|
|
|
expect_allowed(:build_read_container_image)
|
|
end
|
|
end
|
|
|
|
def permissions_abilities(role)
|
|
case role
|
|
when :admin
|
|
if project_visibility == :private || access_level == ProjectFeature::PRIVATE
|
|
maintainer_operations_permissions - admin_excluded_permissions
|
|
else
|
|
maintainer_operations_permissions
|
|
end
|
|
when :maintainer, :owner
|
|
maintainer_operations_permissions
|
|
when :developer
|
|
developer_operations_permissions
|
|
when :reporter, :guest
|
|
guest_operations_permissions
|
|
when :anonymous
|
|
anonymous_operations_permissions
|
|
else
|
|
raise "Unknown role #{role}"
|
|
end
|
|
end
|
|
end
|
|
end
|
|
|
|
describe 'update_runners_registration_token' do
|
|
context 'when anonymous' do
|
|
let(:current_user) { anonymous }
|
|
|
|
it { is_expected.not_to be_allowed(:update_runners_registration_token) }
|
|
end
|
|
|
|
context 'admin' do
|
|
let(:current_user) { create(:admin) }
|
|
|
|
context 'when admin mode is enabled', :enable_admin_mode do
|
|
it { is_expected.to be_allowed(:update_runners_registration_token) }
|
|
end
|
|
|
|
context 'when admin mode is disabled' do
|
|
it { is_expected.to be_disallowed(:update_runners_registration_token) }
|
|
end
|
|
end
|
|
|
|
%w(guest reporter developer).each do |role|
|
|
context role do
|
|
let(:current_user) { send(role) }
|
|
|
|
it { is_expected.to be_disallowed(:update_runners_registration_token) }
|
|
end
|
|
end
|
|
|
|
%w(maintainer owner).each do |role|
|
|
context role do
|
|
let(:current_user) { send(role) }
|
|
|
|
it { is_expected.to be_allowed(:update_runners_registration_token) }
|
|
end
|
|
end
|
|
end
|
|
|
|
describe 'register_project_runners' do
|
|
context 'admin' do
|
|
let(:current_user) { admin }
|
|
|
|
context 'when admin mode is enabled', :enable_admin_mode do
|
|
context 'with runner_registration_control FF disabled' do
|
|
before do
|
|
stub_feature_flags(runner_registration_control: false)
|
|
end
|
|
|
|
it { is_expected.to be_allowed(:register_project_runners) }
|
|
end
|
|
|
|
context 'with runner_registration_control FF enabled' do
|
|
before do
|
|
stub_feature_flags(runner_registration_control: true)
|
|
end
|
|
|
|
it { is_expected.to be_allowed(:register_project_runners) }
|
|
|
|
context 'with project runner registration disabled' do
|
|
before do
|
|
stub_application_setting(valid_runner_registrars: ['group'])
|
|
end
|
|
|
|
it { is_expected.to be_allowed(:register_project_runners) }
|
|
end
|
|
end
|
|
end
|
|
|
|
context 'when admin mode is disabled' do
|
|
it { is_expected.to be_disallowed(:register_project_runners) }
|
|
end
|
|
end
|
|
|
|
context 'with owner' do
|
|
let(:current_user) { owner }
|
|
|
|
it { is_expected.to be_allowed(:register_project_runners) }
|
|
|
|
context 'with runner_registration_control FF disabled' do
|
|
before do
|
|
stub_feature_flags(runner_registration_control: false)
|
|
end
|
|
|
|
it { is_expected.to be_allowed(:register_project_runners) }
|
|
end
|
|
|
|
context 'with runner_registration_control FF enabled' do
|
|
before do
|
|
stub_feature_flags(runner_registration_control: true)
|
|
end
|
|
|
|
it { is_expected.to be_allowed(:register_project_runners) }
|
|
|
|
context 'with project runner registration disabled' do
|
|
before do
|
|
stub_application_setting(valid_runner_registrars: ['group'])
|
|
end
|
|
|
|
it { is_expected.to be_disallowed(:register_project_runners) }
|
|
end
|
|
end
|
|
end
|
|
|
|
context 'with maintainer' do
|
|
let(:current_user) { maintainer }
|
|
|
|
it { is_expected.to be_allowed(:register_project_runners) }
|
|
end
|
|
|
|
context 'with reporter' do
|
|
let(:current_user) { reporter }
|
|
|
|
it { is_expected.to be_disallowed(:register_project_runners) }
|
|
end
|
|
|
|
context 'with guest' do
|
|
let(:current_user) { guest }
|
|
|
|
it { is_expected.to be_disallowed(:register_project_runners) }
|
|
end
|
|
|
|
context 'with non member' do
|
|
let(:current_user) { create(:user) }
|
|
|
|
it { is_expected.to be_disallowed(:register_project_runners) }
|
|
end
|
|
|
|
context 'with anonymous' do
|
|
let(:current_user) { nil }
|
|
|
|
it { is_expected.to be_disallowed(:register_project_runners) }
|
|
end
|
|
end
|
|
|
|
describe 'update_sentry_issue' do
|
|
using RSpec::Parameterized::TableSyntax
|
|
|
|
where(:role, :allowed) do
|
|
:owner | true
|
|
:maintainer | true
|
|
:developer | true
|
|
:reporter | false
|
|
:guest | false
|
|
end
|
|
|
|
let(:project) { public_project }
|
|
let(:current_user) { public_send(role) }
|
|
|
|
with_them do
|
|
it do
|
|
expect(subject.can?(:update_sentry_issue)).to be(allowed)
|
|
end
|
|
end
|
|
end
|
|
end
|