gitlab-org--gitlab-foss/app
Douwe Maan 0795698162 Merge branch 'new-mr-disable-change-target-branch' into 'master'
Disable changing of target branch in new merge request page when a branch has already been specified

### What does this MR do?

This MR prevents a user from changing the target branch inside a new merge request page if the target branch has already been specified (e.g. from the shortcut in the activity feed). A link to "Change branches" is provided to allow the user to do this properly.

### Why was this MR needed?

If a user attempted to create a merge request from a shortcut with a pre-specified target branch (e.g. `master`), the dropdown would suggest that the user could change the branch. However, this did not actually work due to duplicate data elements (see #1830 for more details), and the target branch would always be set to the original, default branch. This would lead to confusion, potentially causing an improper merge request to be created.

### What are the relevant issue numbers?

Closes #1830

### Screenshot

![image](https://gitlab.com/stanhu/gitlab-ce/uploads/eeec4f5d4b66625a14be41e5ecbdc016/image.png)

See merge request !846
2015-06-20 10:41:07 +00:00
..
assets Minor style fixes for LineHighlighter 2015-06-19 16:43:09 -04:00
controllers Use User#two_factor_enabled instead of otp_required_for_login 2015-06-19 15:14:37 -04:00
finders Set milestone on new issue when creating issue from index with milestone filter active. 2015-05-27 14:22:11 +02:00
helpers Support commenting on a diff in side-by-side view 2015-06-16 06:11:59 -07:00
mailers Prefix EmailsOnPush email subject with `[Git]`. 2015-05-25 16:35:37 +02:00
models Merge branch 'fix-error-500-internal-snippet' into 'master' 2015-06-20 10:38:33 +00:00
services Merge branch 'fix-ext-issue-webbased-hooks' into 'master' 2015-06-16 11:36:31 +00:00
uploaders Fix URL to uploaded file. 2015-02-20 16:01:37 +01:00
views Merge branch 'new-mr-disable-change-target-branch' into 'master' 2015-06-20 10:41:07 +00:00
workers Added X-GitLab-Event header for web hooks 2015-05-08 16:49:03 +03:00