History

Luke Duncalfe 37b17fa61a Add service classes for mutating AwardEmoji Adding, destroying and toggling emoji previously lacked services and instead were performed through methods called on Awardable models. This led to inconsistencies where relevant todos would be marked as done only when emoji were awarded through our controllers, but not through the API. Todos could also be marked as done when an emoji was being removed. Behaviour changes - Awarding emoji through the API will now mark a relevant Todo as done - Toggling an emoji off (destroying it) through our controllers will no longer mark a relevant Todo as done Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/63372		2019-08-21 11:39:41 +12:00
..
admin	…
autocomplete	…
boards	…
clusters	Use separate Kubernetes namespaces per environment	2019-08-07 04:40:29 +00:00
concerns	…
projects	Use separate Kubernetes namespaces per environment	2019-08-07 04:40:29 +00:00
README.md	…
access_requests_finder.rb	…
applications_finder.rb	…
award_emojis_finder.rb	Add service classes for mutating AwardEmoji	2019-08-21 11:39:41 +12:00
branches_finder.rb	Use select instead of filter to support 2.5	2019-08-05 16:07:26 +00:00
cluster_ancestors_finder.rb	…
clusters_finder.rb	…
container_repositories_finder.rb	Add group level container repository endpoints	2019-08-05 20:00:50 +00:00
contributed_projects_finder.rb	…
environments_finder.rb	…
events_finder.rb	…
fork_projects_finder.rb	…
group_descendants_finder.rb	…
group_finder.rb	…
group_labels_finder.rb	…
group_members_finder.rb	Resolve "MembersFinder contains slow database query with OR conditions"	2019-07-29 22:33:57 +00:00
group_projects_finder.rb	…
groups_finder.rb	…
issuable_finder.rb	Revert "Merge branch '4221-board-milestone-should-persist-any-none-properly-ce' into 'master'"	2019-08-09 09:59:38 +00:00
issues_finder.rb	…
joined_groups_finder.rb	…
labels_finder.rb	…
license_template_finder.rb	…
members_finder.rb	Further remove code branches by database type	2019-07-29 12:47:06 +02:00
merge_request_target_project_finder.rb	…
merge_requests_finder.rb	…
milestones_finder.rb	…
notes_finder.rb	Use NotesFinder in IssuableActions module	2019-08-01 10:42:42 +02:00
pending_todos_finder.rb	…
personal_access_tokens_finder.rb	…
personal_projects_finder.rb	…
pipeline_schedules_finder.rb	…
pipelines_finder.rb	…
projects_finder.rb	…
releases_finder.rb	…
runner_jobs_finder.rb	…
snippets_finder.rb	…
starred_projects_finder.rb	Handle reviewer comments on !24690	2019-08-07 20:49:37 +02:00
tags_finder.rb	…
template_finder.rb	…
todos_finder.rb	…
union_finder.rb	…
user_finder.rb	…
user_recent_events_finder.rb	…
users_finder.rb	Change sorting options for starrers: name (asc/desc), most/least recent star	2019-08-07 20:49:14 +02:00
users_star_projects_finder.rb	Handle reviewer comments on !24690	2019-08-07 20:49:37 +02:00
users_with_pending_todos_finder.rb	…

README.md

Finders

This type of classes responsible for collection items based on different conditions. To prevent lookup methods in models like this:

class Project
  def issues_for_user_filtered_by(user, filter)
    # A lot of logic not related to project model itself
  end
end

issues = project.issues_for_user_filtered_by(user, params)

Better use this:

issues = IssuesFinder.new(project, user, filter).execute

It will help keep models thiner.