kotovalexarian-likes-gitlab/gitlab-org--gitlab-foss
1
0
Fork 0
Code Releases Activity
gitlab-org--gitlab-foss/spec/models
History
Douwe Maan b5b17d00ed Merge branch '19092-fix-event-for-legacydiffnote-not-considered-note' into 'master' 
Fix diff comments not showing up in activity feed

## What does this MR do?

It fixes the detection of note events to check for `Note` and `LegacyDiffNote`.

## Are there points in the code the reviewer needs to double check?

No? /cc @DouweM (since I believe you introduced `LegacyDiffNote`

## Why was this MR needed?

To fix #19092.

## What are the relevant issue numbers?

Fixes #19092.

## Does this MR meet the acceptance criteria?

- [x] [CHANGELOG](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CHANGELOG) entry added
- Tests
  - [x] Added for this feature/bug
  - [ ] All builds are passing
- [x] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides)
- [x] Branch has no merge conflicts with `master` (if you do - rebase it please)
- [x] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits)

See merge request !5069
2016-07-06 15:25:54 +00:00
..
ci Rename according to: 2016-06-20 16:52:05 +08:00
concerns Merge branch 'master' into dev-master 2016-07-02 22:58:21 +02:00
hooks Codestyle: make sure we have space around operators 2016-05-13 04:46:56 -03:00
members Enable Style/EmptyLines cop, remove redundant ones 2016-07-01 21:56:17 +02:00
project_services Enable Style/EmptyLines cop, remove redundant ones 2016-07-01 21:56:17 +02:00
ability_spec.rb Refactor Participable 2016-06-01 16:22:35 +02:00
abuse_report_spec.rb Remove the annotate gem and delete old annotations 2016-05-09 18:00:28 +02:00
appearance_spec.rb
application_setting_spec.rb Add Application Setting to configure default Repository Path for new projects 2016-06-29 23:35:00 -04:00
award_emoji_spec.rb Incorportate feedback 2016-06-01 12:10:08 +02:00
blob_spec.rb
broadcast_message_spec.rb Remove the annotate gem and delete old annotations 2016-05-09 18:00:28 +02:00
build_spec.rb Enable Style/EmptyLines cop, remove redundant ones 2016-07-01 21:56:17 +02:00
commit_range_spec.rb Fix note validation spec failures 2016-06-01 10:31:46 -07:00
commit_spec.rb Optimize Banzai::Filter::RelativeLinkFilter 2016-06-21 10:53:16 -04:00
commit_status_spec.rb Fix builds API response not including commit data 2016-06-21 14:26:57 +02:00
deploy_key_spec.rb Remove the annotate gem and delete old annotations 2016-05-09 18:00:28 +02:00
deploy_keys_project_spec.rb Remove the annotate gem and delete old annotations 2016-05-09 18:00:28 +02:00
deployment_spec.rb Add specs for models and services 2016-06-14 13:51:12 +02:00
email_spec.rb Enable Style/EmptyLines cop, remove redundant ones 2016-07-01 21:56:17 +02:00
environment_spec.rb Add specs for models and services 2016-06-14 13:51:12 +02:00
event_spec.rb Use a more future-proof check for Note/LegacyDiffNote 2016-07-06 10:08:42 +02:00
external_issue_spec.rb Hide number sign for string prefixed external issues 2016-04-12 10:01:52 +02:00
forked_project_link_spec.rb Enable Style/EmptyLines cop, remove redundant ones 2016-07-01 21:56:17 +02:00
generic_commit_status_spec.rb Rename all [ci_]commit to [ci_]pipeline in specs and features 2016-06-03 16:22:26 +02:00
global_milestone_spec.rb
group_spec.rb Exclude requesters from Project#members, Group#members and User#members 2016-07-01 17:44:46 +02:00
identity_spec.rb Enable Style/EmptyLines cop, remove redundant ones 2016-07-01 21:56:17 +02:00
issue_spec.rb Update specs. Add CHANGELOG entry 2016-06-02 09:25:40 -04:00
key_spec.rb Remove Duplicated keys add UNIQUE index to fingerprint 2016-06-20 13:29:04 +02:00
label_link_spec.rb Remove the annotate gem and delete old annotations 2016-05-09 18:00:28 +02:00
label_spec.rb Allow '?', or '&' for label titles 2016-07-05 20:57:09 -03:00
legacy_diff_note_spec.rb Improve note factory 2016-05-29 15:03:00 -04:00
member_spec.rb Exclude requesters from Project#members, Group#members and User#members 2016-07-01 17:44:46 +02:00
merge_request_spec.rb Don't garbage collect commits that have related DB records like comments 2016-07-04 00:11:33 -04:00
milestone_spec.rb Return a relation with Postgres 2016-05-16 10:25:24 +01:00
namespace_spec.rb Enable Style/EmptyLines cop, remove redundant ones 2016-07-01 21:56:17 +02:00
note_spec.rb Don't garbage collect commits that have related DB records like comments 2016-07-04 00:11:33 -04:00
notification_setting_spec.rb Implement custom notification level options 2016-06-15 11:47:50 -03:00
personal_access_token_spec.rb Fix rubocop spec. 2016-06-03 10:11:36 +05:30
project_group_link_spec.rb Bring ProjectGroupLink model and migrations from EE 2016-03-11 17:47:05 +01:00
project_security_spec.rb Fix some specs 2016-03-20 22:55:08 +01:00
project_snippet_spec.rb Remove the annotate gem and delete old annotations 2016-05-09 18:00:28 +02:00
project_spec.rb Merge branch 'fix/import-url-validator' into 'master' 2016-07-06 15:06:01 +00:00
project_team_spec.rb UI and copywriting improvements 2016-06-14 13:18:14 +02:00
project_wiki_spec.rb Fix hook data for Wiki Page event 2016-05-31 11:24:58 -03:00
protected_branch_spec.rb Remove the annotate gem and delete old annotations 2016-05-09 18:00:28 +02:00
release_spec.rb Remove the annotate gem and delete old annotations 2016-05-09 18:00:28 +02:00
repository_spec.rb Better message for git hooks and file locks 2016-07-04 15:31:49 +03:00
service_spec.rb Enable Style/EmptyLines cop, remove redundant ones 2016-07-01 21:56:17 +02:00
snippet_spec.rb Fix visibility of private project snippets for members when searching 2016-06-22 20:09:19 -03:00
spam_log_spec.rb
todo_spec.rb Remove the annotate gem and delete old annotations 2016-05-09 18:00:28 +02:00
tree_spec.rb
user_spec.rb Fix an information disclosure when requesting access to a group containing private projects 2016-06-24 12:01:48 +02:00
wiki_page_spec.rb