8a72f5c427
This commit adds the module `FromUnion`, which provides the class method `from_union`. This simplifies the process of selecting data from the result of a UNION, and reduces the likelihood of making mistakes. As a result, instead of this: union = Gitlab::SQL::Union.new([foo, bar]) Foo.from("(#{union.to_sql}) #{Foo.table_name}") We can now write this instead: Foo.from_union([foo, bar]) This commit also includes some changes to make this new setup work properly. For example, a bug in Rails 4 (https://github.com/rails/rails/issues/24193) would break the use of `from("sub-query-here").includes(:relation)` in certain cases. There was also a CI query which appeared to repeat a lot of conditions from an outer query on an inner query, which isn't necessary. Finally, we include a RuboCop cop to ensure developers use this new module, instead of using Gitlab::SQL::Union directly. Fixes https://gitlab.com/gitlab-org/gitlab-ce/issues/51307 |
||
---|---|---|
.. | ||
code_reuse | ||
gitlab | ||
migration | ||
rspec | ||
avoid_break_from_strong_memoize_spec.rb | ||
avoid_return_from_blocks_spec.rb | ||
destroy_all_spec.rb | ||
include_sidekiq_worker_spec.rb | ||
line_break_around_conditional_block_spec.rb | ||
prefer_class_methods_over_module_spec.rb | ||
project_path_helper_spec.rb | ||
ruby_interpolation_in_translation_spec.rb | ||
sidekiq_options_queue_spec.rb |