0bcfd0adb3
This rewrote URLs to be absolute URLs. However, for uploads (the most common case), we actually need them to point to not just the GitLab instance, but the project they're from. Thankfully, we can normally get that information from the object we're building the hook for.
56 lines
1.5 KiB
Ruby
56 lines
1.5 KiB
Ruby
require 'spec_helper'
|
|
|
|
describe Gitlab::HookData::IssueBuilder do
|
|
set(:issue) { create(:issue) }
|
|
let(:builder) { described_class.new(issue) }
|
|
|
|
describe '#build' do
|
|
let(:data) { builder.build }
|
|
|
|
it 'includes safe attribute' do
|
|
%w[
|
|
assignee_id
|
|
author_id
|
|
closed_at
|
|
confidential
|
|
created_at
|
|
description
|
|
due_date
|
|
id
|
|
iid
|
|
last_edited_at
|
|
last_edited_by_id
|
|
milestone_id
|
|
moved_to_id
|
|
project_id
|
|
relative_position
|
|
state
|
|
time_estimate
|
|
title
|
|
updated_at
|
|
updated_by_id
|
|
].each do |key|
|
|
expect(data).to include(key)
|
|
end
|
|
end
|
|
|
|
it 'includes additional attrs' do
|
|
expect(data).to include(:total_time_spent)
|
|
expect(data).to include(:human_time_estimate)
|
|
expect(data).to include(:human_total_time_spent)
|
|
expect(data).to include(:assignee_ids)
|
|
end
|
|
|
|
context 'when the issue has an image in the description' do
|
|
let(:issue_with_description) { create(:issue, description: 'test') }
|
|
let(:builder) { described_class.new(issue_with_description) }
|
|
|
|
it 'sets the image to use an absolute URL' do
|
|
expected_path = "#{issue_with_description.project.path_with_namespace}/uploads/abc/Issue_Image.png"
|
|
|
|
expect(data[:description])
|
|
.to eq("test")
|
|
end
|
|
end
|
|
end
|
|
end
|