gitlab-org--gitlab-foss/spec/services/merge_requests
Jan Provaznik d973872072 Save and expose only generic merge error
When an error occurs during merge, the error message is exposed to user
and it is also saved in DB. This error message may be user unfriendly
(as in !41820) and it could also expose a detailed backend information.

Instead of displaying the specific error message, only sanitized generic
message is displayed. This is potentially controversial change because
disadvantage is that user doesn't get specific reason of failure.

Additional changes:
* repository.merge including exceptions is is extracted into a
separate method to make things clearer
* update! is used instead of update so we don't silently ignore
an error

Related to !41857
2018-05-02 09:22:20 +02:00
..
conflicts Fix 500 error when MR from fork has conflicts but worker has not run 2018-04-06 12:16:51 +01:00
add_todo_when_build_fails_service_spec.rb Use :empty_project where possible in service specs 2017-03-27 20:44:09 -04:00
assign_issues_service_spec.rb Replace '.team << [user, role]' with 'add_role(user)' in specs 2017-12-22 19:18:28 +11:00
build_service_spec.rb Fetch commit signatures from Gitaly in batches 2018-03-01 18:31:31 +01:00
close_service_spec.rb Make user/author use project.creator in most factories 2018-01-31 18:31:21 +01:00
create_from_issue_service_spec.rb Port read_cross_project ability from EE 2018-02-22 17:11:36 +01:00
create_service_spec.rb Prevent new merge requests for archived projects 2018-04-11 10:51:14 +02:00
ff_merge_service_spec.rb Make user/author use project.creator in most factories 2018-01-31 18:31:21 +01:00
get_urls_service_spec.rb Add a project forks spec helper 2017-10-07 11:46:23 +02:00
merge_request_diff_cache_service_spec.rb Only cache MR diffs for one week 2018-03-15 11:49:53 +00:00
merge_service_spec.rb Save and expose only generic merge error 2018-05-02 09:22:20 +02:00
merge_when_pipeline_succeeds_service_spec.rb Enable RuboCop Style/RegexpLiteral 2018-02-01 02:06:07 +09:00
post_merge_service_spec.rb Cache merged and closed events data in merge_request_metrics table 2018-01-02 17:45:25 -02:00
rebase_service_spec.rb Refactor Gitlab::Git code related to LFS changes for Gitaly migration 2018-02-02 16:27:01 -03:00
refresh_service_spec.rb Send notification emails when push to a merge request 2018-03-26 13:24:52 +01:00
reopen_service_spec.rb Make user/author use project.creator in most factories 2018-01-31 18:31:21 +01:00
resolved_discussion_notification_service_spec.rb Remove superfluous lib: true, type: redis, service: true, models: true, services: true, no_db: true, api: true 2017-07-27 14:31:53 +02:00
update_service_spec.rb Allow a user to select allow maintainer to push 2018-03-07 15:12:31 +01:00