2cd7b78391
Correct the ordering of metrics on performance dashboard. Before common metrics were moved into the DB, metric groups were ordered by the priority defined in the common_metrics.yml file. This commit adds a priority to each metric group in the PrometheusMetric model. It also combines title, priority and required_metrics into one frozen GROUP_DETAILS hash so that the code is clearer. This can be done since there is a fixed set of groups which are not configurable.
48 lines
1.6 KiB
Ruby
48 lines
1.6 KiB
Ruby
# frozen_string_literal: true
|
|
|
|
require 'rails_helper'
|
|
|
|
describe Gitlab::Prometheus::MetricGroup do
|
|
describe '.common_metrics' do
|
|
let!(:project_metric) { create(:prometheus_metric) }
|
|
let!(:common_metric_group_a) { create(:prometheus_metric, :common, group: :aws_elb) }
|
|
let!(:common_metric_group_b_q1) { create(:prometheus_metric, :common, group: :kubernetes) }
|
|
let!(:common_metric_group_b_q2) { create(:prometheus_metric, :common, group: :kubernetes) }
|
|
|
|
subject { described_class.common_metrics }
|
|
|
|
it 'returns exactly two groups' do
|
|
expect(subject.map(&:name)).to contain_exactly(
|
|
'Response metrics (AWS ELB)', 'System metrics (Kubernetes)')
|
|
end
|
|
|
|
it 'returns exactly three metric queries' do
|
|
expect(subject.map(&:metrics).flatten.map(&:id)).to contain_exactly(
|
|
common_metric_group_a.id, common_metric_group_b_q1.id,
|
|
common_metric_group_b_q2.id)
|
|
end
|
|
|
|
it 'orders by priority' do
|
|
priorities = subject.map(&:priority)
|
|
names = subject.map(&:name)
|
|
expect(priorities).to eq([10, 5])
|
|
expect(names).to eq(['Response metrics (AWS ELB)', 'System metrics (Kubernetes)'])
|
|
end
|
|
end
|
|
|
|
describe '.for_project' do
|
|
let!(:other_project) { create(:project) }
|
|
let!(:project_metric) { create(:prometheus_metric) }
|
|
let!(:common_metric) { create(:prometheus_metric, :common, group: :aws_elb) }
|
|
|
|
subject do
|
|
described_class.for_project(other_project)
|
|
.map(&:metrics).flatten
|
|
.map(&:id)
|
|
end
|
|
|
|
it 'returns exactly one common metric' do
|
|
is_expected.to contain_exactly(common_metric.id)
|
|
end
|
|
end
|
|
end
|