48bb855ece
Fix rubocop offences and add changelog Add email_verified key for feature specs Add code review remarks Add code review remarks Fix specs
128 lines
4.3 KiB
Ruby
128 lines
4.3 KiB
Ruby
# frozen_string_literal: true
|
|
|
|
require 'spec_helper'
|
|
|
|
describe 'OAuth Login', :js, :allow_forgery_protection do
|
|
include DeviseHelpers
|
|
|
|
def enter_code(code)
|
|
fill_in 'user_otp_attempt', with: code
|
|
click_button 'Verify code'
|
|
end
|
|
|
|
def stub_omniauth_config(provider)
|
|
OmniAuth.config.add_mock(provider, OmniAuth::AuthHash.new(provider: provider.to_s, uid: "12345"))
|
|
stub_omniauth_provider(provider)
|
|
end
|
|
|
|
providers = [:github, :twitter, :bitbucket, :gitlab, :google_oauth2,
|
|
:facebook, :cas3, :auth0, :authentiq, :salesforce]
|
|
|
|
around(:all) do |example|
|
|
with_omniauth_full_host { example.run }
|
|
end
|
|
|
|
def login_with_provider(provider, enter_two_factor: false, additional_info: {})
|
|
login_via(provider.to_s, user, uid, remember_me: remember_me, additional_info: additional_info)
|
|
enter_code(user.current_otp) if enter_two_factor
|
|
end
|
|
|
|
providers.each do |provider|
|
|
context "when the user logs in using the #{provider} provider" do
|
|
let(:uid) { 'my-uid' }
|
|
let(:remember_me) { false }
|
|
let(:user) { create(:omniauth_user, extern_uid: uid, provider: provider.to_s) }
|
|
let(:two_factor_user) { create(:omniauth_user, :two_factor, extern_uid: uid, provider: provider.to_s) }
|
|
provider == :salesforce ? let(:additional_info) { { extra: { email_verified: true } } } : let(:additional_info) { {} }
|
|
|
|
before do
|
|
stub_omniauth_config(provider)
|
|
expect(ActiveSession).to receive(:cleanup).with(user).at_least(:once).and_call_original
|
|
end
|
|
|
|
context 'when two-factor authentication is disabled' do
|
|
it 'logs the user in' do
|
|
login_with_provider(provider, additional_info: additional_info)
|
|
|
|
expect(current_path).to eq root_path
|
|
end
|
|
end
|
|
|
|
context 'when two-factor authentication is enabled' do
|
|
let(:user) { two_factor_user }
|
|
|
|
it 'logs the user in' do
|
|
login_with_provider(provider, additional_info: additional_info, enter_two_factor: true)
|
|
|
|
expect(current_path).to eq root_path
|
|
end
|
|
|
|
it 'when bypass-two-factor is enabled' do
|
|
allow(Gitlab.config.omniauth).to receive_messages(allow_bypass_two_factor: true)
|
|
login_via(provider.to_s, user, uid, remember_me: false, additional_info: additional_info)
|
|
expect(current_path).to eq root_path
|
|
end
|
|
|
|
it 'when bypass-two-factor is disabled' do
|
|
allow(Gitlab.config.omniauth).to receive_messages(allow_bypass_two_factor: false)
|
|
login_with_provider(provider, enter_two_factor: true, additional_info: additional_info)
|
|
expect(current_path).to eq root_path
|
|
end
|
|
end
|
|
|
|
context 'when "remember me" is checked' do
|
|
let(:remember_me) { true }
|
|
|
|
context 'when two-factor authentication is disabled' do
|
|
it 'remembers the user after a browser restart' do
|
|
login_with_provider(provider, additional_info: additional_info)
|
|
|
|
clear_browser_session
|
|
|
|
visit(root_path)
|
|
expect(current_path).to eq root_path
|
|
end
|
|
end
|
|
|
|
context 'when two-factor authentication is enabled' do
|
|
let(:user) { two_factor_user }
|
|
|
|
it 'remembers the user after a browser restart' do
|
|
login_with_provider(provider, enter_two_factor: true, additional_info: additional_info)
|
|
|
|
clear_browser_session
|
|
|
|
visit(root_path)
|
|
expect(current_path).to eq root_path
|
|
end
|
|
end
|
|
end
|
|
|
|
context 'when "remember me" is not checked' do
|
|
context 'when two-factor authentication is disabled' do
|
|
it 'does not remember the user after a browser restart' do
|
|
login_with_provider(provider, additional_info: additional_info)
|
|
|
|
clear_browser_session
|
|
|
|
visit(root_path)
|
|
expect(current_path).to eq new_user_session_path
|
|
end
|
|
end
|
|
|
|
context 'when two-factor authentication is enabled' do
|
|
let(:user) { two_factor_user }
|
|
|
|
it 'does not remember the user after a browser restart' do
|
|
login_with_provider(provider, enter_two_factor: true, additional_info: additional_info)
|
|
|
|
clear_browser_session
|
|
|
|
visit(root_path)
|
|
expect(current_path).to eq new_user_session_path
|
|
end
|
|
end
|
|
end
|
|
end
|
|
end
|
|
end
|