23b35e0592
For prepended classes, we need to use `expect_next_instance_of` instead of RSpecs `any_instance_of` variants.
171 lines
5.6 KiB
Ruby
171 lines
5.6 KiB
Ruby
# frozen_string_literal: true
|
|
|
|
require 'spec_helper'
|
|
|
|
describe Admin::ApplicationSettingsController do
|
|
include StubENV
|
|
|
|
let(:group) { create(:group) }
|
|
let(:project) { create(:project, namespace: group) }
|
|
let(:admin) { create(:admin) }
|
|
let(:user) { create(:user)}
|
|
|
|
before do
|
|
stub_env('IN_MEMORY_APPLICATION_SETTINGS', 'false')
|
|
end
|
|
|
|
describe 'GET #usage_data with no access' do
|
|
before do
|
|
sign_in(user)
|
|
end
|
|
|
|
it 'returns 404' do
|
|
get :usage_data, format: :html
|
|
|
|
expect(response.status).to eq(404)
|
|
end
|
|
end
|
|
|
|
describe 'GET #usage_data' do
|
|
before do
|
|
sign_in(admin)
|
|
end
|
|
|
|
it 'returns HTML data' do
|
|
get :usage_data, format: :html
|
|
|
|
expect(response.body).to start_with('<span')
|
|
expect(response.status).to eq(200)
|
|
end
|
|
|
|
it 'returns JSON data' do
|
|
get :usage_data, format: :json
|
|
|
|
body = JSON.parse(response.body)
|
|
expect(body["version"]).to eq(Gitlab::VERSION)
|
|
expect(body).to include('counts')
|
|
expect(response.status).to eq(200)
|
|
end
|
|
end
|
|
|
|
describe 'PUT #update' do
|
|
before do
|
|
sign_in(admin)
|
|
end
|
|
|
|
it 'updates the password_authentication_enabled_for_git setting' do
|
|
put :update, params: { application_setting: { password_authentication_enabled_for_git: "0" } }
|
|
|
|
expect(response).to redirect_to(admin_application_settings_path)
|
|
expect(ApplicationSetting.current.password_authentication_enabled_for_git).to eq(false)
|
|
end
|
|
|
|
it 'updates the default_project_visibility for string value' do
|
|
put :update, params: { application_setting: { default_project_visibility: "20" } }
|
|
|
|
expect(response).to redirect_to(admin_application_settings_path)
|
|
expect(ApplicationSetting.current.default_project_visibility).to eq(Gitlab::VisibilityLevel::PUBLIC)
|
|
end
|
|
|
|
it 'update the restricted levels for string values' do
|
|
put :update, params: { application_setting: { restricted_visibility_levels: %w[10 20] } }
|
|
|
|
expect(response).to redirect_to(admin_application_settings_path)
|
|
expect(ApplicationSetting.current.restricted_visibility_levels).to eq([10, 20])
|
|
end
|
|
|
|
it 'updates the restricted_visibility_levels when empty array is passed' do
|
|
put :update, params: { application_setting: { restricted_visibility_levels: [""] } }
|
|
|
|
expect(response).to redirect_to(admin_application_settings_path)
|
|
expect(ApplicationSetting.current.restricted_visibility_levels).to be_empty
|
|
end
|
|
|
|
it 'updates the receive_max_input_size setting' do
|
|
put :update, params: { application_setting: { receive_max_input_size: "1024" } }
|
|
|
|
expect(response).to redirect_to(admin_application_settings_path)
|
|
expect(ApplicationSetting.current.receive_max_input_size).to eq(1024)
|
|
end
|
|
|
|
it 'updates the default_project_creation for string value' do
|
|
put :update, params: { application_setting: { default_project_creation: ::Gitlab::Access::MAINTAINER_PROJECT_ACCESS } }
|
|
|
|
expect(response).to redirect_to(admin_application_settings_path)
|
|
expect(ApplicationSetting.current.default_project_creation).to eq(::Gitlab::Access::MAINTAINER_PROJECT_ACCESS)
|
|
end
|
|
|
|
context 'external policy classification settings' do
|
|
let(:settings) do
|
|
{
|
|
external_authorization_service_enabled: true,
|
|
external_authorization_service_url: 'https://custom.service/',
|
|
external_authorization_service_default_label: 'default',
|
|
external_authorization_service_timeout: 3,
|
|
external_auth_client_cert: File.read('spec/fixtures/passphrase_x509_certificate.crt'),
|
|
external_auth_client_key: File.read('spec/fixtures/passphrase_x509_certificate_pk.key'),
|
|
external_auth_client_key_pass: "5iveL!fe"
|
|
}
|
|
end
|
|
|
|
it 'updates settings when the feature is available' do
|
|
put :update, params: { application_setting: settings }
|
|
|
|
settings.each do |attribute, value|
|
|
expect(ApplicationSetting.current.public_send(attribute)).to eq(value)
|
|
end
|
|
end
|
|
end
|
|
|
|
describe 'verify panel actions' do
|
|
shared_examples 'renders correct panels' do
|
|
it 'renders correct action on error' do
|
|
expect_next_instance_of(ApplicationSettings::UpdateService) do |service|
|
|
allow(service).to receive(:execute).and_return(false)
|
|
end
|
|
|
|
patch action, params: { application_setting: { unused_param: true } }
|
|
|
|
expect(subject).to render_template(action)
|
|
end
|
|
|
|
it 'redirects to same panel on success' do
|
|
expect_next_instance_of(ApplicationSettings::UpdateService) do |service|
|
|
allow(service).to receive(:execute).and_return(true)
|
|
end
|
|
|
|
referer_path = public_send("#{action}_admin_application_settings_path")
|
|
request.env["HTTP_REFERER"] = referer_path
|
|
|
|
patch action, params: { application_setting: { unused_param: true } }
|
|
|
|
expect(subject).to redirect_to(referer_path)
|
|
end
|
|
end
|
|
|
|
(Admin::ApplicationSettingsController::VALID_SETTING_PANELS - %w(show templates geo)).each do |valid_action|
|
|
it_behaves_like 'renders correct panels' do
|
|
let(:action) { valid_action }
|
|
end
|
|
end
|
|
end
|
|
end
|
|
|
|
describe 'PUT #reset_registration_token' do
|
|
before do
|
|
sign_in(admin)
|
|
end
|
|
|
|
subject { put :reset_registration_token }
|
|
|
|
it 'resets runner registration token' do
|
|
expect { subject }.to change { ApplicationSetting.current.runners_registration_token }
|
|
end
|
|
|
|
it 'redirects the user to admin runners page' do
|
|
subject
|
|
|
|
expect(response).to redirect_to(admin_runners_path)
|
|
end
|
|
end
|
|
end
|