gitlab-org--gitlab-foss/spec/lib
Rémy Coutable 4f39e72773 Merge branch 'image-sizing' into 'master'
Image sizing

## What does this MR do?

Limits image height to fit the screen. The wrapping div is so the image is guaranteed to be a block element without the link area growing to be larger than the image itself.

## Are there points in the code the reviewer needs to double check?

Make sure this can't be done in a more performant or concise way with Banzai.

## Why was this MR needed?

Images were displayed at their full resolution, which made it difficult to read issues when the image height was greater than the viewport height (see #18861).

## What are the relevant issue numbers?

Fixes #18861.

## Screenshots (if relevant)

Before:

![Screen_Shot_2016-06-20_at_3.25.26_PM](/uploads/158424375ade95adcd337ccd34c48747/Screen_Shot_2016-06-20_at_3.25.26_PM.png)

After:

![Screen_Shot_2016-06-20_at_3.24.57_PM](/uploads/f1a3b5f6442e4e3b1067332a547fb1c8/Screen_Shot_2016-06-20_at_3.24.57_PM.png)

## Does this MR meet the acceptance criteria?

- [x] [CHANGELOG](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CHANGELOG) entry added
- [x] Tests
  - [x] Added for this feature/bug
  - [x] All builds are passing
- [x] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides)
- [x] Branch has no merge conflicts with `master` (if you do - rebase it please)
- [x] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits)

cc: @jschatz1 @dzaporozhets @rspeicher

See merge request !4810
2016-06-27 15:45:01 +00:00
..
banzai Wrap images in divs with Banzai and limit max-height. 2016-06-27 09:16:07 -06:00
ci Merge branch 'test-gitlab-ci-ymls' into 'master' 2016-06-27 15:16:19 +00:00
container_registry Fix regression introduced by https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/4669 2016-06-17 13:24:50 +02:00
gitlab Merge branch 'refactor/ci-config-add-entry-error' into 'master' 2016-06-27 08:24:17 +00:00
json_web_token Revert "Fix merge conflicts - squashed commit" 2016-06-03 11:10:17 +02:00
disable_email_interceptor_spec.rb Fix failing `EmailOnPush` spec. 2016-06-10 14:11:02 +05:30
extracts_path_spec.rb Added & use Gitlab::Routing for URL helpers 2016-04-01 11:13:48 +02:00
file_size_validator_spec.rb Tag lib specs 2015-12-09 11:55:42 +01:00
git_ref_validator_spec.rb Tag lib specs 2015-12-09 11:55:42 +01:00
gitlab_spec.rb Add `Gitlab.com?` method 2016-04-12 17:30:11 -04:00
repository_cache_spec.rb Tag lib specs 2015-12-09 11:55:42 +01:00