65840591cd
Prior to this change, health checks checked for writeability of the NFS shards. Given we're moving away from that, this patch extends the checks for Gitaly to check for read and writeability. Potentially some dashboards will break, as over time these metrics will no longer appear as Prometheus doesn't get the data anymore. Observability in the circuit breaker will be reduced, but its not expected to be turned on and the circuit breaker is being removed soon too. Closes https://gitlab.com/gitlab-org/gitaly/issues/1218
58 lines
1.9 KiB
Ruby
58 lines
1.9 KiB
Ruby
require 'spec_helper'
|
|
|
|
describe Gitlab::HealthChecks::GitalyCheck do
|
|
let(:result_class) { Gitlab::HealthChecks::Result }
|
|
let(:repository_storages) { ['default'] }
|
|
|
|
before do
|
|
allow(described_class).to receive(:repository_storages) { repository_storages }
|
|
end
|
|
|
|
describe '#readiness' do
|
|
subject { described_class.readiness }
|
|
|
|
before do
|
|
expect(Gitlab::GitalyClient::HealthCheckService).to receive(:new).and_return(gitaly_check)
|
|
end
|
|
|
|
context 'Gitaly server is up' do
|
|
let(:gitaly_check) { double(check: { success: true }) }
|
|
|
|
it { is_expected.to eq([result_class.new(true, nil, shard: 'default')]) }
|
|
end
|
|
|
|
context 'Gitaly server is down' do
|
|
let(:gitaly_check) { double(check: { success: false, message: 'Connection refused' }) }
|
|
|
|
it { is_expected.to eq([result_class.new(false, 'Connection refused', shard: 'default')]) }
|
|
end
|
|
end
|
|
|
|
describe '#metrics' do
|
|
subject { described_class.metrics }
|
|
let(:server) { double(storage: 'default', read_writeable?: up) }
|
|
|
|
before do
|
|
allow(Gitaly::Server).to receive(:new).and_return(server)
|
|
end
|
|
|
|
context 'Gitaly server is up' do
|
|
let(:up) { true }
|
|
|
|
it 'provides metrics' do
|
|
expect(subject).to all(have_attributes(labels: { shard: 'default' }))
|
|
expect(subject).to include(an_object_having_attributes(name: 'gitaly_health_check_success', value: 1))
|
|
expect(subject).to include(an_object_having_attributes(name: 'gitaly_health_check_latency_seconds', value: be >= 0))
|
|
end
|
|
end
|
|
|
|
context 'Gitaly server is down' do
|
|
let(:up) { false }
|
|
|
|
it 'provides metrics' do
|
|
expect(subject).to include(an_object_having_attributes(name: 'gitaly_health_check_success', value: 0))
|
|
expect(subject).to include(an_object_having_attributes(name: 'gitaly_health_check_latency_seconds', value: be >= 0))
|
|
end
|
|
end
|
|
end
|
|
end
|