gitlab-org--gitlab-foss/app
Fatih Acet 6d12878d5a Merge branch '19161-non-helpful-flash-message-when-attaching-file-fails' into 'master'
Hacked in a better message for attachment network error

## What does this MR do?

Adds a better error message for when a user is uploading an attachment and they cannot reach the GitLab instance.

Now displays `Network error. Please check your connection.`.

## Are there points in the code the reviewer needs to double check?

As noted above, I think this is hacky, ideally this would be sent straight from the backend but if not then this should be handled globally?

/cc @fatihacet 

## Why was this MR needed?

Attachment upload UX

## What are the relevant issue numbers?

Closes #19161.

## Screenshots (if relevant)

*UPDATED:*

![Screen_Shot_2016-06-30_at_00.42.37](/uploads/b3b4044782dd4c4c17735e99acc45502/Screen_Shot_2016-06-30_at_00.42.37.png)

## Does this MR meet the acceptance criteria?

- [ ] [CHANGELOG](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CHANGELOG) entry added
- [ ] [Documentation created/updated](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/doc/development/doc_styleguide.md)
- [ ] API support added
- Tests
  - [ ] Added for this feature/bug
  - [ ] All builds are passing
- [ ] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides)
- [ ] Branch has no merge conflicts with `master` (if you do - rebase it please)
- [ ] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits)

See merge request !4977
2016-07-05 21:51:00 +00:00
..
assets Merge branch '19161-non-helpful-flash-message-when-attaching-file-fails' into 'master' 2016-07-05 21:51:00 +00:00
controllers Merge branch 'git-http-kerberos-ce' into 'master' 2016-07-01 22:24:49 +00:00
finders Expose target, filter by state as string 2016-07-01 14:52:04 +02:00
helpers Merge branch '18790-dont-show-request-button-to-project-owner' into 'master' 2016-07-05 17:24:46 +00:00
mailers Fallback to group's owners/masters when a project has none 2016-06-20 12:10:37 +02:00
models Merge branch '18790-dont-show-request-button-to-project-owner' into 'master' 2016-07-05 17:24:46 +00:00
services Merge branch 'master' of dev.gitlab.org:gitlab/gitlabhq 2016-07-04 21:52:43 +03:00
uploaders Enable Style/SpaceAfterComma Rubocop cop 2016-06-29 15:23:44 +02:00
validators
views Merge branch '18790-dont-show-request-button-to-project-owner' into 'master' 2016-07-05 17:24:46 +00:00
workers Refactor repository paths handling to allow multiple git mount points 2016-06-29 22:30:31 -04:00