f9c456bd0c
Previously, we called the `peek_enabled?` method like so:
prepend_before_action :set_peek_request_id, if: :peek_enabled?
Now we don't have a `set_peek_request_id` method, so we don't need that
line. However, the `peek_enabled?` part had a side-effect: it would also
populate the request store cache for whether the performance bar was
enabled for the current request or not.
This commit makes that side-effect explicit, and replaces all uses of
`peek_enabled?` with the more explicit
`Gitlab::PerformanceBar.enabled_for_request?`. There is one spec that
still sets `SafeRequestStore[:peek_enabled]` directly, because it is
contrasting behaviour with and without a request store enabled.
The upshot is:
1. We still set the value in one place. We make it more explicit that
that's what we're doing.
2. Reading that value uses a consistent method so it's easier to find in
future.
43 lines
1 KiB
Ruby
43 lines
1 KiB
Ruby
# frozen_string_literal: true
|
|
|
|
module Gitlab
|
|
module RuggedInstrumentation
|
|
def self.query_time
|
|
SafeRequestStore[:rugged_query_time] ||= 0
|
|
end
|
|
|
|
def self.query_time=(duration)
|
|
SafeRequestStore[:rugged_query_time] = duration
|
|
end
|
|
|
|
def self.query_time_ms
|
|
(self.query_time * 1000).round(2)
|
|
end
|
|
|
|
def self.query_count
|
|
SafeRequestStore[:rugged_call_count] ||= 0
|
|
end
|
|
|
|
def self.increment_query_count
|
|
SafeRequestStore[:rugged_call_count] ||= 0
|
|
SafeRequestStore[:rugged_call_count] += 1
|
|
end
|
|
|
|
def self.active?
|
|
SafeRequestStore.active?
|
|
end
|
|
|
|
def self.add_call_details(details)
|
|
return unless Gitlab::PerformanceBar.enabled_for_request?
|
|
|
|
Gitlab::SafeRequestStore[:rugged_call_details] ||= []
|
|
Gitlab::SafeRequestStore[:rugged_call_details] << details
|
|
end
|
|
|
|
def self.list_call_details
|
|
return [] unless Gitlab::PerformanceBar.enabled_for_request?
|
|
|
|
Gitlab::SafeRequestStore[:rugged_call_details] || []
|
|
end
|
|
end
|
|
end
|