39203f1adf
This change simplifies a Pipeline processing by introducing a special new status: created. This status is used for all builds that are created for a pipeline. We are then processing next stages and queueing some of the builds (created -> pending) or skipping them (created -> skipped). This makes it possible to simplify and solve a few ordering problems with how previously builds were scheduled. This also allows us to visualise a full pipeline (with created builds). This also removes an after_touch used for updating a pipeline state parameters. Right now in various places we explicitly call a reload_status! on pipeline to force it to be updated and saved.
102 lines
3.5 KiB
Ruby
102 lines
3.5 KiB
Ruby
require 'spec_helper'
|
|
|
|
describe PostReceive do
|
|
let(:changes) { "123456 789012 refs/heads/tést\n654321 210987 refs/tags/tag" }
|
|
let(:wrongly_encoded_changes) { changes.encode("ISO-8859-1").force_encoding("UTF-8") }
|
|
let(:base64_changes) { Base64.encode64(wrongly_encoded_changes) }
|
|
let(:project) { create(:project) }
|
|
let(:key) { create(:key, user: project.owner) }
|
|
let(:key_id) { key.shell_id }
|
|
|
|
context "as a resque worker" do
|
|
it "reponds to #perform" do
|
|
expect(PostReceive.new).to respond_to(:perform)
|
|
end
|
|
end
|
|
|
|
describe "#process_project_changes" do
|
|
before do
|
|
allow_any_instance_of(Gitlab::GitPostReceive).to receive(:identify).and_return(project.owner)
|
|
end
|
|
|
|
context "branches" do
|
|
let(:changes) { "123456 789012 refs/heads/tést" }
|
|
|
|
it "calls GitTagPushService" do
|
|
expect_any_instance_of(GitPushService).to receive(:execute).and_return(true)
|
|
expect_any_instance_of(GitTagPushService).not_to receive(:execute)
|
|
PostReceive.new.perform(pwd(project), key_id, base64_changes)
|
|
end
|
|
end
|
|
|
|
context "tags" do
|
|
let(:changes) { "123456 789012 refs/tags/tag" }
|
|
|
|
it "calls GitTagPushService" do
|
|
expect_any_instance_of(GitPushService).not_to receive(:execute)
|
|
expect_any_instance_of(GitTagPushService).to receive(:execute).and_return(true)
|
|
PostReceive.new.perform(pwd(project), key_id, base64_changes)
|
|
end
|
|
end
|
|
|
|
context "merge-requests" do
|
|
let(:changes) { "123456 789012 refs/merge-requests/123" }
|
|
|
|
it "does not call any of the services" do
|
|
expect_any_instance_of(GitPushService).not_to receive(:execute)
|
|
expect_any_instance_of(GitTagPushService).not_to receive(:execute)
|
|
PostReceive.new.perform(pwd(project), key_id, base64_changes)
|
|
end
|
|
end
|
|
|
|
context "gitlab-ci.yml" do
|
|
subject { PostReceive.new.perform(pwd(project), key_id, base64_changes) }
|
|
|
|
context "creates a Ci::Pipeline for every change" do
|
|
before do
|
|
allow_any_instance_of(Ci::CreatePipelineService).to receive(:commit) do
|
|
OpenStruct.new(id: '123456')
|
|
end
|
|
allow_any_instance_of(Ci::CreatePipelineService).to receive(:branch?).and_return(true)
|
|
stub_ci_pipeline_to_return_yaml_file
|
|
end
|
|
|
|
it { expect{ subject }.to change{ Ci::Pipeline.count }.by(2) }
|
|
end
|
|
|
|
context "does not create a Ci::Pipeline" do
|
|
before { stub_ci_pipeline_yaml_file(nil) }
|
|
|
|
it { expect{ subject }.not_to change{ Ci::Pipeline.count } }
|
|
end
|
|
end
|
|
end
|
|
|
|
context "webhook" do
|
|
it "fetches the correct project" do
|
|
expect(Project).to receive(:find_with_namespace).with(project.path_with_namespace).and_return(project)
|
|
PostReceive.new.perform(pwd(project), key_id, base64_changes)
|
|
end
|
|
|
|
it "does not run if the author is not in the project" do
|
|
allow(Key).to receive(:find_by).with(hash_including(id: anything())) { nil }
|
|
|
|
expect(project).not_to receive(:execute_hooks)
|
|
|
|
expect(PostReceive.new.perform(pwd(project), key_id, base64_changes)).to be_falsey
|
|
end
|
|
|
|
it "asks the project to trigger all hooks" do
|
|
allow(Project).to receive(:find_with_namespace).and_return(project)
|
|
expect(project).to receive(:execute_hooks).twice
|
|
expect(project).to receive(:execute_services).twice
|
|
expect(project).to receive(:update_merge_requests)
|
|
|
|
PostReceive.new.perform(pwd(project), key_id, base64_changes)
|
|
end
|
|
end
|
|
|
|
def pwd(project)
|
|
File.join(Gitlab.config.repositories.storages.default, project.path_with_namespace)
|
|
end
|
|
end
|