Fatih Acet 88fa5916ff Merge branch '22343-honor-user-fixed-layout-pref' into 'master' ... Ensure the 'fixed layout' preference is honored whenever possible ## What does this MR do? Currently, when viewing any Merge Request the user's fixed-layout preference is overridden if they have set "Side-by-Side" view as their preference when viewing diffs. This makes sense if they are currently viewing a diff, but this is confusing when their layout preference is overridden while they are on another tab (i.e. "Discussion" or "Builds"). This MR moves all responsibility for overriding the fixed layout from the Ruby page layout helper into frontend JavaScript where it is only applied when needed. ## Are there points in the code the reviewer needs to double check? Check that nothing broke for users which have their layout preference set to "Fluid" as well as those which have it set to "Fixed". I've already done this but double checking is always good idea 😄. ## Screenshots (if relevant)  ## Does this MR meet the acceptance criteria? - [x] [CHANGELOG](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CHANGELOG) entry added - Tests - [ ] All builds are passing - [x] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides) - [x] Branch has no merge conflicts with `master` (if you do - rebase it please) - [x] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits) ## What are the relevant issue numbers? Closes #22343 ## Other Notes As @lbennett noted in #22343, this is something of a band-aid. It fixed most of the issue, but we still need to have a discussion about whether or not is acceptable to override user layout preferences for "Side-by-Side" views in general. At least this MR limits the scope of this behavior to a single tab within an MR or merge conflict page. See merge request !6422		2016-10-04 11:58:15 +00:00
..
appearances_helper.rb	Improve performance of MR show page	2016-08-18 19:08:59 -05:00
application_helper.rb	Cache the issuable counters for 2 minutes	2016-09-30 12:02:54 +02:00
application_settings_helper.rb	Support integration with Koding (online IDE)	2016-08-19 12:10:58 -07:00
auth_helper.rb
avatars_helper.rb	Fix layout issues with blame table	2016-09-06 10:36:09 +01:00
award_emoji_helper.rb	Fix tests for Snippets toggling awards	2016-09-19 19:53:09 +03:00
blob_helper.rb	Move editor paths to helper	2016-08-19 16:17:14 +01:00
branches_helper.rb
broadcast_messages_helper.rb
button_helper.rb
ci_status_helper.rb	Commit status icon now links to pipelines tab of commit view	2016-09-27 22:11:13 +01:00
commits_helper.rb	Eliminate unneeded calls to Repository#blob_at when listing commits with no path	2016-08-17 17:07:08 +02:00
compare_helper.rb	Project tools visibility level	2016-09-01 11:47:59 -03:00
dashboard_helper.rb
diff_helper.rb
dropdowns_helper.rb
emails_helper.rb
events_helper.rb
explore_helper.rb
external_wiki_helper.rb
form_helper.rb
git_helper.rb	Improve merge request version feature	2016-09-07 10:24:48 +03:00
gitlab_markdown_helper.rb
gitlab_routing_helper.rb	Merge branch 'and-you-get-awards' into 'master'	2016-09-21 15:22:28 +00:00
graph_helper.rb
groups_helper.rb	Syntax fixes and better tests for helper methods. Updated docs.	2016-09-15 14:10:49 -05:00
icons_helper.rb
import_helper.rb	Don't create groups for unallowed users when importing projects	2016-08-31 12:55:45 -03:00
issuables_helper.rb	Small improvements thanks to Robert's feedback	2016-09-30 12:02:54 +02:00
issues_helper.rb	Award tooltips refer to current user as "You"	2016-08-17 21:25:39 +01:00
javascript_helper.rb
kerberos_spnego_helper.rb
labels_helper.rb
lfs_helper.rb	Use GitLab Routing helpers for the documentation URL in LfsHelper	2016-09-26 17:23:00 -05:00
members_helper.rb
merge_requests_helper.rb	Improve merge request version feature	2016-09-07 10:24:48 +03:00
milestones_helper.rb	Ensure milestone counts work with no data	2016-09-07 15:27:14 -05:00
namespaces_helper.rb	few fixes based on MR feedback	2016-09-20 10:15:20 +02:00
nav_helper.rb	remove dead code - 'collapsed_nav' cookie no longer used since a1fbdbb6 (see MR !4579)	2016-09-07 14:02:21 -05:00
notes_helper.rb	Fix note form hint showing slash commands supported for commits	2016-09-20 13:58:14 +02:00
notifications_helper.rb
page_layout_helper.rb	ensure the 'fixed layout' preference is honored whenever possible	2016-09-20 00:51:00 -05:00
preferences_helper.rb
projects_helper.rb	Enable Lint/StringConversionInInterpolation cop and autocorrect offenses	2016-10-03 16:09:57 +02:00
runners_helper.rb
search_helper.rb	Backport search_helper changes from EE	2016-09-14 14:31:02 +03:00
selects_helper.rb
sentry_helper.rb	Fix Sentry not reporting right program for Sidekiq workers	2016-08-25 19:42:52 -07:00
services_helper.rb	Add option to confidential issues events to trigger services	2016-08-31 18:34:45 -03:00
sidekiq_helper.rb	Remove original regexp	2016-09-08 19:41:25 +02:00
snippets_helper.rb	Reordered dropdown options	2016-09-07 15:12:03 +01:00
sorting_helper.rb
submodule_helper.rb
tab_helper.rb
tags_helper.rb	filters tags by name	2016-08-31 11:42:33 +01:00
time_helper.rb
todos_helper.rb	Removed try method call on due date	2016-10-03 15:07:35 +01:00
tree_helper.rb
triggers_helper.rb
u2f_helper.rb
version_check_helper.rb
visibility_level_helper.rb
workhorse_helper.rb	Verify JWT messages from gitlab-workhorse	2016-09-05 15:05:31 +02:00