gitlab-org--gitlab-foss/spec/javascripts
Alfredo Sumaran 4e68b88193 Merge branch 'clean-no-undef' into 'master'
Explicitly declare all javascript globals and all eslint rule violations

This merge request takes every single external global variable referenced within a javascript file and explicitly marks it with a `/* global Foo */` comment block at the top of the script.

This also expands all blanket instances of `/* eslint-disable */` with an explicit list of disabled rules.  This is useful because if we need to search for violations of a particular rule we can simply grep the codebase for something like `no-unused-vars` or `semi` and find all of the places where this rule has yet to be fixed.

Lastly, it also removes and resolves any existing `no-undef` eslint violations.  This is useful for catching mistakes like forgetting to declare a variable with `var`/`let`/`const` which can cause hard to find bugs.

## What does this MR do?

1. Looks for generic uses of `/* eslint-disable */` and refactors them into individual rule exceptions.
2. Looks for all occurrences of `/* eslint-disable ... no-undef */` and resolves them by either fixing bugs or declaring globals with `/* global Foo */`.

## Are there points in the code the reviewer needs to double check?

This touches a lot of files, most changes touch nothing other than comment blocks or whitespace.  The exceptions are the following 14 files which required some small bug fixes after removing `no-undef`:

- api.js
- breakpoints.js
- build.js
- commits.js
- diff_notes/components/jump_to_discussion.js.es6
- gfm_auto_complete.js.es6
- gl_dropdown.js
- groups_select.js
- importer_status.js
- namespace_select.js
- notes.js
- preview_markdown.js
- projects_list.js
- single_file_diff.js

## Why was this MR needed?

Removal of ~"technical debt" and some necessary changes to help !7288 

## Screenshots (if relevant)

N/A

## Does this MR meet the acceptance criteria?

- [ ] ~~[Changelog entry](https://docs.gitlab.com/ce/development/changelog.html) added~~
- [ ] ~~[Documentation created/updated](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/doc/development/doc_styleguide.md)~~
- [ ] ~~API support added~~
- Tests
  - [ ] ~~Added for this feature/bug~~
  - [ ] All builds are passing
- [x] Conform by the [merge request performance guides](http://docs.gitlab.com/ce/development/merge_request_performance_guidelines.html)
- [x] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides)
- [x] Branch has no merge conflicts with `master` (if it does - rebase it please)
- [x] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits)

## What are the relevant issue numbers?

N/A

See merge request !8043
2016-12-15 00:52:46 +00:00
..
behaviors resolve all instances of no-undef eslint rule violations 2016-12-14 02:11:13 -06:00
boards expand remaining non-explicit eslint-disable blocks and factor out globals when no-undef encountered 2016-12-13 21:07:31 -06:00
environments
extensions
fixtures
graphs resolve all instances of no-undef eslint rule violations 2016-12-14 02:11:13 -06:00
lib/utils Fix broken test in chrome 2016-12-13 11:04:43 +00:00
u2f resolve all instances of no-undef eslint rule violations 2016-12-14 02:11:13 -06:00
vue_common_components
.eslintrc
abuse_reports_spec.js.es6 expand remaining non-explicit eslint-disable blocks and factor out globals when no-undef encountered 2016-12-13 21:07:31 -06:00
activities_spec.js.es6 expand remaining non-explicit eslint-disable blocks and factor out globals when no-undef encountered 2016-12-13 21:07:31 -06:00
awards_handler_spec.js resolve all instances of no-undef eslint rule violations 2016-12-14 02:11:13 -06:00
bootstrap_linked_tabs_spec.js.es6
build_spec.js.es6
dashboard_spec.js.es6 expand remaining non-explicit eslint-disable blocks and factor out globals when no-undef encountered 2016-12-13 21:07:31 -06:00
datetime_utility_spec.js.es6 expand remaining non-explicit eslint-disable blocks and factor out globals when no-undef encountered 2016-12-13 21:07:31 -06:00
diff_comments_store_spec.js.es6 expand remaining non-explicit eslint-disable blocks and factor out globals when no-undef encountered 2016-12-13 21:07:31 -06:00
gl_dropdown_spec.js.es6 expand remaining non-explicit eslint-disable blocks and factor out globals when no-undef encountered 2016-12-13 21:07:31 -06:00
gl_field_errors_spec.js.es6 expand remaining non-explicit eslint-disable blocks and factor out globals when no-undef encountered 2016-12-13 21:07:31 -06:00
header_spec.js
issue_spec.js resolve all instances of no-undef eslint rule violations 2016-12-14 02:11:13 -06:00
labels_issue_sidebar_spec.js.es6 resolve all instances of no-undef eslint rule violations 2016-12-14 02:11:13 -06:00
line_highlighter_spec.js resolve all instances of no-undef eslint rule violations 2016-12-14 02:11:13 -06:00
merge_request_spec.js resolve all instances of no-undef eslint rule violations 2016-12-14 02:11:13 -06:00
merge_request_tabs_spec.js
merge_request_widget_spec.js
new_branch_spec.js resolve all instances of no-undef eslint rule violations 2016-12-14 02:11:13 -06:00
notes_spec.js resolve all instances of no-undef eslint rule violations 2016-12-14 02:11:13 -06:00
pipelines_spec.js.es6
pretty_time_spec.js.es6
project_title_spec.js resolve all instances of no-undef eslint rule violations 2016-12-14 02:11:13 -06:00
right_sidebar_spec.js resolve all instances of no-undef eslint rule violations 2016-12-14 02:11:13 -06:00
search_autocomplete_spec.js
shortcuts_issuable_spec.js resolve all instances of no-undef eslint rule violations 2016-12-14 02:11:13 -06:00
signin_tabs_memoizer_spec.js.es6
smart_interval_spec.js.es6
spec_helper.js
subbable_resource_spec.js.es6 expand remaining non-explicit eslint-disable blocks and factor out globals when no-undef encountered 2016-12-13 21:07:31 -06:00
syntax_highlight_spec.js
zen_mode_spec.js resolve all instances of no-undef eslint rule violations 2016-12-14 02:11:13 -06:00