66 lines
1.7 KiB
Ruby
66 lines
1.7 KiB
Ruby
# frozen_string_literal: true
|
|
|
|
module RuboCop
|
|
module Cop
|
|
class StaticTranslationDefinition < RuboCop::Cop::Cop
|
|
MSG = "The text you're translating will be already in the translated form when it's assigned to the constant. When a users changes the locale, these texts won't be translated again. Consider moving the translation logic to a method."
|
|
|
|
TRANSLATION_METHODS = %i[_ s_ n_].freeze
|
|
|
|
def_node_matcher :translation_method?, <<~PATTERN
|
|
(send _ _ str*)
|
|
PATTERN
|
|
|
|
def_node_matcher :lambda_node?, <<~PATTERN
|
|
(send _ :lambda)
|
|
PATTERN
|
|
|
|
def_node_matcher :struct_constant_assignment?, <<~PATTERN
|
|
(casgn _ _ `(const _ :Struct))
|
|
PATTERN
|
|
|
|
def on_send(node)
|
|
return unless translation_method?(node)
|
|
|
|
method_name = node.children[1]
|
|
return unless TRANSLATION_METHODS.include?(method_name)
|
|
|
|
translation_memoized = false
|
|
|
|
node.each_ancestor do |ancestor|
|
|
receiver, _ = *ancestor
|
|
break if lambda_node?(receiver) # translations defined in lambda nodes should be allowed
|
|
|
|
if constant_assignment?(ancestor) && !struct_constant_assignment?(ancestor)
|
|
add_offense(node, location: :expression)
|
|
|
|
break
|
|
end
|
|
|
|
translation_memoized = true if memoization?(ancestor)
|
|
|
|
if translation_memoized && class_method_definition?(ancestor)
|
|
add_offense(node, location: :expression)
|
|
|
|
break
|
|
end
|
|
end
|
|
end
|
|
|
|
private
|
|
|
|
def constant_assignment?(node)
|
|
node.type == :casgn
|
|
end
|
|
|
|
def memoization?(node)
|
|
node.type == :or_asgn
|
|
end
|
|
|
|
def class_method_definition?(node)
|
|
node.type == :defs
|
|
end
|
|
end
|
|
end
|
|
end
|